From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id F086E7D082 for ; Mon, 15 Oct 2018 15:49:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726614AbeJOXfN (ORCPT ); Mon, 15 Oct 2018 19:35:13 -0400 Received: from mga03.intel.com ([134.134.136.65]:61101 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726515AbeJOXfN (ORCPT ); Mon, 15 Oct 2018 19:35:13 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 08:49:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,385,1534834800"; d="scan'208";a="271484375" Received: from spandruv-desk.jf.intel.com ([10.54.75.31]) by fmsmga005.fm.intel.com with ESMTP; 15 Oct 2018 08:49:24 -0700 Message-ID: Subject: Re: [PATCH v3 3/3] Documentation: intel_pstate: Add base_frequency information From: Srinivas Pandruvada To: "Rafael J. Wysocki" Cc: Jonathan Corbet , "Rafael J. Wysocki" , Len Brown , Viresh Kumar , Robert Moore , "Schmauss, Erik" , Juri Lelli , "open list:DOCUMENTATION" , Linux Kernel Mailing List , ACPI Devel Maling List , Linux PM , devel@acpica.org, Prashanth Prakash , George Cherian Date: Mon, 15 Oct 2018 08:49:24 -0700 In-Reply-To: References: <20181012164400.3479-1-srinivas.pandruvada@linux.intel.com> <20181012164400.3479-4-srinivas.pandruvada@linux.intel.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-1.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Mon, 2018-10-15 at 10:53 +0200, Rafael J. Wysocki wrote: > On Fri, Oct 12, 2018 at 6:44 PM Srinivas Pandruvada > wrote: > > > > Updated documentation to explain base_frequency attribute. > > > > Signed-off-by: Srinivas Pandruvada < > > srinivas.pandruvada@linux.intel.com> > > --- > > Documentation/admin-guide/pm/intel_pstate.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/admin-guide/pm/intel_pstate.rst > > b/Documentation/admin-guide/pm/intel_pstate.rst > > index 8f1d3de449b5..14a5505e073e 100644 > > --- a/Documentation/admin-guide/pm/intel_pstate.rst > > +++ b/Documentation/admin-guide/pm/intel_pstate.rst > > @@ -465,6 +465,10 @@ Next, the following policy attributes have > > special meaning if > > policy for the time interval between the last two > > invocations of the > > driver's utilization update callback by the CPU scheduler > > for that CPU. > > > > +``base_frequency`` > > + When present, shows the base frequency of the CPU. Any > > frequency above > > + this will be in the turbo frequency range. > > + > > This isn't entirely correct, because base_frequency is not present in > the passive mode (and it is not present for the other drivers for > that > matter). That's why it said, "when present". This keeps door open to add to other modes too in future if needed. Thanks, Srinivas > > > The meaning of these attributes in the `passive mode > Mode_>`_ is the > > same as for other scaling drivers. > > Instead, I would say: > > "One more policy attribute is present if the `HWP feature is enabled > in the processor `_:" > > here and I would add the description of the attribute below. > > Thanks, > Rafael