From: Randy Dunlap <rdunlap@infradead.org>
To: Bart Van Assche <bvanassche@acm.org>,
Omokefe Emmanuel Onanaroghene <emmaonana18@gmail.com>,
peterz@infradead.org, elver@google.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: corbet@lwn.net, skhan@linuxfoundation.org, mchehab@kernel.org,
aleksandr.loktionov@intel.com, kees@kernel.org,
tudor.ambarus@linaro.org
Subject: Re: [PATCH] docs: kdoc: parse context_lock_struct() as struct declaration
Date: Fri, 25 Sep 2026 21:56:08 -0700 [thread overview]
Message-ID: <c8e90d92-7a1e-4a43-ac8a-4f570a47c353@infradead.org> (raw)
In-Reply-To: <5315b896-e496-4020-9e46-77ffb942ea37@acm.org>
On 9/25/26 5:14 PM, Bart Van Assche wrote:
> On 9/25/26 4:40 PM, Omokefe Emmanuel Onanaroghene wrote:
>> kernel-doc fails to parse struct declarations wrapped in
>> context_lock_struct(), e.g. struct debugfs_cancellation:
>
> Has this alternative been considered: instead of modifying
> tools/lib/python/kdoc/kdoc_parser.py, apply the following change:
I don't think that has been tried/considered.
I'm OK with it if Marco & Peter are.
> diff --git a/include/linux/debugfs.h b/include/linux/debugfs.h
> index 4177c4738282..aa591f0b0920 100644
> --- a/include/linux/debugfs.h
> +++ b/include/linux/debugfs.h
> @@ -233,13 +233,14 @@ ssize_t debugfs_write_file_bool(struct file *file, const char __user *user_buf,
> ssize_t debugfs_read_file_str(struct file *file, char __user *user_buf,
> size_t count, loff_t *ppos);
>
> +context_lock_struct(debugfs_cancellation);
> /**
> * struct debugfs_cancellation - cancellation data
> * @list: internal, for keeping track
> * @cancel: callback to call
> * @cancel_data: extra data for the callback to call
> */
> -context_lock_struct(debugfs_cancellation) {
> +struct debugfs_cancellation {
> struct list_head list;
> void (*cancel)(struct dentry *, void *);
> void *cancel_data;
>
> Thanks,
>
> Bart.
thanks.
--
~Randy
next prev parent reply other threads:[~2026-09-26 4:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 23:40 [PATCH] docs: kdoc: parse context_lock_struct() as struct declaration Omokefe Emmanuel Onanaroghene
2026-09-26 0:14 ` Bart Van Assche
2026-09-26 4:56 ` Randy Dunlap [this message]
2026-09-26 9:54 ` Omokefe Emmanuel Onanaroghene
2026-09-26 15:16 ` Jonathan Corbet
2026-09-26 16:24 ` Omokefe Emmanuel Onanaroghene
2026-09-26 16:35 ` Jonathan Corbet
2026-09-26 18:41 ` Randy Dunlap
2026-09-28 10:47 ` Marco Elver
2026-09-28 15:18 ` Loktionov, Aleksandr
2026-09-28 17:23 ` Randy Dunlap
2026-09-29 23:06 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8e90d92-7a1e-4a43-ac8a-4f570a47c353@infradead.org \
--to=rdunlap@infradead.org \
--cc=aleksandr.loktionov@intel.com \
--cc=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=elver@google.com \
--cc=emmaonana18@gmail.com \
--cc=kees@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=peterz@infradead.org \
--cc=skhan@linuxfoundation.org \
--cc=tudor.ambarus@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox