From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9683C54EAA for ; Sun, 22 Jan 2023 11:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229566AbjAVLtl (ORCPT ); Sun, 22 Jan 2023 06:49:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbjAVLtk (ORCPT ); Sun, 22 Jan 2023 06:49:40 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B95371CF4E for ; Sun, 22 Jan 2023 03:49:37 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id z5so8463850wrt.6 for ; Sun, 22 Jan 2023 03:49:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=L18XUoVuVYI0pnqHwuAZ/a/gl46rC1ac5Z5pGu4tjjA=; b=caIlICVgjiM2KQmWSw2+dwCmFwH/QmHP5Tpt6H6wVsFqVFanIJ1vuRkXD5LMYCDALE NRjmF+0baehzfnLLnyNncgVe/LMpVF+yHU61SKAbBoH7z61KGzW5m7flF/bFqihPw1Fn O2fP7zc3nkMy81LxNCpHIWtu94zfu5UQvaOFSsNE8v5AYfQqfr8/s8K8Erb8fkRN+yAG wkyY17RV1LAoGfa7M6MaWtFsVRYyBEJ/Cn1lnFbJ+7C3TkgZU6XRz0KkmJz40bv2YJcl sWZRDoQaWXDOf5NedqV2uevyts9HBVC/g4grs5Il5oF6YrOPf4Yvjvay3LwHgph5/uVF hkvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L18XUoVuVYI0pnqHwuAZ/a/gl46rC1ac5Z5pGu4tjjA=; b=jLulIUhscPPerjy8GuXCNyDk4IkJkUU8dyCuIEx4Txns0gFb8OpgSONCVNnW3PzyvI fsHvW2nHLr7rIijxMB1UNEitidTTlJqZ8vlyv2FADX9vq3oXLzeWSj5Mt4Y/bu/tlrRk pWtpR0I1kC4zBFBCT1HVXmLH0dLhVpU9q+GD5sEdkQ/ioaS2AQBxpU+lcRhTceZFTnoP VWelgTE8fr/xIjgkGZtyGY35Swm5ChZRDtA9qm+hj9ojkVOivE/M//1ibXGVRbulMn4H eRzbKcbxa4yICIez4LhkQFjYBAzvqJTzpc3JmMpbfrMMOCyPHU6pz3MvB4MMb5p9z1XU sPWw== X-Gm-Message-State: AFqh2kq7IDBre9mC4axWOeB9genrRGfvxYcmFLlHBFChSX1Q5t47khu+ Aup1dLJL7wxJhQFNJSWDXUOW4A== X-Google-Smtp-Source: AMrXdXuO4A8xyx6+67tnt5vSccGnQfMst13iHm3i0RgTmN8zIeWyW0hP20D/R/sapznzyBbbSLIUpw== X-Received: by 2002:adf:f606:0:b0:24b:b74d:8012 with SMTP id t6-20020adff606000000b0024bb74d8012mr17321312wrp.18.1674388176056; Sun, 22 Jan 2023 03:49:36 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id m8-20020adfa3c8000000b00236545edc91sm1740479wrb.76.2023.01.22.03.49.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 03:49:35 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:49:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFC PATCH v2 05/31] Documentation: Add binding for kalray,coolidge-itgen Content-Language: en-US To: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan Cc: Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-6-ysionneau@kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230120141002.2442-6-ysionneau@kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas > > Add documentation for `kalray,coolidge-itgen` binding. > > Co-developed-by: Jules Maselbas > Signed-off-by: Jules Maselbas > Signed-off-by: Yann Sionneau The same comments apply plus more... > --- > > Notes: > V1 -> V2: new patch > > .../kalray,coolidge-itgen.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/kalray,coolidge-itgen.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/kalray,coolidge-itgen.yaml b/Documentation/devicetree/bindings/interrupt-controller/kalray,coolidge-itgen.yaml > new file mode 100644 > index 000000000000..47b503bff1d9 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/kalray,coolidge-itgen.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license. Checkpatch should complain about this - did you run it? This applies to all your other patches (both, run checkpatch and use proper license). > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/kalray,coolidge-itgen# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kalray Coolidge SoC Interrupt Generator (ITGEN) > + > +description: | > + The Interrupt Generator (ITGEN) is an interrupt controller block. > + It's purpose is to convert IRQ lines coming from SoC peripherals into writes > + on the AXI bus. The ITGEN intended purpose is to write into the APIC mailboxes. > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# > + > +properties: > + compatible: > + const: kalray,coolidge-itgen > + So why suddenly this patch has proper blank lines... Missing reg. > + "#interrupt-cells": > + const: 2 > + description: | > + - 1st cell is for the IRQ number > + - 2nd cell is for the trigger type as defined dt-bindings/interrupt-controller/irq.h > + > + interrupt-controller: true > + > + msi-parent: true > + > +required: > + - compatible > + - reg > + - "#interrupt-cells" > + - interrupt-controller > + - msi-parent > + > +examples: > + - | > + itgen: interrupt-controller@27000000 { > + compatible = "kalray,coolidge-itgen"; > + reg = <0 0x27000000 0 0x1104>; > + #interrupt-cells = <2>; > + interrupt-controller; > + msi-parent = <&apic_mailbox>; > + }; > + > +... Best regards, Krzysztof