From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <edumazet@google.com>, chia-yu.chang@nokia-bell-labs.com
Cc: linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org,
dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com,
kuba@kernel.org, stephen@networkplumber.org,
xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net,
andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net,
liuhangbin@gmail.com, shuah@kernel.org,
linux-kselftest@vger.kernel.org, ij@kernel.org,
ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com,
g.white@cablelabs.com, ingemar.s.johansson@ericsson.com,
mirja.kuehlewind@ericsson.com, cheshire@apple.com,
rs.ietf@gmx.at, Jason_Livingood@comcast.com,
vidhi_goel@apple.com
Subject: Re: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option
Date: Tue, 20 May 2025 15:37:40 +0200 [thread overview]
Message-ID: <c9465324-b2df-4507-8d17-7cdda55a60f0@redhat.com> (raw)
In-Reply-To: <CANn89iLkyC-MfGUTvcV=zr+LYKzMsyv1im1Oft6EAXYb2x0jGw@mail.gmail.com>
On 5/20/25 12:32 PM, Eric Dumazet wrote:
> On Tue, May 20, 2025 at 2:31 AM Paolo Abeni <pabeni@redhat.com> wrote:
>>
>> On 5/14/25 3:56 PM, chia-yu.chang@nokia-bell-labs.com wrote:
>>> This patch uses the existing 1-byte holes in the tcp_sock_write_txrx
>>> group for new u8 members, but adds a 4-byte hole in tcp_sock_write_rx
>>> group after the new u32 delivered_ecn_bytes[3] member. Therefore, the
>>> group size of tcp_sock_write_rx is increased from 96 to 112.
>>
>> Note that I'm still concerned by the relevant increase of the cacheline
>> groups size. My fear is that this change could defeat some/most of the
>> benefist from the cacheline reorg for all tcp users.
>>
>> Some additional feedback from Eric and/or Neal more than welcome!
>
> I have been trapped lately with production issues, sorry for the delay.
>
> I am still working on an idpf bug, hopefully done today.
>
> Then, I am OOO tomorrow, and can have a look at the whole series on Thursday.
Thanks Eric!
@Chia-Yu: please consider the above timeline before posting a new
revision. i.e. it would be likely wise to wait for the additional review.
/P
next prev parent reply other threads:[~2025-05-20 13:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-14 13:56 [PATCH v7 net-next 00/15] AccECN protocol patch series chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 01/15] tcp: reorganize SYN ECN code chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 02/15] tcp: fast path functions later chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 03/15] tcp: reorganize tcp_sock_write_txrx group for variables later chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 04/15] tcp: AccECN core chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 05/15] tcp: accecn: AccECN negotiation chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 06/15] tcp: accecn: add AccECN rx byte counters chia-yu.chang
2025-05-20 9:44 ` Paolo Abeni
2025-05-14 13:56 ` [PATCH v7 net-next 07/15] tcp: accecn: AccECN needs to know delivered bytes chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 08/15] tcp: sack option handling improvements chia-yu.chang
2025-05-20 9:34 ` Paolo Abeni
2025-05-14 13:56 ` [PATCH v7 net-next 09/15] tcp: accecn: AccECN option chia-yu.chang
2025-05-20 9:31 ` Paolo Abeni
2025-05-20 10:32 ` Eric Dumazet
2025-05-20 13:37 ` Paolo Abeni [this message]
2025-05-28 7:26 ` Chia-Yu Chang (Nokia)
2025-05-14 13:56 ` [PATCH v7 net-next 10/15] tcp: accecn: AccECN option send control chia-yu.chang
2025-05-20 9:49 ` Paolo Abeni
2025-05-14 13:56 ` [PATCH v7 net-next 11/15] tcp: accecn: AccECN option failure handling chia-yu.chang
2025-05-20 10:00 ` Paolo Abeni
2025-05-14 13:56 ` [PATCH v7 net-next 12/15] tcp: accecn: AccECN option ceb/cep heuristic chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 13/15] tcp: accecn: AccECN ACE field multi-wrap heuristic chia-yu.chang
2025-05-14 13:56 ` [PATCH v7 net-next 14/15] tcp: accecn: try to fit AccECN option with SACK chia-yu.chang
2025-05-20 10:03 ` Paolo Abeni
2025-05-23 17:50 ` Chia-Yu Chang (Nokia)
2025-05-14 13:56 ` [PATCH v7 net-next 15/15] tcp: try to avoid safer when ACKs are thinned chia-yu.chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9465324-b2df-4507-8d17-7cdda55a60f0@redhat.com \
--to=pabeni@redhat.com \
--cc=Jason_Livingood@comcast.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@fiberby.net \
--cc=bpf@vger.kernel.org \
--cc=cheshire@apple.com \
--cc=chia-yu.chang@nokia-bell-labs.com \
--cc=corbet@lwn.net \
--cc=dave.taht@gmail.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=g.white@cablelabs.com \
--cc=horms@kernel.org \
--cc=ij@kernel.org \
--cc=ingemar.s.johansson@ericsson.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=koen.de_schepper@nokia-bell-labs.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=mirja.kuehlewind@ericsson.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=rs.ietf@gmx.at \
--cc=shuah@kernel.org \
--cc=stephen@networkplumber.org \
--cc=vidhi_goel@apple.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).