From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6351242D9A for ; Tue, 20 May 2025 13:37:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747748271; cv=none; b=JLKGobTSlW5JNCGSl9TQcym7pe+Y+9qHj1IQuMLzbS+m1KCF3CMEZrOGYdxih/bQF19BHtutUcvr8qb+SfymRbgvxd7eIAjRqkw/fii5kB2iIjIFD0inzgEYVijQ/QU3pBQVhZZ83h2DusmX3BG49OysvbCQi+dFLnSqTwyz6To= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1747748271; c=relaxed/simple; bh=U5YZUOHnFba3YEEPRb4B8MFish1XcE6mlQd58Sc0Ulo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Knb4TA5PaVVLJB2zrO0Q6ulTRoWwkOzBnXGoy4VwnW0XY0GKm3emrK3MA1lc7u5JszydHFcSB4lXvqaeqWmvweTzLJ0Gxgey19AifIRlUlj1X9bBq7WjglKQAx/n1BJQW9wPyRDp0q4MnWZYo2HUPXN/PF6yHFcLGvM7mJjso9M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ddktNoAq; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ddktNoAq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747748268; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EMsyQ7VNnN2qO1o186LSTMN+Ccv8Zs0ud4b/iPJ/c0Y=; b=ddktNoAqoxnCA7ZVQCm+NgnfJHx9H82vcdyAbyij9F4XxE9ok7IHRnJB6aBfrucca0ak6e 9DZ0rRan/pfirb9CiyTvsgiOJdrm9j1QxpiA38G0r6pI+oBvlZvUzI4L5A1t7C5crRbycW 3T+2tTClPHLu7A4tsfzOjmKwU6TV+X4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-589-GBGwyQ85N_mezfE-tkDcvQ-1; Tue, 20 May 2025 09:37:45 -0400 X-MC-Unique: GBGwyQ85N_mezfE-tkDcvQ-1 X-Mimecast-MFC-AGG-ID: GBGwyQ85N_mezfE-tkDcvQ_1747748264 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a371fb826cso1025974f8f.1 for ; Tue, 20 May 2025 06:37:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747748264; x=1748353064; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EMsyQ7VNnN2qO1o186LSTMN+Ccv8Zs0ud4b/iPJ/c0Y=; b=lh24CYJp5PpcVgebgAuvaIzgkIq9vweeqzwfLd3UKODIkgYuony3OQ32TxWcBtgfsC 5Nw4Xy55wumMNG1DUWsnJS2gcx2Zoe47d+4zkmcvV809i46JiIXdaU4vbYTYNcIAzXJX qFQ3+rI1if2yK1/oAUBMhOcah6jKNqly/L03qNZbfQ33mOURIHY8oSKGQuR5v9bAKqOe om7aOFSZyixtiIQ50770qidwnmVRPmJfXvQrk0AwyPkbChz95kFRfJ0ChiffyxUqTpaQ NwdWw9f1zmbF1/a3oipQgOwOILw30pqsWhDZutSv0QiuN1Qwsk1HTgp85tiTT2zm1EaD 9QCg== X-Gm-Message-State: AOJu0YyhVbJ/fp4g2HdPMrVcCGTshbvWkH7lCYrBT0t5ABy6bDVUB106 q6GOCioceDD0/VyQ2dkP8b7qkub0tfxcvUq+DLKeczeMXe+ahibyfkkj/CShVnJ4E1svOoesqtb X43V0cT7mVbt7yVjneqPgtfXFnsWy61W+5CbTM0HvW5cf2KCqT7eC5k7y3WUfxA== X-Gm-Gg: ASbGncteSWIdbnaHOaHLPW0/wD3WALmTjSn3WHTy1pDj4HGAWqJBE6+M8OKKa99o/+0 L2CXmjDK6g21beQmLk0LJx4VNX8Dfry6wAnk0eUVuXgWgz47Nb38lO+Y+iuk30snMbeNvninnCX a+C65AdK+tUurNtgExJ/cc9vdbdflOxwZNuIHj1ZoB78WGErPHin59lwFWy8DeuyAE9roP8AuyB 7y8lRylSnh+HoHROj1ga8FeP+eJv0akBGFhq4pyCvMnvmI/Is+DfgPFIeOF1S21AI3u5tWt0O+A cS98fH16KDzQ7PfvKi0= X-Received: by 2002:a5d:5f8d:0:b0:3a0:8492:e493 with SMTP id ffacd0b85a97d-3a35c834f91mr16985994f8f.6.1747748264368; Tue, 20 May 2025 06:37:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2IgQR6pfl4f9JZX+mTcQQJIcZJQqSQkpv9zrll3ynmvnMB9+rl/8mcTBCpK5VIAeoxVyW1Q== X-Received: by 2002:a5d:5f8d:0:b0:3a0:8492:e493 with SMTP id ffacd0b85a97d-3a35c834f91mr16985962f8f.6.1747748264000; Tue, 20 May 2025 06:37:44 -0700 (PDT) Received: from ?IPV6:2a0d:3344:244f:5710::f39? ([2a0d:3344:244f:5710::f39]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-447f23bfdd9sm31041385e9.18.2025.05.20.06.37.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 May 2025 06:37:43 -0700 (PDT) Message-ID: Date: Tue, 20 May 2025 15:37:40 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 net-next 09/15] tcp: accecn: AccECN option To: Eric Dumazet , chia-yu.chang@nokia-bell-labs.com Cc: linux-doc@vger.kernel.org, corbet@lwn.net, horms@kernel.org, dsahern@kernel.org, kuniyu@amazon.com, bpf@vger.kernel.org, netdev@vger.kernel.org, dave.taht@gmail.com, jhs@mojatatu.com, kuba@kernel.org, stephen@networkplumber.org, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, andrew+netdev@lunn.ch, donald.hunter@gmail.com, ast@fiberby.net, liuhangbin@gmail.com, shuah@kernel.org, linux-kselftest@vger.kernel.org, ij@kernel.org, ncardwell@google.com, koen.de_schepper@nokia-bell-labs.com, g.white@cablelabs.com, ingemar.s.johansson@ericsson.com, mirja.kuehlewind@ericsson.com, cheshire@apple.com, rs.ietf@gmx.at, Jason_Livingood@comcast.com, vidhi_goel@apple.com References: <20250514135642.11203-1-chia-yu.chang@nokia-bell-labs.com> <20250514135642.11203-10-chia-yu.chang@nokia-bell-labs.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/20/25 12:32 PM, Eric Dumazet wrote: > On Tue, May 20, 2025 at 2:31 AM Paolo Abeni wrote: >> >> On 5/14/25 3:56 PM, chia-yu.chang@nokia-bell-labs.com wrote: >>> This patch uses the existing 1-byte holes in the tcp_sock_write_txrx >>> group for new u8 members, but adds a 4-byte hole in tcp_sock_write_rx >>> group after the new u32 delivered_ecn_bytes[3] member. Therefore, the >>> group size of tcp_sock_write_rx is increased from 96 to 112. >> >> Note that I'm still concerned by the relevant increase of the cacheline >> groups size. My fear is that this change could defeat some/most of the >> benefist from the cacheline reorg for all tcp users. >> >> Some additional feedback from Eric and/or Neal more than welcome! > > I have been trapped lately with production issues, sorry for the delay. > > I am still working on an idpf bug, hopefully done today. > > Then, I am OOO tomorrow, and can have a look at the whole series on Thursday. Thanks Eric! @Chia-Yu: please consider the above timeline before posting a new revision. i.e. it would be likely wise to wait for the additional review. /P