From: Guenter Roeck <linux@roeck-us.net>
To: Krzysztof Kozlowski <krzk@kernel.org>, wenswang@yeah.net
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
jdelvare@suse.com, corbet@lwn.net, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: hwmon: Add MPS mp2869,mp29608,mp29612 and mp29816 series
Date: Fri, 25 Jul 2025 02:38:52 -0700 [thread overview]
Message-ID: <cccad21e-7599-4643-9f39-94faf482041d@roeck-us.net> (raw)
In-Reply-To: <20250725-glistening-hamster-of-perspective-1dd0dc@kuoka>
On 7/25/25 00:21, Krzysztof Kozlowski wrote:
> On Thu, Jul 24, 2025 at 05:13:03PM +0800, wenswang@yeah.net wrote:
>> From: Wensheng Wang <wenswang@yeah.net>
>>
>> Add support for MPS mp2869/mp2869a,mp29608/mp29608a,mp29612/mp29612a and
>> mp29816/mp29816a/mp29816b/mp29816c controller
>>
>> Acked-by: Rob Herring (Arm) <robh@kernel.org>
>> Signed-off-by: Wensheng Wang <wenswang@yeah.net>
>> ---
>> V3 -> V4:
>> 1. split patches for MP2869,mp29608,mp29612,mp29816,mp29502
>> 2. add description for vender specific registers
>>
>> V2 -> V3:
>> merge patches for MP2869,mp29608,mp29612,mp29816,mp29502
>
> No one asked you to merge drivers. Look where comments appear.
>
> So again: merge the bindings, it's a churn to add one trivial device
> after another.
>
I think that is what they did in this version of the series. There are
two drivers for the various chips, one of them supporting multiple chips.
That makes sense if the supported chips are similar (and afaics that
is the case).
Guenter
next prev parent reply other threads:[~2025-07-25 9:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 9:10 [PATCH v4 0/4] hwmon: Add support for MPS mp2869,mp29608,mp29612,mp29816,mp29502 chip wenswang
2025-07-24 9:13 ` [PATCH v4 1/4] dt-bindings: hwmon: Add MPS mp2869,mp29608,mp29612 and mp29816 series wenswang
2025-07-24 9:13 ` [PATCH v4 2/4] hwmon: add MP2869,MP29608,MP29612 and MP29816 series driver wenswang
2025-07-25 19:44 ` Guenter Roeck
2025-07-24 9:13 ` [PATCH v4 3/4] dt-bindings: hwmon: Add MPS mp29502 wenswang
2025-07-25 7:19 ` Krzysztof Kozlowski
2025-07-24 9:13 ` [PATCH v4 4/4] hwmon: add MP29502 driver wenswang
2025-07-25 7:21 ` [PATCH v4 1/4] dt-bindings: hwmon: Add MPS mp2869,mp29608,mp29612 and mp29816 series Krzysztof Kozlowski
2025-07-25 9:38 ` Guenter Roeck [this message]
2025-07-25 9:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cccad21e-7599-4643-9f39-94faf482041d@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wenswang@yeah.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox