From: "Arnd Bergmann" <arnd@arndb.de>
To: "Linus Walleij" <linus.walleij@linaro.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>
Cc: "Wolfram Sang" <wsa+renesas@sang-engineering.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>,
"Kent Gibson" <warthog618@gmail.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH v9 1/1] gpio: add sloppy logic analyzer using polling
Date: Thu, 13 Jun 2024 10:50:25 +0200 [thread overview]
Message-ID: <ce1d8150-c595-44d5-b19a-040920481709@app.fastmail.com> (raw)
In-Reply-To: <CACRpkda==5S75Bw6F3ZLUmf7kwgi_JkByiizR=m-61nrMDWuvQ@mail.gmail.com>
On Thu, Jun 13, 2024, at 10:27, Linus Walleij wrote:
> On Thu, Jun 13, 2024 at 10:17 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
>
>> On second thought
>> though: are you sure drivers/gpio/ is the right place for it?
>
> Actually that is something I requested.
>
> I think it fits in drivers/gpio as it is such a clear cut usage of GPIO
> lines, and it doesn't really fit into any other subsystem.
>
>> May I suggest moving it over to drivers/misc/?
>
> Misc is a bit...
> messy. I remember Arnd being very sceptical about putting stuff there
> rather than creating new subsystems, so since I've tried to avoid it,
> albeit recently more and more stuff gets merged there again :/
Right, and that is mostly to avoid having code in there because
there is no other place for it. Some parts of drivers/misc should
have been a separate subsystem, some should have use an existing
subsystem, and other parts should have never been merged.
The parts of drivers/misc that make the most sense to me are
those that expose a one-of-a-kind piece of hardware as a
single character device.
This one would probably fit into drivers/misc/ better than
some other drivers we have in there, but leaving it in
drivers/gpio/ also seems fine.
I could also imagine the functionality being exposed
through drivers/iio/ in a way that is similar to an
adc, but I don't know if that would work in practice or
how much of a rewrite that would be.
Arnd
next prev parent reply other threads:[~2024-06-13 8:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 11:26 [PATCH v9 0/1] gpio: add simple logic analyzer using polling Wolfram Sang
2024-06-10 11:26 ` [PATCH v9 1/1] gpio: add sloppy " Wolfram Sang
2024-06-10 14:30 ` Andy Shevchenko
2024-06-12 10:03 ` Wolfram Sang
2024-06-11 20:03 ` Bartosz Golaszewski
2024-06-12 16:03 ` Wolfram Sang
2024-06-13 8:17 ` Bartosz Golaszewski
2024-06-13 8:27 ` Linus Walleij
2024-06-13 8:50 ` Arnd Bergmann [this message]
2024-06-13 9:43 ` Bartosz Golaszewski
2024-06-13 11:48 ` Wolfram Sang
2024-06-13 13:47 ` Linus Walleij
2024-06-13 13:51 ` Bartosz Golaszewski
2024-06-13 14:20 ` Arnd Bergmann
2024-06-14 10:03 ` Wolfram Sang
2024-06-14 11:58 ` Arnd Bergmann
2024-06-14 12:14 ` Linus Walleij
2024-06-16 16:04 ` Wolfram Sang
2024-06-18 9:23 ` Wolfram Sang
2024-06-18 12:50 ` Bartosz Golaszewski
2024-06-18 16:09 ` Wolfram Sang
2024-06-18 18:58 ` Geert Uytterhoeven
2024-06-18 19:46 ` Bartosz Golaszewski
2024-06-13 15:04 ` Geert Uytterhoeven
2024-06-13 16:33 ` Wolfram Sang
2024-06-13 8:30 ` Linus Walleij
2024-06-13 11:45 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1d8150-c595-44d5-b19a-040920481709@app.fastmail.com \
--to=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=corbet@lwn.net \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=warthog618@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox