[PATCH 0/7] zfcp: cleanups and small changes for 5.9

[PATCH 0/7] zfcp: cleanups and small changes for 5.9

[Benjamin Block]

Hello Martin, James, Jonathan,

here are some cleanups and small changes for zfcp I'd like to include in
5.9 if possible.

One of the changes touches documentation in `Documentation/scsi/`, so I
put Jonathan on To, hope that was correct. I hope you can still pull
this all in one go to minimize work. IBM did retire some old URLs and
content from our public website, so we have to clean that up in the
documentation so there are not dead links. I changed these in the hopes
we can minimize documentation churn going forward, just to replace URLs.

The other changes are mostly small cleanups for our driver that make at
least parts more sane than they've been.

Most of these have been in our CI for quite a while now - shame on me
for delaying sending them upstream so long -, so I am rather confident
that they don't break anything for us.

As always, feedback and reviews are appreciated :-)

Benjamin Block (2):
  scsi: docs: update outdated link to IBM developerworks
  scsi: docs: remove invalid link and update text for zfcp kernel config

George Spelvin (1):
  zfcp: use prandom_u32_max() for backoff

Julian Wiedmann (4):
  zfcp: fix an outdated comment for zfcp_qdio_send()
  zfcp: clean up zfcp_erp_action_ready()
  zfcp: replace open-coded list move
  zfcp: avoid benign overflow of the Request Queue's free-level

 Documentation/scsi/scsi-parameters.rst |  2 +-
 drivers/s390/scsi/zfcp_ccw.c           |  7 +++----
 drivers/s390/scsi/zfcp_erp.c           |  2 +-
 drivers/s390/scsi/zfcp_fc.c            |  2 +-
 drivers/s390/scsi/zfcp_qdio.c          |  7 +++++--
 drivers/scsi/Kconfig                   | 15 ++++++++++-----
 6 files changed, 21 insertions(+), 14 deletions(-)

-- 
2.26.2

[PATCH 3/7] scsi: docs: update outdated link to IBM developerworks

[Benjamin Block]

IBM decided to retire a lot of the content that was previously hosted on
"developerworks", and so some of the links we've used for documentation
are now dead or redirect to some general landing page with no
correlation to what the links were meant to provide.

The s390-tools package is meanwhile also hosted on github, so we can
link to the script directly instead of to the archive.

Reviewed-by: Julian Wiedmann <jwi@linux.ibm.com>
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
---
 Documentation/scsi/scsi-parameters.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/scsi/scsi-parameters.rst b/Documentation/scsi/scsi-parameters.rst
index 9aba897c97ac..e5f68b431f5c 100644
--- a/Documentation/scsi/scsi-parameters.rst
+++ b/Documentation/scsi/scsi-parameters.rst
@@ -94,7 +94,7 @@ parameters may be changed at runtime by the command
 			(/proc/sys/dev/scsi/logging_level).
 			There is also a nice 'scsi_logging_level' script in the
 			S390-tools package, available for download at
-			http://www-128.ibm.com/developerworks/linux/linux390/s390-tools-1.5.4.html
+			https://github.com/ibm-s390-tools/s390-tools/blob/master/scripts/scsi_logging_level
 
 	scsi_mod.scan=	[SCSI] sync (default) scans SCSI busses as they are
 			discovered.  async scans them in kernel threads,
-- 
2.26.2

Re: [PATCH 0/7] zfcp: cleanups and small changes for 5.9

[Martin K. Petersen]

On Fri, 3 Jul 2020 15:19:56 +0200, Benjamin Block wrote:

> here are some cleanups and small changes for zfcp I'd like to include in
> 5.9 if possible.
> 
> One of the changes touches documentation in `Documentation/scsi/`, so I
> put Jonathan on To, hope that was correct. I hope you can still pull
> this all in one go to minimize work. IBM did retire some old URLs and
> content from our public website, so we have to clean that up in the
> documentation so there are not dead links. I changed these in the hopes
> we can minimize documentation churn going forward, just to replace URLs.
> 
> [...]

Applied to 5.9/scsi-queue, thanks!

[1/7] scsi: zfcp: Use prandom_u32_max() for backoff
      https://git.kernel.org/mkp/scsi/c/0cd0e57ec858
[2/7] scsi: zfcp: Fix an outdated comment for zfcp_qdio_send()
      https://git.kernel.org/mkp/scsi/c/459ad085d87b
[3/7] scsi: docs: Update outdated link to IBM developerworks
      https://git.kernel.org/mkp/scsi/c/b9789bfbfe9d
[4/7] scsi: docs: Remove invalid link and update text for zfcp kernel config
      https://git.kernel.org/mkp/scsi/c/c06de6e28c9e
[5/7] scsi: zfcp: Clean up zfcp_erp_action_ready()
      https://git.kernel.org/mkp/scsi/c/b43cdb5ac856
[6/7] scsi: zfcp: Replace open-coded list move
      https://git.kernel.org/mkp/scsi/c/6bcb7c171a0c
[7/7] scsi: zfcp: Avoid benign overflow of the Request Queue's free-level
      https://git.kernel.org/mkp/scsi/c/c3bfffa5ec69

-- 
Martin K. Petersen	Oracle Linux Engineering

Re: [PATCH 0/7] zfcp: cleanups and small changes for 5.9

[Benjamin Block]

On Wed, Jul 08, 2020 at 02:06:45AM -0400, Martin K. Petersen wrote:
> On Fri, 3 Jul 2020 15:19:56 +0200, Benjamin Block wrote:
> 
> > here are some cleanups and small changes for zfcp I'd like to include in
> > 5.9 if possible.
> > 
> > One of the changes touches documentation in `Documentation/scsi/`, so I
> > put Jonathan on To, hope that was correct. I hope you can still pull
> > this all in one go to minimize work. IBM did retire some old URLs and
> > content from our public website, so we have to clean that up in the
> > documentation so there are not dead links. I changed these in the hopes
> > we can minimize documentation churn going forward, just to replace URLs.
> > 
> > [...]
> 
> Applied to 5.9/scsi-queue, thanks!
> 
> [1/7] scsi: zfcp: Use prandom_u32_max() for backoff
>       https://git.kernel.org/mkp/scsi/c/0cd0e57ec858
> [2/7] scsi: zfcp: Fix an outdated comment for zfcp_qdio_send()
>       https://git.kernel.org/mkp/scsi/c/459ad085d87b
> [3/7] scsi: docs: Update outdated link to IBM developerworks
>       https://git.kernel.org/mkp/scsi/c/b9789bfbfe9d
> [4/7] scsi: docs: Remove invalid link and update text for zfcp kernel config
>       https://git.kernel.org/mkp/scsi/c/c06de6e28c9e
> [5/7] scsi: zfcp: Clean up zfcp_erp_action_ready()
>       https://git.kernel.org/mkp/scsi/c/b43cdb5ac856
> [6/7] scsi: zfcp: Replace open-coded list move
>       https://git.kernel.org/mkp/scsi/c/6bcb7c171a0c
> [7/7] scsi: zfcp: Avoid benign overflow of the Request Queue's free-level
>       https://git.kernel.org/mkp/scsi/c/c3bfffa5ec69
> 

Thanks Martin!

-- 
Best Regards, Benjamin Block  / Linux on IBM Z Kernel Development / IBM Systems
IBM Deutschland Research & Development GmbH    /    https://www.ibm.com/privacy
Vorsitz. AufsR.: Gregor Pillen         /        Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen / Registergericht: AmtsG Stuttgart, HRB 243294