From: Fan Gong <gongfan1@huawei.com>
To: Fan Gong <gongfan1@huawei.com>, Wu Di <wudi234@huawei.com>,
Teng Peisen <tengpeisen@huawei.com>, <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Ioana Ciornei <ioana.ciornei@nxp.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Mohsin Bashir <mohsin.bashr@gmail.com>,
Dimitri Daskalakis <dimitri.daskalakis1@gmail.com>,
Harshitha Ramamurthy <hramamurthy@google.com>,
Larysa Zaremba <larysa.zaremba@intel.com>,
"Vadim Fedorenko" <vadim.fedorenko@linux.dev>
Cc: <linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
Zhou Shuai <zhoushuai28@huawei.com>, Wu Like <wulike1@huawei.com>
Subject: [PATCH net-next v04 0/4] net: hinic3: Bugfix for later patch-set.
Date: Tue, 17 Nov 2026 20:08:30 +0800 [thread overview]
Message-ID: <cover.1794917917.git.gongfan1@huawei.com> (raw)
These issues were discovered by LLM Gemini-4-Argon and Claude-Opus-5-5.
At the same time, LLM recommended submitting an independent patch.
These issues were not actually triggered. Based on theoretical analysis
and consideration of actual risks, this patch is used to fix the issues.
Testing:
This patch-set has been tested on hinic3 hardware.
v04:
* Fold a short ring refill into the hinic3_rx_poll() repoll decision: with
no WQE posted the device raises no interrupt, so returning nr_pkts left
the queue dead until the interface is reset.(AI Review)
* Keep csum_errors in rx_errors, and describe the u64_stats reader change
as the cleanup it is: the driver depends on 64BIT, so the retry never
happens. Drop the Fixes: tag.(AI Review)
* Rewrite "fix some checkpatchs.": name what is wrapped and renamed, and
note that the patch has no functional effect.(AI Review)
* Reword "Ensure that the value of max_qps is not changed": max_qps sizes
the software arrays, the hardware capacity is nic_io->max_qps, and the
change is a design change rather than a fix (no Fixes: tag).(AI Review)
V03: https://lore.kernel.org/all/cover.1794467919.git.gongfan1@huawei.com/
* Cleanup checkpatchs in file hinic3_netdev_ops.c.(AI Review)
* nic_svc_cap->max_sqs is already in the range [1, 256].(AI Review)
V02: https://lore.kernel.org/all/cover.1794371175.git.gongfan1@huawei.com/
* Rewrite the commit message and provide an explanation for each
patch.(AI Review)
* Split checkpatchs in to a separate patch.(AI Review)
* Fix the failure of napi_alloc_skb() in recv_one_pkt().(AI Review)
* READ_ONCE()/WRITE_ONCE() only stop the compiler from tearing or caching
the access. They don't order anything against the work item, and they
can't stop it from running. So, remove READ_ONCE() and WRITE_ONCE() on
nic_dev->adaptive_rx_coal.(AI Review)
V01: https://lore.kernel.org/netdev/cover.1793946318.git.gongfan1@huawei.com/
Fan Gong (4):
hinic3: Fix the RX stalls in hinic3_rx_poll()
hinic3: Read the queue counters once per u64_stats retry loop
hinic3: Wrap long lines and rename q_params
hinic3: Keep max_qps at the hardware maximum when RSS setup fails
.../huawei/hinic3/hinic3_netdev_ops.c | 77 ++++++++-----------
.../net/ethernet/huawei/hinic3/hinic3_rss.c | 7 +-
.../net/ethernet/huawei/hinic3/hinic3_rx.c | 22 ++++--
3 files changed, 53 insertions(+), 53 deletions(-)
base-commit: 73022f605c447f31610b94ed4a983d2b4bf2c721
--
2.43.0
next reply other threads:[~2026-11-17 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:08 Fan Gong [this message]
2026-11-17 12:08 ` [PATCH net-next v04 1/4] hinic3: Fix the RX stalls in hinic3_rx_poll() Fan Gong
2026-11-17 12:08 ` [PATCH net-next v04 2/4] hinic3: Read the queue counters once per u64_stats retry loop Fan Gong
2026-11-17 12:08 ` [PATCH net-next v04 3/4] hinic3: Wrap long lines and rename q_params Fan Gong
2026-11-17 12:08 ` [PATCH net-next v04 4/4] hinic3: Keep max_qps at the hardware maximum when RSS setup fails Fan Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1794917917.git.gongfan1@huawei.com \
--to=gongfan1@huawei.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dimitri.daskalakis1@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=hramamurthy@google.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tengpeisen@huawei.com \
--cc=vadim.fedorenko@linux.dev \
--cc=wudi234@huawei.com \
--cc=wulike1@huawei.com \
--cc=zhoushuai28@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox