From: Andrew Lunn <andrew@lunn.ch>
To: Danielle Ratson <danieller@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, corbet@lwn.net,
linux@armlinux.org.uk, sdf@google.com, kory.maincent@bootlin.com,
maxime.chevallier@bootlin.com, vladimir.oltean@nxp.com,
przemyslaw.kitszel@intel.com, ahmed.zaki@intel.com,
richardcochran@gmail.com, shayagr@amazon.com,
paul.greenwalt@intel.com, jiri@resnulli.us,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
mlxsw@nvidia.com, idosch@nvidia.com, petrm@nvidia.com
Subject: Re: [PATCH net-next v7 1/9] ethtool: Add ethtool operation to write to a transceiver module EEPROM
Date: Mon, 24 Jun 2024 21:01:22 +0200 [thread overview]
Message-ID: <d02e3393-bd0f-419c-83be-f98a4e794b59@lunn.ch> (raw)
In-Reply-To: <20240624175201.130522-2-danieller@nvidia.com>
On Mon, Jun 24, 2024 at 08:51:51PM +0300, Danielle Ratson wrote:
> From: Ido Schimmel <idosch@nvidia.com>
>
> Ethtool can already retrieve information from a transceiver module
> EEPROM by invoking the ethtool_ops::get_module_eeprom_by_page operation.
> Add a corresponding operation that allows ethtool to write to a
> transceiver module EEPROM.
>
> The new write operation is purely an in-kernel API and is not exposed to
> user space.
>
> The purpose of this operation is not to enable arbitrary read / write
> access, but to allow the kernel to write to specific addresses as part
> of transceiver module firmware flashing. In the future, more
> functionality can be implemented on top of these read / write
> operations.
>
> Adjust the comments of the 'ethtool_module_eeprom' structure as it is
> no longer used only for read access.
>
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> Signed-off-by: Danielle Ratson <danieller@nvidia.com>
> Reviewed-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2024-06-24 19:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 17:51 [PATCH net-next v7 0/9] Add ability to flash modules' firmware Danielle Ratson
2024-06-24 17:51 ` [PATCH net-next v7 1/9] ethtool: Add ethtool operation to write to a transceiver module EEPROM Danielle Ratson
2024-06-24 19:01 ` Andrew Lunn [this message]
2024-06-24 17:51 ` [PATCH net-next v7 2/9] mlxsw: Implement " Danielle Ratson
2024-06-24 19:09 ` Andrew Lunn
2024-06-24 17:51 ` [PATCH net-next v7 3/9] ethtool: Add an interface for flashing transceiver modules' firmware Danielle Ratson
2024-06-24 19:23 ` Andrew Lunn
2024-06-24 17:51 ` [PATCH net-next v7 4/9] ethtool: Add flashing transceiver modules' firmware notifications ability Danielle Ratson
2024-06-24 19:27 ` Andrew Lunn
2024-06-24 17:51 ` [PATCH net-next v7 5/9] ethtool: Veto some operations during firmware flashing process Danielle Ratson
2024-06-24 19:31 ` Andrew Lunn
2024-06-24 17:51 ` [PATCH net-next v7 6/9] net: sfp: Add more extended compliance codes Danielle Ratson
2024-06-24 19:31 ` Andrew Lunn
2024-06-24 17:51 ` [PATCH net-next v7 7/9] ethtool: cmis_cdb: Add a layer for supporting CDB commands Danielle Ratson
2024-06-24 19:50 ` Andrew Lunn
2024-06-26 6:14 ` Danielle Ratson
2024-06-26 11:52 ` Danielle Ratson
2024-06-26 13:40 ` Andrew Lunn
2024-06-26 17:26 ` Danielle Ratson
2024-06-26 17:42 ` Andrew Lunn
2024-06-27 13:12 ` Danielle Ratson
2024-06-24 17:51 ` [PATCH net-next v7 8/9] ethtool: cmis_fw_update: add a layer for supporting firmware update using CDB Danielle Ratson
2024-06-24 19:57 ` Andrew Lunn
2024-06-25 6:09 ` Danielle Ratson
2024-06-24 17:51 ` [PATCH net-next v7 9/9] ethtool: Add ability to flash transceiver modules' firmware Danielle Ratson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d02e3393-bd0f-419c-83be-f98a4e794b59@lunn.ch \
--to=andrew@lunn.ch \
--cc=ahmed.zaki@intel.com \
--cc=corbet@lwn.net \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sdf@google.com \
--cc=shayagr@amazon.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).