From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E1962494ED; Tue, 10 Jun 2025 18:52:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749581541; cv=none; b=lq0ikA85+tyCceUMgZc3JJcd3plvaQPwyW1Li2bnrXbwnDDN0oVKT08wAqEki7eWSCjCkMB5pkm3G4cKrdzgqBNyJ7dpAKkr1GG0W6x5oyUhQV7f6bWMBjuzOWxQsecYqahtJWLCik0WtGGJETS9JgzwA4ekjFaXtZyakLxjByQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749581541; c=relaxed/simple; bh=D+SLbgwqbHoCj3oO6CuUATPS7+/ovg9hSc1l4QTqaYI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UUdSZlgNbakGE74uAxvzuEBDUmd8u+DiaE4TIX1z42j7krFDM1NSRH1CnI3pVZclSI+LflsyAQvtEbpqYPx9nEisB4I6DsQG7d01dzNsSrdDGn65scZA+qzhHSZ4DYXSiMyYAITl8UJzudglWI58lx6C3u77iH/8905OI3WU7lk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vA7GkvRD; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vA7GkvRD" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B038CC4CEED; Tue, 10 Jun 2025 18:52:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1749581540; bh=D+SLbgwqbHoCj3oO6CuUATPS7+/ovg9hSc1l4QTqaYI=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vA7GkvRDeNEkKZ0x5bgHWPa6SW5jph1vEukaxaD/VWMWQ9v8MOTFfBFJILKH7RQ2j 4Eskbu/gmfN+5YecJCn4f/6ZRenm+JRYNbTqWwUHVMt4VWXMzy4Frl+Ddj3M1locN6 myC1gTAqyBgcCWfgpz6nrOERV+fDUBk9T0SOgMq9iNJ+32XL33mxFzeAOABtmM7nMk AlKb713enWkTQZ8GU0RYGLpbOWIeZxA+Egofn5N/aUtwWZQ1b2OQ8UFZWT+NUp1usr dGZJxlzGmP8OewvVNvjXQv/BqvB6KjJA0foVAWqZPJW/2HYRxCqMFfcIPMDPA4JzRW OBD4PW275/DCA== Message-ID: Date: Tue, 10 Jun 2025 20:52:13 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 2/5] i2c: piix4: Depends on X86 To: Geert Uytterhoeven Cc: Mario Limonciello , Huacai Chen , Borislav Petkov , Jean Delvare , Andi Shyti , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Jonathan Corbet , Mario Limonciello , Yazen Ghannam , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H . Peter Anvin" , Shyam Sundar S K , "open list:DOCUMENTATION" , open list , "open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC" , "open list:AMD PMC DRIVER" , Ingo Molnar , linux-mips@vger.kernel.org, loongarch@lists.linux.dev References: <20250422234830.2840784-1-superm1@kernel.org> <20250422234830.2840784-3-superm1@kernel.org> <24febda9-6360-459f-82d3-6fba9ed9be83@kernel.org> <30a7f1a6-1e04-4fc5-9bea-e2b5956b28b7@kernel.org> <1e06c620-8f8e-4ddf-8356-0782bccd63a2@kernel.org> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Geert, On 10-Jun-25 18:59, Geert Uytterhoeven wrote: > Hi Hans, > > On Tue, 10 Jun 2025 at 16:55, Hans de Goede wrote: >> On 10-Jun-25 16:53, Hans de Goede wrote: >>> On 10-Jun-25 16:12, Mario Limonciello wrote: >>>> On 6/10/2025 2:24 AM, Huacai Chen wrote: >>>>> On Tue, Jun 10, 2025 at 5:16 PM Geert Uytterhoeven wrote: >>>>>> On Wed, 23 Apr 2025 at 01:49, Mario Limonciello wrote: >>>>>>> From: Mario Limonciello >>>>>>> >>>>>>> PIIX4 and compatible controllers are only for X86. As some headers are >>>>>>> being moved into x86 specific headers PIIX4 won't compile on non-x86. >>>>>>> >>>>>>> Suggested-by: Ingo Molnar >>>>>>> Signed-off-by: Mario Limonciello >>>>>> >>>>>> Thanks for your patch, which is now commit 7e173eb82ae97175 >>>>>> ("i2c: piix4: Make CONFIG_I2C_PIIX4 dependent on CONFIG_X86") >>>>>> in v6.16-rc1. >>>>>> >>>>>>> --- a/drivers/i2c/busses/Kconfig >>>>>>> +++ b/drivers/i2c/busses/Kconfig >>>>>>> @@ -200,7 +200,7 @@ config I2C_ISMT >>>>>>> >>>>>>> config I2C_PIIX4 >>>>>>> tristate "Intel PIIX4 and compatible (ATI/AMD/Serverworks/Broadcom/SMSC)" >>>>>>> - depends on PCI && HAS_IOPORT >>>>>>> + depends on PCI && HAS_IOPORT && X86 >>>>>> >>>>>> Are you sure this south-bridge is not used on non-x86 platforms? >>>>>> It is enabled in several non-x86 defconfigs: >>>>>> >>>>>> arch/loongarch/configs/loongson3_defconfig:CONFIG_I2C_PIIX4=y >>>>>> arch/mips/configs/ip27_defconfig:CONFIG_I2C_PIIX4=m >>>>>> arch/mips/configs/loongson2k_defconfig:CONFIG_I2C_PIIX4=y >>>>>> arch/mips/configs/loongson3_defconfig:CONFIG_I2C_PIIX4=y >>>>>> >>>>>> The loongarch and loongson entries are probably bogus, but I wouldn't >>>>>> be surprised if the SGI Onyx and Origin do use Intel south-bridges. >>>>> Loongson can use AMD SB700/SB800 south bridges, which have I2C_PIIX4. >>>> >>>> Well we could revert this patch, but it's going to be a compile failure because of 624b0d5696a89b138408d385899dd35372db324b and other patches that go on top of that. >>>> >>>> My current leaning is we make a dummy fch.h header for these archs with #defines for 0. >>> >>> Move "fch.h" to include/linux/platform/x86/ so that it is available on all arches >>> and if necessary ifdef out anything x86 specific in the C-code referencing it ? >> >> Correction that should be include/linux/platform_data/x86/ > > Is that a good location? It is a location typically used for x86 headers which we want to be available when not building on x86 too. > It is not x86-specific, and I see no platform_data (struct) definitions in > arch/x86/include/asm/amd/fch.h? If it is not x86 specific then maybe just include/linux/amd_fch.h ? Anyways I don't really give much about the exact name, the essence of my suggestion is that we can fix this by moving fch.h to some place (and maybe a new name) under include/linux so that the header is also available when not building for x86. Regards, Hans > > Gr{oetje,eeting}s, > > Geert >