From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 302311E9B00 for ; Thu, 30 Jan 2025 15:29:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738250981; cv=none; b=ZnH/Csc73zlRPHLh8rqOWpBM6O4Z4bsavpS2Oea6luNjAIcxVrM0z4zcwKPcxcsmtZ25eJTYvvN3vflpdfDHSPpRYZWEtZAyoV4zPm7cooJU1oQpZ20QPLUGjqpvDi/rf3qMwQY68V8HuptGhJ9VdyPx2NLv9z4hKK32QMHKKVg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738250981; c=relaxed/simple; bh=V7LkcqU5OWu/TKqj2CpwkS4v7SWhA++LOpUbTeWYNhU=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=cyn+Ma9gwsNJN6+LBEs2L+pIrMEn9MbpF3FN41ItoxNIpgShue4nskuz/E8nTascOZnEU4DCvTnvhenlboftTy4+bZcpTkC268OdRMcXMLchQDaevgLtMvYeb0jx7KAiVXEIT9yRhEVM0OPglGBfjN9yUeM4zWTvhyrbnAraMRI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=YV/MpvKE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="YV/MpvKE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738250979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mJob7iA5v8Inaje40a8inm2DkJcU/L91MMzxsi/pDHA=; b=YV/MpvKEJrxPknBZ79SZrLEXHqs5tBgqpefN2uO7QbsyEXEETDOU4xj0WUMU4KqZqQC53u EL+LiM3SD/wHGe1fCUIi2zabXjM70Kv8OEIoWiNTXHc5orEBWeLB4fB/G2B0ymsRuQCnPf a1TfaQKg7Hqz7atI/aDDIhwbplW7ayw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-529-4bwK-CeSOm2MmF6AfDdxog-1; Thu, 30 Jan 2025 10:29:37 -0500 X-MC-Unique: 4bwK-CeSOm2MmF6AfDdxog-1 X-Mimecast-MFC-AGG-ID: 4bwK-CeSOm2MmF6AfDdxog Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3860bc1d4f1so669908f8f.2 for ; Thu, 30 Jan 2025 07:29:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738250976; x=1738855776; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mJob7iA5v8Inaje40a8inm2DkJcU/L91MMzxsi/pDHA=; b=JI+ynkP4t0HiVnm8VvkLht10dXvOX6OM02HjPBJrzn7MrXfnvB+YF/cB/YyI3qqjVV ElHfJUmoB25rHQL5ebPv7P07z4i9Q+l797BB4sTMftne2rtZQGSkFYlBJ0Y9bZKNC3kW mGO5siUSmT1vuon/djadE9rUwe9ZHi9RKzU8Pjg8j8tKp2poYIpE3xIytXeQDn3inZeM jf4V/r14Dn0MncsbKZPZvaLecIVYYvWnhXq/bgjkBilKsTaQu5j2d7amA4yWWSqq3lyY nkTF0Mo767+Ys+3uiTtSqopORHIVHj43ZsU2UL3Pzl1dRXUeCmb+jJdNZwJNE/nl8lX3 82Tw== X-Forwarded-Encrypted: i=1; AJvYcCWmaEn0RP1AnQ2QyDTNliRD8mqhlx3SBLR1Hiigk3x40vXA6QjNuWv6tQYLmexL2IEgW1EOvPqmoXY=@vger.kernel.org X-Gm-Message-State: AOJu0Yxiy1v7QKE6IFoCjSTLjuK9+Jg/uE8SBKx1yC6gwhdvt61ZdWrp 8uCMRbnKS8Hbf6K9jzlNUudW4dGpKxnw0dhbzVlh8F1oXgu+rwfMyMOhEzNzCy+jdo2NNbbqXpP cXqMNYhzbaq3+RhLhjNKl8KSFc9LBraAhvNaNVHG0VT4TkVQ65GLwyfcVNw== X-Gm-Gg: ASbGnctLUBthTu+QXdLXH5Vqs2k8LtytKAymqXZ+B7ohxINjBWckqIqi7EB6hfyNEsI A8uzRkxyQbFVWPZ5hS9F8wRbE4mPWIkk+RKNfsdBCGZhz6LcRGPnKfET9iCXRtdSsAep2FvhASU tR9J6IHnv9N31pIdM4VpypmJy8S2tNSiwOR08b+pgQhXEn8m7gh1bY9DXWhsChUXN7rG7kom8+P FL40mDEtbCvIxhF6lXjV5BJ6HtmJpWxKATiEZgOuvzUJEu6wik0eS/ufbSvaSVyiPZ8Gfcz4sAP iaJYGDvCHerI7OsbdQXsXPPTiLvDAkZVPSPkJTcMMHcIdIRnraSe3TFUaFTKCHtWbNrtIPmA/a5 ZZDLLzobyDuX9S2BFKo/y6oOw/peMPWPy X-Received: by 2002:a05:6000:1843:b0:38c:5d42:152b with SMTP id ffacd0b85a97d-38c5d421959mr2072514f8f.54.1738250976497; Thu, 30 Jan 2025 07:29:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEPN3coJdC7RmNnCsXNZRQOca969MNFF3pL2YAHjveUq+bLyj1uSaXw1q3EysfNf9vDrtH5PQ== X-Received: by 2002:a05:6000:1843:b0:38c:5d42:152b with SMTP id ffacd0b85a97d-38c5d421959mr2072489f8f.54.1738250976106; Thu, 30 Jan 2025 07:29:36 -0800 (PST) Received: from ?IPV6:2003:cb:c713:3b00:16ce:8f1c:dd50:90fb? (p200300cbc7133b0016ce8f1cdd5090fb.dip0.t-ipconnect.de. [2003:cb:c713:3b00:16ce:8f1c:dd50:90fb]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38c5c125f0fsm2321311f8f.57.2025.01.30.07.29.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 07:29:34 -0800 (PST) Message-ID: Date: Thu, 30 Jan 2025 16:29:33 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 4/4] mm/memory: document restore_exclusive_pte() To: Alistair Popple , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, nouveau@lists.freedesktop.org, Andrew Morton , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Jonathan Corbet , Alex Shi , Yanteng Si , Karol Herbst , Lyude Paul , Danilo Krummrich , David Airlie , Simona Vetter , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pasha Tatashin , Peter Xu , Jason Gunthorpe References: <20250129115803.2084769-1-david@redhat.com> <20250129115803.2084769-5-david@redhat.com> <7vejbjs7btkof4iguvn3nqvozxqpnzbymxbumd7pant4zi4ac4@3ozuzfzsm5tp> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 30.01.25 14:31, Simona Vetter wrote: > On Thu, Jan 30, 2025 at 10:37:06AM +0100, David Hildenbrand wrote: >> On 30.01.25 01:27, Alistair Popple wrote: >>> On Wed, Jan 29, 2025 at 12:58:02PM +0100, David Hildenbrand wrote: >>>> Let's document how this function is to be used, and why the requirement >>>> for the folio lock might maybe be dropped in the future. >>> >>> Sorry, only just catching up on your other thread. The folio lock was to ensure >>> the GPU got a chance to make forward progress by mapping the page. Without it >>> the CPU could immediately invalidate the entry before the GPU had a chance to >>> retry the fault. >>>> Obviously performance wise having such thrashing is terrible, so should >>> really be avoided by userspace, but the lock at least allowed such programs >>> to complete. >> >> Thanks for the clarification. So it's relevant that the MMU notifier in >> remove_device_exclusive_entry() is sent after taking the folio lock. >> >> However, as soon as we drop the folio lock, remove_device_exclusive_entry() >> will become active, lock the folio and trigger the MMU notifier. >> >> So the time it is actually mapped into the device is rather I meant to say "rather short." :) > > Looks like you cut off a bit here (or mail transport did that somewhere), > but see my other reply I don't think this is a legit use-case. So we don't > have to worry. In that case, we would need the folio lock in the future. > Well beyond documenting that if userspace concurrently thrashes > the same page with both device atomics and cpu access it will stall real > bad. I'm curious, is locking between device-cpu or device-device something that can happen frequently? In that case, you would get that trashing naturally? -- Cheers, David / dhildenb