From: Akira Yokosawa <akiyks@gmail.com>
To: Akiyoshi Kurita <weibu@redadmin.org>
Cc: linux-kernel@vger.kernel.org, corbet@lwn.net, linux-doc@vger.kernel.org
Subject: Re: [PATCH] docs/ja_JP: translate more of submitting-patches.rst
Date: Thu, 23 Apr 2026 09:33:55 +0900 [thread overview]
Message-ID: <d299c3f8-f448-46e8-a513-3e17de131af4@gmail.com> (raw)
In-Reply-To: <20260419001051.389599-1-weibu@redadmin.org>
On Sun, 19 Apr 2026 09:10:51 +0900, Akiyoshi Kurita wrote:
> Translate the "Separate your changes", "Style-check your changes",
> and "Select the recipients for your patch" sections in
> Documentation/translations/ja_JP/process/submitting-patches.rst.
>
> Keep the wording close to the English text and wrap lines to match
> the style used in the surrounding Japanese translation.
>
> Signed-off-by: Akiyoshi Kurita <weibu@redadmin.org>
> ---
> .../ja_JP/process/submitting-patches.rst | 166 ++++++++++++++++++
> 1 file changed, 166 insertions(+)
So, if I am counting lines in the English doc right, corresponding
3 sections are at lines 166--275. 275-166+1 = 110.
Why is your translation taking 50% more lines?
>
> diff --git a/Documentation/translations/ja_JP/process/submitting-patches.rst b/Documentation/translations/ja_JP/process/submitting-patches.rst
> index 91bd79a0e9dc..e1adab466507 100644
> --- a/Documentation/translations/ja_JP/process/submitting-patches.rst
> +++ b/Documentation/translations/ja_JP/process/submitting-patches.rst
> @@ -180,3 +180,169 @@ lore.kernel.org のメッセージアーカイブサービスを使ってくだ
>
> $ git log -1 --pretty=fixes 54a4f0239f2e
> Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return the number of pages it actually freed")
> +
> +.. _split_changes:
No, this will collide with the label in the English doc.
Please remember Sphinx treats these labels as global.
Also, there is no reference to this label in this patch.
Labels should be added only when they are referred to.
> +
> +変更を分割する
> +--------------
> +
> +各 **論理的な変更** は、個別のパッチに
> +分けてください。
> +
> +たとえば、単一のドライバに対する変更の中に
> +バグ修正と性能改善の両方が含まれているなら、
> +それらは 2 つ以上のパッチに分けてください。
> +また、変更に API の更新と、その新しい API を
> +使う新しいドライバが含まれているなら、
> +それらは 2 つのパッチに分けてください。
Ah, this time, you are breaking lines at 25 wide-char.
Why??? This doesn't help my reviewing at all.
Be consistent with yourself, please.
Thanks, Akira
[...]
prev parent reply other threads:[~2026-04-23 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-19 0:10 [PATCH] docs/ja_JP: translate more of submitting-patches.rst Akiyoshi Kurita
2026-04-23 0:33 ` Akira Yokosawa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d299c3f8-f448-46e8-a513-3e17de131af4@gmail.com \
--to=akiyks@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weibu@redadmin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox