Re: [PATCH] docs: Only load the translations extension for HTML output

[Akira Yokosawa <akiyks@gmail.com>]

Hi Vegard,

On 2024/02/15 15:22, Vegard Nossum wrote:
> 
> On 15/02/2024 03:43, Akira Yokosawa wrote:
>> On 2024/02/15 8:25, Jonathan Corbet wrote:
>>> +#
>>> +# Only enable the translation extension if we are building the HTML docs;
>>> +# it brings no value otherwise and can cause problems.
>>> +#
>>> +if 'html' in sys.argv:
>>> +    extensions.append('translations')
>>
>> I tested incremental build of latexdocs against Sphinx 7.2.6 as follows:
> 
> [...]
> 
>> WARNING: unknown node type: <LanguagesNode: <#text: 'Chinese (Simpl ...'><#text: 'Chinese (Tradi ... ...>
>>
>> Exception occurred:
>>    File "/home/akira/sphinx-7.2.6/lib/python3.10/site-packages/docutils/nodes.py", line 2068, in unknown_departure
>>      raise NotImplementedError(
>> NotImplementedError: <class 'sphinx.writers.latex.LaTeXTranslator'> departing unknown node type: LanguagesNode
>> The full traceback has been saved in /tmp/sphinx-err-3inve171.log, if you want to report the issue to the developers.
> 
> Jon, this is pretty much what I said would happen here:
> 
> https://lore.kernel.org/all/8b51b6d6-0360-4f42-9b96-02e0ccd0b34f@oracle.com/
> 
> I have a proper fix that should fix all errors everywhere:
> 
> https://lore.kernel.org/all/4806c264-1076-401b-bb5f-283fb7b68fb3@oracle.com/

Oh, that's even better!

> 
> Why not use that? I'll do a proper submission, I was just waiting a
> couple of days to see if anybody else would would test it too.

I didn't respond because I mistook your words

> I'll test a bit more and submit a proper patch if this works.

and decided to wait for a proper patch from you.  I was thinking
the delay meant there was something you needed to work further...

I've just tested your proper patch and it worked across v4.3.2 (of
Ubuntu 22.04) and V6.2.1 (of Fedora 39), among others.

Many thanks,
Akira

> 
> 
> Vegard