From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AF4D43BCD07; Thu, 11 Jun 2026 09:50:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781171440; cv=none; b=HpTwJm39Bp0F7WtHfTk8jr5t81gz2eZF7Pb1W0Wkrrowl164eJUXMuWwNiFy98oehi1dopPPOfM8e7KCpXCzL54VgkeQNnKNVsGScNxaYQOMqw55va5zy1QbnvPJFE8tZxCBcFOUWpuE0uNT60fxhs71fbS8i3RQZrqDUP+8PKU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781171440; c=relaxed/simple; bh=giW2ha6I059T0G+qHAhzVhjSsPjt0+qNu14U4xR5Kok=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=q02jSleJIYSNqGfW9vRSbMkr2jvlnqx3KIHC4rOASwvdAcCqLs4YSi/GMINjbyUn/cYwuLLDPDj3P2B7AshjTo4YgICUAXHfHX4vOPtF9AoVBnCNXEWNZpRhAdE7CYzTwquvzWX6+sXmahBDFJz//5xNdVSl/wuTZG6Q2adR/fU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=ZaTrMu8m; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="ZaTrMu8m" Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DB5BA1E5E; Thu, 11 Jun 2026 02:50:32 -0700 (PDT) Received: from [10.174.41.206] (unknown [10.174.41.206]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 723DF3F99C; Thu, 11 Jun 2026 02:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1781171437; bh=giW2ha6I059T0G+qHAhzVhjSsPjt0+qNu14U4xR5Kok=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=ZaTrMu8mAWfzsBKisoH3fnQkGfn0yNj/TxIkV+zx2PNNtyQQXWrVHo0eThpQs16p4 VZaQ43d6LxXNzSq/wlTpvMWRbR3Tpjk7i1y9adDunaSF+7+4u2qsv34+d3e3SBuTCS jjxnQdSKzFNLvwdBFzq8OxGGg5ZmRV/TISIw9O6A= Message-ID: Date: Thu, 11 Jun 2026 15:20:13 +0530 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC V2 1/3] lib/vsprintf: Add support for pgtable entries To: Andy Shevchenko Cc: Usama Arif , linux-mm@kvack.org, Rasmus Villemoes , Sergey Senozhatsky , Petr Mladek , Steven Rostedt , Jonathan Corbet , Andrew Morton , David Hildenbrand , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, David Hildenbrand , Lorenzo Stoakes , Andy Whitcroft References: <20260610111339.2465922-1-usama.arif@linux.dev> <919d334b-16a3-4412-82f4-b4cd6a35be0d@arm.com> Content-Language: en-US From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/06/26 12:47 PM, Andy Shevchenko wrote: > On Thu, Jun 11, 2026 at 10:45:01AM +0530, Anshuman Khandual wrote: >> On 10/06/26 4:43 PM, Usama Arif wrote: >>> On Wed, 10 Jun 2026 05:35:43 +0100 Anshuman Khandual wrote: > > ... > >>>> + static_assert(sizeof(pte_t) == 4 || >>>> + sizeof(pte_t) == 8, >>>> + "pte_t size must be 4 or 8 bytes"); > > Besides occupying too many lines, why are these static asserts hidden here and > not declared in the global space? More wide Q is why they are needed at all? Sure, will move these static_assert just above pxd_pointer() These asserts ensure - Platforms have either 32 bit or 64 bit pgtable descriptors - special_hex_number() can be used to print such descriptors