From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83506257AC7 for ; Tue, 19 Aug 2025 13:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755611959; cv=none; b=E0ck9d5ptdoX2FbECCrxzLS+Z948OTTXZP+sMzN9S6Jjsq8678ZW/MD1//ZAFa6cymPhQ8vVLFUtbO8ZHjny5FvH/CsDEA8XFh1oat+q/6YQkAyzA8t/lzVlC18X0nAXSV11XhMCQQLj113B6TbvZjlSMFrHJvl8Mx0skf/GBng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755611959; c=relaxed/simple; bh=Szn3Y6AMPK50aULs7Wlbsj0z61OPOFi2aKHKUZhTJtI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Jxm9MceRuCdkIdvRE2S6uYIbvKtVmfj3gspRH6Vgy/7tkRkv5KK9xPAaPgHH4LympPqnlGUgaQomzUgdWvhe5kihDq+1jTG+8M3S81+4LJqASokXh2ozC2PW3qJtleAqxO/RB5uuat43nx0Me3EGBVdVeGnFtL58wmLG71gb0do= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=ar+pJ5rp; arc=none smtp.client-ip=91.218.175.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="ar+pJ5rp" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1755611955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CeRHv9dJ0yAy5sI3HR6ZowOM/hpbkUM1vk+TTh1pOvk=; b=ar+pJ5rpIlmZzzG/tk8atTNL52LbMuto6tyXaRDSIM1DF0dpkCH90AfIsAh1kgnQ+9lulm qHL/Gda2Pxt/fYM7jE0TmGGIB9wH0Ds3Zdm0hnxn9sFdjmbqgFDEHGwQNVj1rhmo3/LPWN 7BpPySIVwhXqh39sgmH2qtLmCpoHTlQ= Date: Tue, 19 Aug 2025 14:59:09 +0100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v5 2/5] net: rnpgbe: Add n500/n210 chip support To: Dong Yibo , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, corbet@lwn.net, gur.stavi@huawei.com, maddy@linux.ibm.com, mpe@ellerman.id.au, danishanwar@ti.com, lee@trager.us, gongfan1@huawei.com, lorenzo@kernel.org, geert+renesas@glider.be, Parthiban.Veerasooran@microchip.com, lukas.bulwahn@redhat.com, alexanderduyck@fb.com, richardcochran@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org References: <20250818112856.1446278-1-dong100@mucse.com> <20250818112856.1446278-3-dong100@mucse.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250818112856.1446278-3-dong100@mucse.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 18/08/2025 12:28, Dong Yibo wrote: > Initialize n500/n210 chip bar resource map and > dma, eth, mbx ... info for future use. > [...] > +struct mucse_hw { > + void __iomem *hw_addr; > + void __iomem *ring_msix_base; > + struct pci_dev *pdev; > + enum rnpgbe_hw_type hw_type; > + struct mucse_dma_info dma; > + struct mucse_eth_info eth; > + struct mucse_mac_info mac; > + struct mucse_mbx_info mbx; > + u32 usecstocount; What is this field for? You don't use it anywhere in the patchset apart from initialization. Maybe it's better to introduce it once it's used? Together with the defines of values for this field...