Re: [PATCH v13 01/25] virt: geniezone: enable gzvm-ko in defconfig

["Liju-clr Chen (陳麗如)" <Liju-clr.Chen@mediatek.com>]

On Wed, 2024-12-11 at 09:38 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On 14/11/2024 11:07, Liju-clr Chen wrote:
> > From: Yingshiuan Pan <yingshiuan.pan@mediatek.com>
> > 
> 
> Please use subject prefixes matching the subsystem. You can get them
> for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the
> directory
> your patch is touching.
> 
> 
> > Add config in defconfig to enable gzvm driver by default
> 
> This we see from the diff. You must explain why we want it.
> 
> > 
> > Signed-off-by: Yingshiuan Pan <yingshiuan.pan@mediatek.com>
> > Signed-off-by: Yi-De Wu <yi-de.wu@mediatek.com>
> > Signed-off-by: Liju Chen <liju-clr.chen@mediatek.com>
> > ---
> >  arch/arm64/configs/defconfig | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/arch/arm64/configs/defconfig
> > b/arch/arm64/configs/defconfig
> > index d13218d0c30f..0f63d4837b61 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -1733,3 +1733,5 @@ CONFIG_CORESIGHT_STM=m
> >  CONFIG_CORESIGHT_CPU_DEBUG=m
> >  CONFIG_CORESIGHT_CTI=m
> >  CONFIG_MEMTEST=y
> > +CONFIG_VIRT_DRIVERS=y
> > +CONFIG_MTK_GZVM=m
> 
> Does not look like placed correctly, according to savedefconfig.
> 
> I still do not see any reason to have it enabled.
> 
> Your patches have weird order or this is just wrong. There is no such
> thing as "MTK_GZVM". Use git grep, if you do not believe me.
> 
> 
> Best regards,
> Krzysztof

Hi Krzysztof,
Thank you for your comments. I agree with your suggestions.
We will remove this patch in the next version.

Best regards,
Liju Chen