From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF5FFC001DE for ; Tue, 25 Jul 2023 09:10:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229963AbjGYJKj (ORCPT ); Tue, 25 Jul 2023 05:10:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232968AbjGYJKh (ORCPT ); Tue, 25 Jul 2023 05:10:37 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 700FA10B for ; Tue, 25 Jul 2023 02:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690276190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3q/xBZbb8dNJd9KUqNimqM/jz1gI+oQ8PYpYvQS8xzU=; b=UrcQsEe23P97i9irpwurddNLXGygyuMc+BUx5TV/xAZVdEUmOom8M2c/Tu+uTR3xqE/NA5 YdNItaocGw/Lnv5O/FC8G24ItwJEh+nNNoQ2IAR1xCwBW/gL7GcErJyJjz+ZC8xKvmVL53 K7ll9tYz0wPGiiXD2Zfmf3RDKZQxRHQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-283-xjy8Kv--N2q-S6SjemU7UQ-1; Tue, 25 Jul 2023 05:09:45 -0400 X-MC-Unique: xjy8Kv--N2q-S6SjemU7UQ-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3176fe7b67bso67637f8f.2 for ; Tue, 25 Jul 2023 02:09:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690276184; x=1690880984; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3q/xBZbb8dNJd9KUqNimqM/jz1gI+oQ8PYpYvQS8xzU=; b=A5tZUuX9Md6Ej32CE0/KNA1QyFNSuNpwHXXWj9C4rHiUsgSZZDRBYUq1So8uPcEqyp 6JuNdFYA85kaSueyRKNgSRQaT4EXbCG1WoYQ7dQvmnHr603auhxqKxw9w0BaWMaie8l1 SdXBnJOktLj8oXx/A6qe4gORc8JhiMGBqz30Na9SNBrQp1hUGLHZUT01yKukyNd7FGby VHAkQim6aqieR+oADAGbqKIjpDUGlyWJSmtXWTqwR1gVWgZi7WwPfmaBbFHHHCp4k3FR mcTyXwmscFQB/SCLDg5D7oMp8Pa/8w/+F+NL7IZmEQPc/mnhp4x7MUHApu7sb8LblqcG ZD3A== X-Gm-Message-State: ABy/qLaYFy6vPPRNzu5wy2PIoUImztF1Jl8pz8bZMWms23WhC9JmKCmF wGzpEAxmSv0MIc5laDY9bj1nNbSuBldIkFhOsHbAJvmms2XIFApju6Ltd6eSy1/09+3+58poV7a +AF5MNsisa8Cj56nI86iN X-Received: by 2002:a05:6000:11d2:b0:317:6189:fe7a with SMTP id i18-20020a05600011d200b003176189fe7amr2929543wrx.58.1690276184632; Tue, 25 Jul 2023 02:09:44 -0700 (PDT) X-Google-Smtp-Source: APBJJlHJhKb7Na5u7xDM7XxCVQynmdPLcEhJmCjHzDLFndkhKf7ubBFimSpfzjh7MV3QAw8D9D7c8A== X-Received: by 2002:a05:6000:11d2:b0:317:6189:fe7a with SMTP id i18-20020a05600011d200b003176189fe7amr2929526wrx.58.1690276184192; Tue, 25 Jul 2023 02:09:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c73f:e900:3b0d:87a6:2953:20d1? (p200300cbc73fe9003b0d87a6295320d1.dip0.t-ipconnect.de. [2003:cb:c73f:e900:3b0d:87a6:2953:20d1]) by smtp.gmail.com with ESMTPSA id m9-20020a5d56c9000000b00313e2abfb8dsm15804076wrw.92.2023.07.25.02.09.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jul 2023 02:09:43 -0700 (PDT) Message-ID: Date: Tue, 25 Jul 2023 11:09:42 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] docs: mm: Fix number of base pages for 1GB HugeTLB Content-Language: en-US To: Usama Arif , songmuchun@bytedance.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, fam.zheng@bytedance.com, liangma@liangbit.com References: <20230207114456.2304801-1-usama.arif@bytedance.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230207114456.2304801-1-usama.arif@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 07.02.23 12:44, Usama Arif wrote: > 1GB HugeTLB page consists of 262144 base pages. > > Signed-off-by: Usama Arif > --- > Documentation/mm/vmemmap_dedup.rst | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/mm/vmemmap_dedup.rst b/Documentation/mm/vmemmap_dedup.rst > index a4b12ff906c4..689a6907c70b 100644 > --- a/Documentation/mm/vmemmap_dedup.rst > +++ b/Documentation/mm/vmemmap_dedup.rst > @@ -1,3 +1,4 @@ > + > .. SPDX-License-Identifier: GPL-2.0 > > ========================================= > @@ -17,7 +18,7 @@ HugeTLB pages consist of multiple base page size pages and is supported by many > architectures. See Documentation/admin-guide/mm/hugetlbpage.rst for more > details. On the x86-64 architecture, HugeTLB pages of size 2MB and 1GB are > currently supported. Since the base page size on x86 is 4KB, a 2MB HugeTLB page > -consists of 512 base pages and a 1GB HugeTLB page consists of 4096 base pages. > +consists of 512 base pages and a 1GB HugeTLB page consists of 262144 base pages. > For each base page, there is a corresponding ``struct page``. > > Within the HugeTLB subsystem, only the first 4 ``struct page`` are used to Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb