linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yohan Pipereau <yohan.pipereau@gmail.com>
To: corbet@lwn.net
Cc: linux-doc@vger.kernel.org, Yohan Pipereau <yohan.pipereau@gmail.com>
Subject: [PATCH] Documentation : Update relay function types
Date: Sun, 8 Jul 2018 20:19:32 +0200	[thread overview]
Message-ID: <d8f47b2d-dd39-ba65-8c4e-149718aea5bf@gmail.com> (raw)

This patch updates two callback functions provided as an example in
relay API documentation : subbuf_start and create_buf_file_handler.

These functions were using older and incorrect types causing an
"initialization from incompatible pointer type".

diffstat for this patch is:
 relay.txt |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Signed-off-by: Yohan Pipereau <yohan.pipereau@gmail.com>
---

diff --git a/Documentation/filesystems/relay.txt
b/Documentation/filesystems/relay.txt
index 33e2f3694733..cd709a94d054 100644
--- a/Documentation/filesystems/relay.txt
+++ b/Documentation/filesystems/relay.txt
@@ -222,7 +222,7 @@ using debugfs:
  */
 static struct dentry *create_buf_file_handler(const char *filename,
                                               struct dentry *parent,
-                                              int mode,
+                                              umode_t mode,
                                               struct rchan_buf *buf,
                                               int *is_global)
 {
@@ -375,7 +375,7 @@ would be very similar:
 static int subbuf_start(struct rchan_buf *buf,
                         void *subbuf,
 			void *prev_subbuf,
-			unsigned int prev_padding)
+			size_t prev_padding)
 {
 	if (prev_subbuf)
 		*((unsigned *)prev_subbuf) = prev_padding;
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-07-08 18:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-08 18:19 Yohan Pipereau [this message]
2018-07-10 21:12 ` [PATCH] Documentation : Update relay function types Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8f47b2d-dd39-ba65-8c4e-149718aea5bf@gmail.com \
    --to=yohan.pipereau@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).