* [PATCH] Documentation : Update relay function types
@ 2018-07-08 18:19 Yohan Pipereau
2018-07-10 21:12 ` Jonathan Corbet
0 siblings, 1 reply; 2+ messages in thread
From: Yohan Pipereau @ 2018-07-08 18:19 UTC (permalink / raw)
To: corbet; +Cc: linux-doc, Yohan Pipereau
This patch updates two callback functions provided as an example in
relay API documentation : subbuf_start and create_buf_file_handler.
These functions were using older and incorrect types causing an
"initialization from incompatible pointer type".
diffstat for this patch is:
relay.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Signed-off-by: Yohan Pipereau <yohan.pipereau@gmail.com>
---
diff --git a/Documentation/filesystems/relay.txt
b/Documentation/filesystems/relay.txt
index 33e2f3694733..cd709a94d054 100644
--- a/Documentation/filesystems/relay.txt
+++ b/Documentation/filesystems/relay.txt
@@ -222,7 +222,7 @@ using debugfs:
*/
static struct dentry *create_buf_file_handler(const char *filename,
struct dentry *parent,
- int mode,
+ umode_t mode,
struct rchan_buf *buf,
int *is_global)
{
@@ -375,7 +375,7 @@ would be very similar:
static int subbuf_start(struct rchan_buf *buf,
void *subbuf,
void *prev_subbuf,
- unsigned int prev_padding)
+ size_t prev_padding)
{
if (prev_subbuf)
*((unsigned *)prev_subbuf) = prev_padding;
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Documentation : Update relay function types
2018-07-08 18:19 [PATCH] Documentation : Update relay function types Yohan Pipereau
@ 2018-07-10 21:12 ` Jonathan Corbet
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Corbet @ 2018-07-10 21:12 UTC (permalink / raw)
To: Yohan Pipereau; +Cc: linux-doc
On Sun, 8 Jul 2018 20:19:32 +0200
Yohan Pipereau <yohan.pipereau@gmail.com> wrote:
> This patch updates two callback functions provided as an example in
> relay API documentation : subbuf_start and create_buf_file_handler.
>
> These functions were using older and incorrect types causing an
> "initialization from incompatible pointer type".
Heh, nobody has seriously touched that file in ten years. Patch applied,
but...
> diffstat for this patch is:
> relay.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Please include information like this after the "---" line so I don't have
to edit it out of the changelog manually.
Thanks,
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-10 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-08 18:19 [PATCH] Documentation : Update relay function types Yohan Pipereau
2018-07-10 21:12 ` Jonathan Corbet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).