From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: "Derek J. Clark" <derekjohn.clark@gmail.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Armin Wolf <W_Armin@gmx.de>, Jonathan Corbet <corbet@lwn.net>,
Mario Limonciello <superm1@kernel.org>,
Luke Jones <luke@ljones.dev>, Xino Ni <nijs1@lenovo.com>,
Zhixin Zhang <zhangzx36@lenovo.com>,
Mia Shao <shaohz1@lenovo.com>,
Mark Pearson <mpearson-lenovo@squebb.ca>,
"Pierre-Loup A . Griffais" <pgriffais@valvesoftware.com>,
"Cody T . -H . Chiu" <codyit@gmail.com>,
John Martens <johnfanv2@gmail.com>,
platform-driver-x86@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 6/6] platform/x86: Add Lenovo Other Mode WMI Driver
Date: Sat, 3 May 2025 15:12:38 +0530 [thread overview]
Message-ID: <d99f91d0-e511-4012-b681-c348ab5c2fc1@oracle.com> (raw)
In-Reply-To: <20250503000142.1190354-7-derekjohn.clark@gmail.com>
Hi Derek,
Thanks for your patch.
On 03-05-2025 05:31, Derek J. Clark wrote:
> + attribute_id =
> + FIELD_PREP(LWMI_ATTR_DEV_ID_MASK, tunable_attr->device_id) |
> + FIELD_PREP(LWMI_ATTR_FEAT_ID_MASK, tunable_attr->feature_id) |
> + FIELD_PREP(LWMI_ATTR_MODE_ID_MASK, LWMI_GZ_THERMAL_MODE_CUSTOM) |
> + FIELD_PREP(LWMI_ATTR_TYPE_ID_MASK, tunable_attr->type_id);
> +
> + //capdata = devm_kzalloc(&priv->wdev->dev, sizeof(*capdata), GFP_KERNEL);
> + //if (!capdata)
> + // return -ENOMEM;
remove this dead code
> +
> + ret = lwmi_cd01_get_data(priv->cd01_list, attribute_id, &capdata);
> + if (ret)
> + return ret;
Reviewed-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Thanks,
Alok
next prev parent reply other threads:[~2025-05-03 9:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-03 0:01 [PATCH v7 0/6] platform/x86: Add Lenovo WMI Gaming Series Drivers Derek J. Clark
2025-05-03 0:01 ` [PATCH v7 1/6] platform/x86: Add lenovo-wmi-* driver Documentation Derek J. Clark
2025-05-03 0:01 ` [PATCH v7 2/6] platform/x86: Add lenovo-wmi-helpers Derek J. Clark
2025-05-03 0:01 ` [PATCH v7 3/6] platform/x86: Add Lenovo WMI Events Driver Derek J. Clark
2025-05-03 0:01 ` [PATCH v7 4/6] platform/x86: Add Lenovo Capability Data 01 WMI Driver Derek J. Clark
2025-05-03 8:37 ` ALOK TIWARI
2025-05-04 2:18 ` Armin Wolf
2025-05-04 3:05 ` Derek J. Clark
2025-05-03 0:01 ` [PATCH v7 5/6] platform/x86: Add Lenovo Gamezone " Derek J. Clark
2025-05-04 2:22 ` Armin Wolf
2025-05-03 0:01 ` [PATCH v7 6/6] platform/x86: Add Lenovo Other Mode " Derek J. Clark
2025-05-03 9:42 ` ALOK TIWARI [this message]
2025-05-03 18:05 ` Derek J. Clark
2025-05-04 2:28 ` Armin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d99f91d0-e511-4012-b681-c348ab5c2fc1@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=W_Armin@gmx.de \
--cc=codyit@gmail.com \
--cc=corbet@lwn.net \
--cc=derekjohn.clark@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johnfanv2@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=mpearson-lenovo@squebb.ca \
--cc=nijs1@lenovo.com \
--cc=pgriffais@valvesoftware.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=shaohz1@lenovo.com \
--cc=superm1@kernel.org \
--cc=zhangzx36@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox