From: Tao Cui <cui.tao@linux.dev>
To: "Sun Shaojie" <sunshaojie@kylinos.cn>,
"Tejun Heo" <tj@kernel.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Jonathan Corbet" <corbet@lwn.net>
Cc: cui.tao@linux.dev, Shuah Khan <skhan@linuxfoundation.org>,
cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cgroup/cpu: document cpu.stat.local
Date: Thu, 25 Jun 2026 22:05:46 +0800 [thread overview]
Message-ID: <d9ada3a3-6978-4602-a11d-689e0fa4171a@linux.dev> (raw)
In-Reply-To: <20260625130723.1144463-1-sunshaojie@kylinos.cn>
在 2026/6/25 21:07, Sun Shaojie 写道:
> Add documentation for the cpu.stat.local interface file, which reports
> the throttled_usec stat -- the actual throttling time incurred by the
> cgroup's own runqueues, which may include throttling inherited from
> ancestor cgroup bandwidth limits. Unlike cpu.stat's throttled_usec
> which only accounts for throttling caused by the cgroup's own CFS
> bandwidth limit.
>
> When the controller is not enabled, the stat is not reported.
>
> Signed-off-by: Sun Shaojie <sunshaojie@kylinos.cn>
> ---
> Documentation/admin-guide/cgroup-v2.rst | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 993446ab66d0..a7766f40ef65 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -1160,6 +1160,23 @@ will be referred to. All time durations are in microseconds.
> - nr_bursts
> - burst_usec
>
> + cpu.stat.local
> + A read-only flat-keyed file which exists on non-root cgroups.
> + This file exists whether the controller is enabled or not.
> +
Hi Shaojie,
Thanks — the throttled_usec semantics are described correctly.
One fix needed: "exists on non-root cgroups" is inaccurate.
cpu.stat.local is registered without CFTYPE_NOT_ON_ROOT, so (like
cpu.stat) it exists on the root cgroup too:
$ cat /sys/fs/cgroup/cpu.stat.local
throttled_usec 0
Reviewed-by: Tao Cui <cuitao@kylinos.cn>
Thanks,
Tao
> + It reports the following stat when the controller is enabled:
> +
> + - throttled_usec
> +
> + Unlike the ``throttled_usec`` reported by ``cpu.stat`` which
> + accounts for throttling caused by this cgroup's own CFS
> + bandwidth limit, ``cpu.stat.local`` reports the actual
> + throttling time incurred by this cgroup's own runqueues,
> + which may include throttling inherited from ancestor
> + cgroup bandwidth limits.
> +
> + When the controller is not enabled, this stat is not reported.
> +
> cpu.weight
> A read-write single value file which exists on non-root
> cgroups. The default is "100".
next prev parent reply other threads:[~2026-06-25 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-25 13:07 [PATCH] cgroup/cpu: document cpu.stat.local Sun Shaojie
2026-06-25 14:05 ` Tao Cui [this message]
2026-06-26 1:09 ` [PATCH v2] " Sun Shaojie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d9ada3a3-6978-4602-a11d-689e0fa4171a@linux.dev \
--to=cui.tao@linux.dev \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=hannes@cmpxchg.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=skhan@linuxfoundation.org \
--cc=sunshaojie@kylinos.cn \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox