From: Ashish Mhetre <amhetre@nvidia.com>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: catalin.marinas@arm.com, will@kernel.org, corbet@lwn.net,
skhan@linuxfoundation.org, robin.murphy@arm.com, joro@8bytes.org,
jgg@ziepe.ca, linux-arm-kernel@lists.infradead.org,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev, linux-tegra@vger.kernel.org,
Jason Gunthorpe <jgg@nvidia.com>
Subject: Re: [PATCH v8 2/3] iommu/arm-smmu-v3: Introduce CFGI/TLBI-repeat workaround infrastructure
Date: Fri, 24 Jul 2026 09:53:21 +0530 [thread overview]
Message-ID: <da01c304-2349-436d-a38d-6b925b6fc86d@nvidia.com> (raw)
In-Reply-To: <amETqr7ZBtgt2DKu@nvidia.com>
On 7/23/2026 12:32 AM, Nicolin Chen wrote:
> On Wed, Jul 22, 2026 at 10:20:32AM +0000, Ashish Mhetre wrote:
>> diff --git a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
>> index c909c9a88538..9508bf50d14c 100644
>> --- a/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
>> +++ b/drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.h
>> @@ -1207,10 +1207,15 @@ void arm_smmu_attach_commit(struct arm_smmu_attach_state *state);
>> int arm_smmu_cmdq_issue_cmdlist(struct arm_smmu_device *smmu,
>> struct arm_smmu_cmdq *cmdq,
>> struct arm_smmu_cmd *cmds, int n,
>> bool sync);
>> +bool arm_smmu_erratum_cmd_needs_repeating(struct arm_smmu_cmd *cmd);
>
> Is this needed?
>
> Nicolin
It isn’t, thanks for pointing out. After dropping arm_vsmmu_can_batch_cmd(),
that helper is only used inside arm-smmu-v3.c, so it should become
static there
and be removed from the header.
Thanks,
Ashish Mhetre
next prev parent reply other threads:[~2026-07-24 4:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 10:20 [PATCH v8 0/3] iommu/arm-smmu-v3: Tegra264 invalidation workaround Ashish Mhetre
2026-07-22 10:20 ` [PATCH v8 1/3] iommu/arm-smmu-v3: Factor out CMDQ batch force-sync conditions Ashish Mhetre
2026-07-22 10:20 ` [PATCH v8 2/3] iommu/arm-smmu-v3: Introduce CFGI/TLBI-repeat workaround infrastructure Ashish Mhetre
2026-07-22 19:02 ` Nicolin Chen
2026-07-24 4:23 ` Ashish Mhetre [this message]
2026-07-22 10:20 ` [PATCH v8 3/3] iommu/arm-smmu-v3: Enable CFGI/TLBI-repeat workaround on Tegra264 Ashish Mhetre
2026-07-22 19:16 ` Nicolin Chen
2026-07-24 4:24 ` Ashish Mhetre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da01c304-2349-436d-a38d-6b925b6fc86d@nvidia.com \
--to=amhetre@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=corbet@lwn.net \
--cc=iommu@lists.linux.dev \
--cc=jgg@nvidia.com \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=skhan@linuxfoundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox