From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org, timur@codeaurora.org,
Kate Stewart <kstewart@linuxfoundation.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Petr Tesarik <ptesarik@suse.cz>, Ram Pai <linuxram@us.ibm.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Christoffer Dall <cdall@linaro.org>,
Jonathan Corbet <corbet@lwn.net>,
"maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
David Rientjes <rientjes@google.com>,
Thymo van Beers <thymovanbeers@gmail.com>,
Borislav Petkov <bp@suse.de>,
Tom Lendacky <thomas.lendacky@amd.com>,
Marc Zyngier <marc.zyngier@arm.com>,
linux-arm-msm@vger.kernel.org,
Frederic Weisbecker <frederic@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
Juergen Gross <jgross@suse.com>,
Dou Liyang <douly.fnst@cn.fujitsu.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>,
Philippe Ombredanne <pombredanne@nexb.com>
Subject: Re: [PATCH V2] PCI: move early dump functionality from x86 arch into the common code
Date: Fri, 1 Jun 2018 14:58:48 -0400 [thread overview]
Message-ID: <dac3d600-86c4-456a-046b-f2229a8c19d7@codeaurora.org> (raw)
In-Reply-To: <20180601185310.GA175802@bhelgaas-glaptop.roam.corp.google.com>
On 6/1/2018 2:53 PM, Bjorn Helgaas wrote:
>> + pci_info(pdev, "pci 0000:%02x:%02x.%d config space:\n",
>> + pdev->bus->number, PCI_SLOT(pdev->devfn),
>> + PCI_FUNC(pdev->devfn));
> I'm still missing something -- why go to the trouble of pdev->bus->number,
> PCI_SLOT(), etc? Isn't the output going to look like this?
>
> pci 0000:00:00.0: pci 0000:00:00.0 config space:
>
> In other words, wouldn't the following be enough?
>
> pci_info(pdev, "config space:\n");
>
You are right. The origin print function was pr_info. We don't need that
stuff anymore.
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-06-01 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 18:47 [PATCH V2] PCI: move early dump functionality from x86 arch into the common code Sinan Kaya
2018-06-01 18:53 ` Bjorn Helgaas
2018-06-01 18:58 ` Sinan Kaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dac3d600-86c4-456a-046b-f2229a8c19d7@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@suse.de \
--cc=cdall@linaro.org \
--cc=corbet@lwn.net \
--cc=douly.fnst@cn.fujitsu.com \
--cc=frederic@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kai.heng.feng@canonical.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=luto@kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mingo@redhat.com \
--cc=mpatocka@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pombredanne@nexb.com \
--cc=ptesarik@suse.cz \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=thymovanbeers@gmail.com \
--cc=timur@codeaurora.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).