From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.6 required=5.0 tests=DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id D462B7D072 for ; Fri, 1 Jun 2018 18:58:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752653AbeFAS64 (ORCPT ); Fri, 1 Jun 2018 14:58:56 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33226 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752572AbeFAS6y (ORCPT ); Fri, 1 Jun 2018 14:58:54 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EFF036084F; Fri, 1 Jun 2018 18:58:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527879534; bh=CCwyDOlSErjJ7611TezrgPLxKM7+jIvWTIzqOaRHDcI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=IqRMarItyJFd6Z5Jv9lS5tvfPywZTYsXW0CB8iamaT9d9guhWmD8R1WJXB55moWo9 aTftfrZldIiessVWoQU0ZVvNIu/F3OSJEvgOou7vcv/TMkE21LaYyA1k9Xv03CYefm 8NjSk87xKzkCOQJ4tns/+1Yemb7fj2ue69m5EZac= Received: from [10.235.228.150] (global_nat1_iad_fw.qualcomm.com [129.46.232.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: okaya@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1FFB960251; Fri, 1 Jun 2018 18:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1527879532; bh=CCwyDOlSErjJ7611TezrgPLxKM7+jIvWTIzqOaRHDcI=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=E8cSWKmOpzvm/8OmYEUr3aOi0KtO0i8Ajl0ikM6l8SvM1UNVrhcMwbZ842RFWRkIn 50S8FY1MHj5pJ01GuNuJSd85iWQ/OwPVeWauDkqcwHgzcpSVqoVaIscNbcugDyC+gH ctcVOYWmD785TEw861KMJHtlfNQPNNIYxospGNF4= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1FFB960251 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=okaya@codeaurora.org Subject: Re: [PATCH V2] PCI: move early dump functionality from x86 arch into the common code To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, timur@codeaurora.org, Kate Stewart , "open list:DOCUMENTATION" , Petr Tesarik , Ram Pai , Kai-Heng Feng , "H. Peter Anvin" , Boris Ostrovsky , Christoffer Dall , Jonathan Corbet , "maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" , Ingo Molnar , David Rientjes , Thymo van Beers , Borislav Petkov , Tom Lendacky , Marc Zyngier , linux-arm-msm@vger.kernel.org, Frederic Weisbecker , Mikulas Patocka , Andy Lutomirski , Bjorn Helgaas , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Juergen Gross , Dou Liyang , "Paul E. McKenney" , Greg Kroah-Hartman , open list , Philippe Ombredanne References: <1527878854-21419-1-git-send-email-okaya@codeaurora.org> <20180601185310.GA175802@bhelgaas-glaptop.roam.corp.google.com> From: Sinan Kaya Message-ID: Date: Fri, 1 Jun 2018 14:58:48 -0400 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180601185310.GA175802@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 6/1/2018 2:53 PM, Bjorn Helgaas wrote: >> + pci_info(pdev, "pci 0000:%02x:%02x.%d config space:\n", >> + pdev->bus->number, PCI_SLOT(pdev->devfn), >> + PCI_FUNC(pdev->devfn)); > I'm still missing something -- why go to the trouble of pdev->bus->number, > PCI_SLOT(), etc? Isn't the output going to look like this? > > pci 0000:00:00.0: pci 0000:00:00.0 config space: > > In other words, wouldn't the following be enough? > > pci_info(pdev, "config space:\n"); > You are right. The origin print function was pr_info. We don't need that stuff anymore. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html