From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-5.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id EC1817DF8B for ; Mon, 18 Jun 2018 15:14:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965144AbeFRPH2 convert rfc822-to-8bit (ORCPT ); Mon, 18 Jun 2018 11:07:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49330 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964942AbeFRPHZ (ORCPT ); Mon, 18 Jun 2018 11:07:25 -0400 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35A3130820CA; Mon, 18 Jun 2018 15:07:25 +0000 (UTC) Received: from llong.remote.csb (ovpn-117-25.phx2.redhat.com [10.3.117.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id A69F6308BDA2; Mon, 18 Jun 2018 15:07:17 +0000 (UTC) Subject: Re: [PATCH v10 0/9] cpuset: Enable cpuset controller in default hierarchy To: Juri Lelli Cc: Tejun Heo , Li Zefan , Johannes Weiner , Peter Zijlstra , Ingo Molnar , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@fb.com, pjt@google.com, luto@amacapital.net, Mike Galbraith , torvalds@linux-foundation.org, Roman Gushchin , Patrick Bellasi References: <1529295249-5207-1-git-send-email-longman@redhat.com> <20180618142036.GA13097@localhost.localdomain> From: Waiman Long Organization: Red Hat Message-ID: Date: Mon, 18 Jun 2018 23:07:16 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: <20180618142036.GA13097@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.47]); Mon, 18 Jun 2018 15:07:25 +0000 (UTC) Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 06/18/2018 10:20 PM, Juri Lelli wrote: > Hi, > > On 18/06/18 12:13, Waiman Long wrote: >> v10: >> - Remove the cpuset.sched.load_balance patch for now as it may not >> be that useful. >> - Break the large patch 2 into smaller patches to make them a bit >> easier to review. >> - Test and fix issues related to changing "cpuset.cpus" and cpu >> online/offline in a domain root. >> - Rename isolated_cpus to reserved_cpus as this cpumask holds CPUs >> reserved for child sched domains. >> - Rework the scheduling domain debug printing code in the last patch. >> - Document update to the newly moved >> Documentation/admin-guide/cgroup-v2.rst. > There seem to be two (similar but different) 6/9 in the set. Something > went wrong? The isolated_cpus patch is old, I forgot to remove it before sending out the patch. > Also I can't seem to be able to create a subgroup with an isolated > domain root. I think that, when doing the following > > # mount -t cgroup2 none /sys/fs/cgroup > # echo "+cpuset" >/sys/fs/cgroup/cgroup.subtree_control > # mkdir /sys/fs/cgroup/g1 > # echo 0-1 >/sys/fs/cgroup/g1/cpuset.cpus > # echo 1 >/sys/fs/cgroup/g1/cpuset.sched.domain_root > > rebuild_sched_domains_locked exits early, since > top_cpuset.effective_cpus != cpu_active_mask. (effective_cpus being 2-3 > at this point since I'm testing this on a 0-3 system) > > In your v9 this [1] was adding a special condition to make rebuilding of > domains happen. Was the change intentional? Can you reply to the relevant patch to pinpoint what condition are you talking about? I do try to eliminate domain rebuild as much as possible, but I am just not sure which condition you have question about. Cheers, Longman -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html