Linux Documentation
 help / color / mirror / Atom feed
From: "Danny Lin" <danny@kdrag0n.dev>
To: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>, masahiroy@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	"Íñigo Huguet" <ihuguet@redhat.com>,
	"Mickaël Salaün" <mic@digikod.net>,
	"Vincent Mailhol" <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH] .editorconfig: move to Documentation/ directory
Date: Mon, 10 Jun 2024 23:53:46 -0700	[thread overview]
Message-ID: <dc9a785c-f8f1-474d-ba49-31de63dc5e8d@app.fastmail.com> (raw)
In-Reply-To: <2024061112-kilogram-poker-bacf@gregkh>

On Mon, Jun 10, 2024 at 11:49 PM, Greg Kroah-Hartman wrote:
> Some editors (like the vim variants), when seeing "trim_whitespace"
> decide to do just that for all of the whitespace in the file you are
> saving, even if it is not on a line that you have modified.  This plays
> havoc with diffs and is NOT something that should be intended.

If trim_trailing_whitespace is the only rule that has actually been a problem,
how about removing it and leaving the rest of .editorconfig intact?
The other rules are still useful to have as defaults.

Thanks,
Danny

>
> As the "only trim whitespace on modified files" is not part of the
> editorconfig standard, just move the whole thing off to the
> Documentation/ directory so that those that wish to use such a thing can
> pick it up from there.
>
> Cc: Danny Lin <danny@kdrag0n.dev>
> Cc: Íñigo Huguet <ihuguet@redhat.com>
> Cc: Mickaël Salaün <mic@digikod.net>
> Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  .editorconfig => Documentation/.editorconfig | 0
>  1 file changed, 0 insertions(+), 0 deletions(-)
>  rename .editorconfig => Documentation/.editorconfig (100%)
>
> diff --git a/.editorconfig b/Documentation/.editorconfig
> similarity index 100%
> rename from .editorconfig
> rename to Documentation/.editorconfig
> -- 
> 2.45.2

  reply	other threads:[~2024-06-11  6:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  6:49 [PATCH] .editorconfig: move to Documentation/ directory Greg Kroah-Hartman
2024-06-11  6:53 ` Danny Lin [this message]
2024-06-11  7:26   ` Greg Kroah-Hartman
2024-06-11  7:56   ` Vincent MAILHOL

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dc9a785c-f8f1-474d-ba49-31de63dc5e8d@app.fastmail.com \
    --to=danny@kdrag0n.dev \
    --cc=gregkh@linuxfoundation.org \
    --cc=ihuguet@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=masahiroy@kernel.org \
    --cc=mic@digikod.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox