From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40F21C77B7F for ; Fri, 19 May 2023 07:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229701AbjESHKP (ORCPT ); Fri, 19 May 2023 03:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229504AbjESHKN (ORCPT ); Fri, 19 May 2023 03:10:13 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A85BE4A; Fri, 19 May 2023 00:10:11 -0700 (PDT) Received: from dggpemm500002.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QMyY40KWHzqSZG; Fri, 19 May 2023 15:05:44 +0800 (CST) Received: from [10.174.178.247] (10.174.178.247) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Fri, 19 May 2023 15:10:06 +0800 Subject: Re: [PATCH 3/3] Documentation/arm64: Update ACPI tables from BBR To: Robin Murphy , Jose Marinho CC: Catalin Marinas , Jeremy Linton , James Morse , Rob Herring , Will Deacon , Jonathan Corbet , , , , Samer El-Haj-Mahmoud References: <20230518105202.451739-1-jose.marinho@arm.com> <20230518105202.451739-4-jose.marinho@arm.com> <0969894f-d653-482c-f043-2a085ee3b404@huawei.com> From: Hanjun Guo Message-ID: Date: Fri, 19 May 2023 15:10:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.178.247] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On 2023/5/18 21:40, Robin Murphy wrote: > On 2023-05-18 13:07, Hanjun Guo wrote: >> Hi Jose, >> >> On 2023/5/18 18:52, Jose Marinho wrote: >>> The BBR specification requires (or conditionally requires) a set of ACPI >>> tables for a proper working system. >>> This commit updates: >>> - the list of ACPI tables to reflect the contents of >>> BBR version 2.0 (see https://developer.arm.com/documentation/den0044/g). >>> - the list of ACPI tables in acpi_object_usage. This last update ensures >>> that both files remain coherent. >> >> Thanks for the update, some comments inline. >> >>> >>> Signed-off-by: Jose Marinho >>> Reviewed-by: Samer El-Haj-Mahmoud >>> --- >>>   Documentation/arm64/acpi_object_usage.rst | 81 +++++++++++++++++++++-- >>>   Documentation/arm64/arm-acpi.rst          | 71 +++++++++++++++++--- >>>   2 files changed, 139 insertions(+), 13 deletions(-) >>> >>> diff --git a/Documentation/arm64/acpi_object_usage.rst >>> b/Documentation/arm64/acpi_object_usage.rst >>> index 484ef9676653..1da22200fdf8 100644 >>> --- a/Documentation/arm64/acpi_object_usage.rst >>> +++ b/Documentation/arm64/acpi_object_usage.rst >>> @@ -17,16 +17,37 @@ For ACPI on arm64, tables also fall into the >>> following categories: >>>          -  Recommended: BERT, EINJ, ERST, HEST, PCCT, SSDT >>> -       -  Optional: BGRT, CPEP, CSRT, DBG2, DRTM, ECDT, FACS, FPDT, >>> IBFT, >>> -          IORT, MCHI, MPST, MSCT, NFIT, PMTT, RASF, SBST, SLIT, >>> SPMI, SRAT, >>> -          STAO, TCPA, TPM2, UEFI, XENV >>> +       -  Optional: AGDI, BGRT, CEDT, CPEP, CSRT, DBG2, DRTM, ECDT, >>> FACS, FPDT, >>> +          HMAT, IBFT, IORT, MCHI, MPAM, MPST, MSCT, NFIT, PMTT, >>> PPTT, RASF, SBST, >>> +          SDEI, SLIT, SPMI, SRAT, STAO, TCPA, TPM2, UEFI, XENV >>> -       -  Not supported: BOOT, DBGP, DMAR, ETDT, HPET, IVRS, LPIT, >>> MSDM, OEMx, >>> -          PSDT, RSDT, SLIC, WAET, WDAT, WDRT, WPBT >>> +       -  Not supported: AEST, APMT, BOOT, DBGP, DMAR, ETDT, HPET, >>> IVRS, LPIT, >> >> AEST is ARM Error Source Table, and it can be used for ARM platforms, so >> I thinsk AEST is not belong to "Not supportted", "Optional" instead. > > Can you point to the code in Linux which does anything with AEST, > optionally or otherwise? ;) >> and APMT is the same. >> >>> +          MSDM, OEMx, PDTT, PSDT, RAS2, RSDT, SLIC, WAET, WDAT, >>> WDRT, WPBT >> >> PDTT and RAS2 are now used for ARM too, please move it to Optional :) > > Ditto; as stated in arm-acpi.rst this is Linux documentation covering > the interaction between Linux and ACPI. It is not some kind of generic Hmm, let me see... OK, I checked the arm-acpi.rst, it is saying: "Detailed expectations for ACPI tables and object are listed in the file Documentation/arm64/acpi_object_usage.rst." So if I remember correctly, it is the guidance of ACPI tables and methods usage on arm64, to align with the BBR. > ACPI-on-Arm guidance whitepaper. If and when Linux actually supports > these tables in the sense of meaningfully consuming them, that is when > we can document such support. If this is the case, we don't need categories of "Required", "Recommmened" and etc. Thanks Hanjun