From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FF301D7E31; Tue, 1 Apr 2025 17:53:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743530033; cv=none; b=iZygV3wxXVHsPHAlxzS+uwi5GTV2R5mOugWDxNzVwYZeF6S6xxm388Rw4/4FYJGj0ls7SZH96x8X3wNpxZ8IszZ3a0FcqDkaLiulhCuE15oK1pX5cIKoBvYogFQB2Va1Vc9o+DckBo2S86ei+wUDaCNwrsZIiGY2asdZSMCbPXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743530033; c=relaxed/simple; bh=QgElNOWE2Xrm08hLa6ESNpdeV4xEO0TTnynJvAUPa3M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g5DhcbBNtDRSFoegeBl8Ij4JQFLDw41PU+W7WDlojv8Mzb6FPf95CQFFE+0sYMJ5Icp4Gy6rNe+3+5z8EWJx82jg3OpPF+CVv4nFjcCl2DIO5aMrsQQnD5ou4N0vvb61hQd2AAeRjTrK8f7ZWmejO9MHOMmzAG/8pw0Dt77CXWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NEvst232; arc=none smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NEvst232" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-30362ee1312so10300491a91.0; Tue, 01 Apr 2025 10:53:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1743530029; x=1744134829; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=JAMVOcHUHUp9NIh99z5L1mUQFRtZqcxl3Eb+q823hSk=; b=NEvst232mHzG/mr8ORykXKsbF1ZuJn6ecDh35gnolIWqq4tMxZB1Ixv8AjC/+Id/V1 xKP/dNEbNt4+mIArw3TNmqvveHM4trdeUth4DSeoWyVTD2+eZlClOs/+MM1LQK1h2D9u vo9+R1bvYjmMflXMy+d2Ku1XZaiTgx7LZ6OflYMQbgk/lU0Jfe2gvrX8NMdFQXw5bOt0 e33O9vTTMY2P49orBwLSY06S4aMn9U3NMHrG6Uix6S0q0fA0qkzZTKrLuv/BJ79htVss zyByxuY6N9LGsx+yYVQaIvVnohdKDJTxuy2ZnhkOeC2EVHmF0SIM8QThhc+ioVUmDwjB 8SEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743530029; x=1744134829; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JAMVOcHUHUp9NIh99z5L1mUQFRtZqcxl3Eb+q823hSk=; b=TMZM2QPrwzD9M03A3P9gz2TAkck2bc10dRUV+/wWa7xhiTdrGOciZ19N6NacSebFkQ Xwu6+YdHFj6oBcFguDm7uth0aEO/JLKtKL1RDWIdlgttPgrPYYscmonVCFaRPmpZQdpH YFCcG2GQRaEoPVf6bhdo2enEQJMy8NRweRktSPwkZXGDkdLXnRTnhnT3PYFssIHzEZky CCSlqjhA7FCiOrvTqrDEE3CtD4vERMkL0FHn7hbjqjVTP8NSNotuu+CpuEAjg/tBNlyd g5CBPs4K2aEKZfUJoB91kMRvsUQn5DxY023rN3V4tLGGNfIe4ye/cuwmmQJ9XaiLQ/Y0 xQbA== X-Forwarded-Encrypted: i=1; AJvYcCWIoU238vRPZWkbfoMrJ69L0Kir9JyDlfBIP7o41//iFMAAa/+Szxr1pZHFqhSHbjnNhmuHNoT0Ksv+@vger.kernel.org, AJvYcCWRd4WnYS3LPYKlVZJjWjPZ8IC2Ea78c8mnAT/urQFyOlBMVUJ6afGGRM1LkTG0Th2YADh0nzQTC14Ncw==@vger.kernel.org, AJvYcCWWUycXe81VqaviExpFeD0HNqEGm5WW8/gLN/LUG58KU1DRVa7i6bPBDNfQ3Tsen5Q5svFnnFUB1vOX+sYn@vger.kernel.org, AJvYcCWhmP+KDQBImLzTk6f3A04Loru6+ddJQx4WIW2VXLnju765ybNBJSSgTvMUNMvLAzvO75Grna4yqwiQqpi9@vger.kernel.org, AJvYcCWvs/81vN/U44dU2tWcXg7IPk1jFz7t3URC9BcbTFpdwGE+DlnwluwKlyiKI4AknMtr65A1DYeEw+xP@vger.kernel.org, AJvYcCXBOd2cpotLlrj/DXkZdEbgZXPShDEIcumNHCKQA/M/DeDEuqXwtScbf82sUtmg3wpm7vO5gtswSrA=@vger.kernel.org X-Gm-Message-State: AOJu0YzSG2NxYmQjb+3XRD8q5RRvI8zhnZIxdKqs/wz6EEiusT23V4f6 q1PIAnKphZmU3mx4PpsU8QjtQQQ1EEdxkX4KmMWbbXwrFuqQh5t9tgPN1A== X-Gm-Gg: ASbGnctbgxdjkcipEvDatxqATOi3/Rpq2u/mC5uV72DeOQ6kSyoJO7McHEjvwllceoE izQUyLwsokeh/q2vcs8RMs52ReWEVzh43say2ekqZ6JMPrs0g6m6x0TSVnfv/bUKNv3aPib/MTu xtqsbEGUAtNC/DR3G9TwdxRSEIUCLZcXhjxpWd3xAxSfDHUxW29stPtQpYFz0O9Qx5b6kBuHWxQ YDPZOifolJR65yPveGTd0Ych2V65tKzZ8VrEbZf8bZKfHr8zLTA8hJp+f+ATJpVT4BX/GN9MTPD 0itsD67TLMHY7O/fkDBi18LRnlidsR81ShUm55RZYVGVrcRLChNPRSGO66ryQ6RB8gUqa1Gob4e RiYah4I9epAZ3q01+Hg== X-Google-Smtp-Source: AGHT+IFhOMd4yd6M+FWAK5Hy8goXBks0rAj4TVyMNP7GV5VDf1+ABmWCHzxIltBfqT7LAbEN+HeHUw== X-Received: by 2002:a17:90b:1d48:b0:2fe:b774:3ec8 with SMTP id 98e67ed59e1d1-305321471fcmr18084239a91.23.1743530029346; Tue, 01 Apr 2025 10:53:49 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-30516d62c57sm9624079a91.28.2025.04.01.10.53.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 10:53:48 -0700 (PDT) Sender: Guenter Roeck Message-ID: Date: Tue, 1 Apr 2025 10:53:46 -0700 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/14] x86: Add support for suppressing warning backtraces To: Peter Zijlstra , Alessandro Carminati Cc: linux-kselftest@vger.kernel.org, David Airlie , Arnd Bergmann , =?UTF-8?Q?Ma=C3=ADra_Canal?= , Dan Carpenter , Kees Cook , Daniel Diaz , David Gow , Arthur Grillo , Brendan Higgins , Naresh Kamboju , Maarten Lankhorst , Andrew Morton , Maxime Ripard , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Daniel Vetter , Thomas Zimmermann , Alessandro Carminati , Jani Nikula , dri-devel@lists.freedesktop.org, kunit-dev@googlegroups.com, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, loongarch@lists.linux.dev, x86@kernel.org, Linux Kernel Functional Testing , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen References: <20250313114329.284104-1-acarmina@redhat.com> <20250313114329.284104-7-acarmina@redhat.com> <20250401170829.GO5880@noisy.programming.kicks-ass.net> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= In-Reply-To: <20250401170829.GO5880@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/1/25 10:08, Peter Zijlstra wrote: > On Thu, Mar 13, 2025 at 11:43:21AM +0000, Alessandro Carminati wrote: >> From: Guenter Roeck >> >> Add name of functions triggering warning backtraces to the __bug_table >> object section to enable support for suppressing WARNING backtraces. >> >> To limit image size impact, the pointer to the function name is only added >> to the __bug_table section if both CONFIG_KUNIT_SUPPRESS_BACKTRACE and >> CONFIG_DEBUG_BUGVERBOSE are enabled. Otherwise, the __func__ assembly >> parameter is replaced with a (dummy) NULL parameter to avoid an image size >> increase due to unused __func__ entries (this is necessary because __func__ >> is not a define but a virtual variable). >> >> Tested-by: Linux Kernel Functional Testing >> Acked-by: Dan Carpenter >> Cc: Thomas Gleixner >> Cc: Ingo Molnar >> Cc: Borislav Petkov >> Cc: Dave Hansen >> Signed-off-by: Guenter Roeck >> Signed-off-by: Alessandro Carminati >> --- >> arch/x86/include/asm/bug.h | 21 ++++++++++++++++----- >> 1 file changed, 16 insertions(+), 5 deletions(-) >> >> diff --git a/arch/x86/include/asm/bug.h b/arch/x86/include/asm/bug.h >> index e85ac0c7c039..f6e13fc675ab 100644 >> --- a/arch/x86/include/asm/bug.h >> +++ b/arch/x86/include/asm/bug.h >> @@ -35,18 +35,28 @@ >> >> #ifdef CONFIG_DEBUG_BUGVERBOSE >> >> +#ifdef CONFIG_KUNIT_SUPPRESS_BACKTRACE >> +# define HAVE_BUG_FUNCTION >> +# define __BUG_FUNC_PTR __BUG_REL(%c1) >> +# define __BUG_FUNC __func__ >> +#else >> +# define __BUG_FUNC_PTR >> +# define __BUG_FUNC NULL >> +#endif /* CONFIG_KUNIT_SUPPRESS_BACKTRACE */ >> + >> #define _BUG_FLAGS(ins, flags, extra) \ >> do { \ >> asm_inline volatile("1:\t" ins "\n" \ >> ".pushsection __bug_table,\"aw\"\n" \ >> "2:\t" __BUG_REL(1b) "\t# bug_entry::bug_addr\n" \ >> "\t" __BUG_REL(%c0) "\t# bug_entry::file\n" \ >> - "\t.word %c1" "\t# bug_entry::line\n" \ >> - "\t.word %c2" "\t# bug_entry::flags\n" \ >> - "\t.org 2b+%c3\n" \ >> + "\t" __BUG_FUNC_PTR "\t# bug_entry::function\n" \ >> + "\t.word %c2" "\t# bug_entry::line\n" \ >> + "\t.word %c3" "\t# bug_entry::flags\n" \ >> + "\t.org 2b+%c4\n" \ >> ".popsection\n" \ >> extra \ >> - : : "i" (__FILE__), "i" (__LINE__), \ >> + : : "i" (__FILE__), "i" (__BUG_FUNC), "i" (__LINE__),\ >> "i" (flags), \ >> "i" (sizeof(struct bug_entry))); \ >> } while (0) >> @@ -92,7 +102,8 @@ do { \ >> do { \ >> __auto_type __flags = BUGFLAG_WARNING|(flags); \ >> instrumentation_begin(); \ >> - _BUG_FLAGS(ASM_UD2, __flags, ANNOTATE_REACHABLE(1b)); \ >> + if (!KUNIT_IS_SUPPRESSED_WARNING(__func__)) \ >> + _BUG_FLAGS(ASM_UD2, __flags, ANNOTATE_REACHABLE(1b)); \ >> instrumentation_end(); \ >> } while (0) > > NAK, this grows the BUG site for now appreciable reason. Only if CONFIG_KUNIT_SUPPRESS_BACKTRACE is enabled. Why does that warrant a NACK ? Guenter