From: Bart Van Assche <bvanassche@acm.org>
To: Rong Tao <rtoax@foxmail.com>, martin.petersen@oracle.com
Cc: rongtao@cestc.cn, Jonathan Corbet <corbet@lwn.net>,
"open list:SCSI TARGET SUBSYSTEM" <linux-scsi@vger.kernel.org>,
"open list:SCSI TARGET SUBSYSTEM" <target-devel@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Mike Christie <michael.christie@oracle.com>
Subject: Re: [PATCH] docs: target: Convert tcm_mod_builder.py print syntax to python3
Date: Wed, 21 Jun 2023 08:41:58 -0700 [thread overview]
Message-ID: <debdc47a-c377-e457-5643-415d93ced54a@acm.org> (raw)
In-Reply-To: <tencent_F3895D0EA868BCCE8C56221619BC093D660A@qq.com>
On 6/21/23 00:33, Rong Tao wrote:
> diff --git a/Documentation/target/tcm_mod_builder.py b/Documentation/target/tcm_mod_builder.py
> index 54492aa813b9..e2ef72925de3 100755
> --- a/Documentation/target/tcm_mod_builder.py
> +++ b/Documentation/target/tcm_mod_builder.py
> @@ -20,7 +20,7 @@ fabric_mod_port = ""
> fabric_mod_init_port = ""
>
> def tcm_mod_err(msg):
> - print msg
> + print(msg)
> sys.exit(1)
How about deleting the file Documentation/target/tcm_mod_builder.py? I
don't think anyone is using this script. Additionally, it takes effort
to keep this script in sync with the rest of the SCSI target code. I'm
not sure anyone is interested in maintaining this script.
Thanks,
Bart.
next prev parent reply other threads:[~2023-06-21 15:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 7:33 [PATCH] docs: target: Convert tcm_mod_builder.py print syntax to python3 Rong Tao
2023-06-21 15:41 ` Bart Van Assche [this message]
2023-06-25 0:53 ` Rong Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=debdc47a-c377-e457-5643-415d93ced54a@acm.org \
--to=bvanassche@acm.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=rongtao@cestc.cn \
--cc=rtoax@foxmail.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).