From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="WGu4YqHA" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24687172B for ; Thu, 30 Nov 2023 19:49:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701402555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IO8CL2qjeIUr0LsYwreVkjK8516DQtyOeewHK7H786o=; b=WGu4YqHA2ly7lIBRb5cmtWLi5WqsiTeGBSOgibj+nx4++AXyK7ZsEtv2GYNHC2kyyWjipB yfENv9zdCkglh41tmGkeQTVkU716gjXy1Imt0DaVvIn14xh4uR/2vgPO83XBmn2z/DmeoP bx0ooj+aQf6f1CAztnw2y3tD3Gym1HY= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-AZ9l8HcsMWOwwtjAoOyPMw-1; Thu, 30 Nov 2023 22:49:13 -0500 X-MC-Unique: AZ9l8HcsMWOwwtjAoOyPMw-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1d04d286b5cso1717555ad.0 for ; Thu, 30 Nov 2023 19:49:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701402552; x=1702007352; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IO8CL2qjeIUr0LsYwreVkjK8516DQtyOeewHK7H786o=; b=PF7Fie2ji4r849u1lhLeZlY36TMCtn82fzpXcqvKS7wyPTmi4I2x9wRJkjukYCImRR c/cDsYgUNXI35PyyR8VGQmHhdD7W8uQMO4MubbEQaI1c+hrNuAKqjfzScgCBknI8YMv2 ewCe5Oo4Ops1VxkUsdjafub3w1i21C9PKousUEqVVh+qIGG7EzaDWMJtIP+7q6D4SkVN vVp92Hmq2i0tVxJ/myVbpTjosXrKO0bmESyIt7R/b3htJZaX1PDVNvLCXB09iT3caQrk +bKqUGrQkBv9l65YwBUelnZ+8enJfzckLS817SdHyf4xMqk9tI0zLVCs8rzX9fzHVHOF c/MA== X-Gm-Message-State: AOJu0YxF7upPZAMyfG8gglAFgG7fqFme19E6l4HYlqWLiKA+ePO2PRSv Wal7IcOr6QEuW4UscA6ZzNjsLsUi30zP/5PQYDtqHY35oReurE5T1Cdp0s8BZq88bLCKu4vcnXX Ora0CynLWTLJpfC7HDBlJ X-Received: by 2002:a17:902:e80e:b0:1cf:daca:2b5e with SMTP id u14-20020a170902e80e00b001cfdaca2b5emr17322861plg.38.1701402552348; Thu, 30 Nov 2023 19:49:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IHVVbr2zUe8qqYTBkmHgB1fO8oP/OS0GFEHLzxacC4remFDnJNuIkfv1IWdcQ4cpeu8xrZWrg== X-Received: by 2002:a17:902:e80e:b0:1cf:daca:2b5e with SMTP id u14-20020a170902e80e00b001cfdaca2b5emr17322834plg.38.1701402551963; Thu, 30 Nov 2023 19:49:11 -0800 (PST) Received: from [192.168.68.51] ([43.252.115.3]) by smtp.gmail.com with ESMTPSA id p5-20020a170902e74500b001cfc1a593f7sm2185691plf.217.2023.11.30.19.49.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Nov 2023 19:49:11 -0800 (PST) Message-ID: Date: Fri, 1 Dec 2023 14:49:03 +1100 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 11/21] drivers: base: Print a warning instead of panic() when register_cpu() fails Content-Language: en-US To: "Russell King (Oracle)" , linux-pm@vger.kernel.org, loongarch@lists.linux.dev, linux-acpi@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, kvmarm@lists.linux.dev, x86@kernel.org, linux-csky@vger.kernel.org, linux-doc@vger.kernel.org, linux-ia64@vger.kernel.org, linux-parisc@vger.kernel.org Cc: Salil Mehta , Jean-Philippe Brucker , jianyong.wu@arm.com, justin.he@arm.com, James Morse , Greg Kroah-Hartman , "Rafael J. Wysocki" , Paul Walmsley , Palmer Dabbelt , Albert Ou References: From: Gavin Shan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/22/23 00:44, Russell King (Oracle) wrote: > From: James Morse > > loongarch, mips, parisc, riscv and sh all print a warning if > register_cpu() returns an error. Architectures that use > GENERIC_CPU_DEVICES call panic() instead. > > Errors in this path indicate something is wrong with the firmware > description of the platform, but the kernel is able to keep running. > > Downgrade this to a warning to make it easier to debug this issue. > > This will allow architectures that switching over to GENERIC_CPU_DEVICES > to drop their warning, but keep the existing behaviour. > > Signed-off-by: James Morse > Reviewed-by: Russell King (Oracle) > Reviewed-by: Shaoqin Huang > Signed-off-by: Russell King (Oracle) > --- > drivers/base/cpu.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Gavin Shan