From: Randy Dunlap <rdunlap@infradead.org>
To: "Mario Limonciello" <superm1@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
Jonathan Corbet <corbet@lwn.net>, Huang Rui <ray.huang@amd.com>,
"Gautham R . Shenoy" <gautham.shenoy@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"open list:AMD HETERO CORE HARDWARE FEEDBACK DRIVER"
<platform-driver-x86@vger.kernel.org>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list:AMD PSTATE DRIVER" <linux-pm@vger.kernel.org>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Subject: Re: [PATCH v10 04/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver
Date: Thu, 15 May 2025 14:22:56 -0700 [thread overview]
Message-ID: <e0e6a6cb-3b73-471f-97f8-415fd6ac5333@infradead.org> (raw)
In-Reply-To: <20250515211950.3102922-5-superm1@kernel.org>
just a coding style nit:
On 5/15/25 2:19 PM, Mario Limonciello wrote:
> diff --git a/drivers/platform/x86/amd/hfi/Kconfig b/drivers/platform/x86/amd/hfi/Kconfig
> new file mode 100644
> index 0000000000000..476e4a9ed67a9
> --- /dev/null
> +++ b/drivers/platform/x86/amd/hfi/Kconfig
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +#
> +# AMD Hardware Feedback Interface Driver
> +#
> +
> +config AMD_HFI
> + bool "AMD Hetero Core Hardware Feedback Driver"
> + depends on ACPI
> + depends on CPU_SUP_AMD
> + help
> + Select this option to enable the AMD Heterogeneous Core Hardware
> + Feedback Interface. If selected, hardware provides runtime thread
> + classification guidance to the operating system on the performance and
> + energy efficiency capabilities of each heterogeneous CPU core. These
> + capabilities may vary due to the inherent differences in the core types
> + and can also change as a result of variations in the operating
> + conditions of the system such as power and thermal limits.
Help text should be indented with one tab + 2 spaces.
--
~Randy
next prev parent reply other threads:[~2025-05-15 21:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 21:19 [PATCH v10 00/13] Add support for AMD hardware feedback interface Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 01/13] Documentation: x86: Add AMD Hardware Feedback Interface documentation Mario Limonciello
2025-05-15 23:13 ` Randy Dunlap
2025-05-15 21:19 ` [PATCH v10 02/13] MAINTAINERS: Add maintainer entry for AMD Hardware Feedback Driver Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 03/13] x86/msr-index: define AMD heterogeneous CPU related MSR Mario Limonciello
2025-05-16 8:46 ` Ingo Molnar
2025-05-15 21:19 ` [PATCH v10 04/13] platform/x86: hfi: Introduce AMD Hardware Feedback Interface Driver Mario Limonciello
2025-05-15 21:22 ` Randy Dunlap [this message]
2025-05-15 21:19 ` [PATCH v10 05/13] platform/x86: hfi: parse CPU core ranking data from shared memory Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 06/13] platform/x86: hfi: init per-cpu scores for each class Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 07/13] platform/x86: hfi: add online and offline callback support Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 08/13] platform/x86: hfi: add power management callback Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 09/13] x86/process: Clear hardware feedback history for AMD processors Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 10/13] cpufreq/amd-pstate: Disable preferred cores on designs with workload classification Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 11/13] platform/x86/amd: hfi: Set ITMT priority from ranking data Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 12/13] platform/x86/amd: hfi: Add debugfs support Mario Limonciello
2025-05-15 21:19 ` [PATCH v10 13/13] x86/itmt: Add debugfs file to show core priorities Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0e6a6cb-3b73-471f-97f8-415fd6ac5333@infradead.org \
--to=rdunlap@infradead.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=gautham.shenoy@amd.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=perry.yuan@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=superm1@kernel.org \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).