* [PATCH] Documentation: ipmb: Indent boot time loading steps
@ 2025-11-05 12:54 Bagas Sanjaya
2025-11-10 23:38 ` Bagas Sanjaya
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2025-11-05 12:54 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linux Documentation,
openipmi-developer
Cc: Corey Minyard, Jonathan Corbet, Bagas Sanjaya
Steps for loading IPMB driver at boot time, written as enumerated
sublist, is indented instead on the same level as its parent list.
Indent them as appropriate.
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
Documentation/driver-api/ipmb.rst | 48 +++++++++++++++----------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/Documentation/driver-api/ipmb.rst b/Documentation/driver-api/ipmb.rst
index 209c49e051163f..dd99d034272b7e 100644
--- a/Documentation/driver-api/ipmb.rst
+++ b/Documentation/driver-api/ipmb.rst
@@ -48,35 +48,35 @@ CONFIG_IPMB_DEVICE_INTERFACE=y
1) If you want the driver to be loaded at boot time:
-a) Add this entry to your ACPI table, under the appropriate SMBus::
+ a) Add this entry to your ACPI table, under the appropriate SMBus::
- Device (SMB0) // Example SMBus host controller
- {
- Name (_HID, "<Vendor-Specific HID>") // Vendor-Specific HID
- Name (_UID, 0) // Unique ID of particular host controller
- :
- :
- Device (IPMB)
- {
- Name (_HID, "IPMB0001") // IPMB device interface
- Name (_UID, 0) // Unique device identifier
- }
- }
+ Device (SMB0) // Example SMBus host controller
+ {
+ Name (_HID, "<Vendor-Specific HID>") // Vendor-Specific HID
+ Name (_UID, 0) // Unique ID of particular host controller
+ :
+ :
+ Device (IPMB)
+ {
+ Name (_HID, "IPMB0001") // IPMB device interface
+ Name (_UID, 0) // Unique device identifier
+ }
+ }
-b) Example for device tree::
+ b) Example for device tree::
- &i2c2 {
- status = "okay";
+ &i2c2 {
+ status = "okay";
- ipmb@10 {
- compatible = "ipmb-dev";
- reg = <0x10>;
- i2c-protocol;
- };
- };
+ ipmb@10 {
+ compatible = "ipmb-dev";
+ reg = <0x10>;
+ i2c-protocol;
+ };
+ };
-If xmit of data to be done using raw i2c block vs smbus
-then "i2c-protocol" needs to be defined as above.
+ If xmit of data to be done using raw i2c block vs smbus
+ then "i2c-protocol" needs to be defined as above.
2) Manually from Linux::
base-commit: 27600b51fbc8b9a4eba18c8d88d7edb146605f3f
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] Documentation: ipmb: Indent boot time loading steps
2025-11-05 12:54 [PATCH] Documentation: ipmb: Indent boot time loading steps Bagas Sanjaya
@ 2025-11-10 23:38 ` Bagas Sanjaya
2025-11-11 1:25 ` Corey Minyard
2025-11-11 4:36 ` Randy Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2025-11-10 23:38 UTC (permalink / raw)
To: Linux Kernel Mailing List, Linux Documentation,
openipmi-developer
Cc: Corey Minyard, Jonathan Corbet, Randy Dunlap
[-- Attachment #1: Type: text/plain, Size: 243 bytes --]
On Wed, Nov 05, 2025 at 07:54:49PM +0700, Bagas Sanjaya wrote:
> Steps for loading IPMB driver at boot time, written as enumerated
> sublist, is indented instead on the same level as its parent list.
> Indent them as appropriate.
review ping
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: ipmb: Indent boot time loading steps
2025-11-05 12:54 [PATCH] Documentation: ipmb: Indent boot time loading steps Bagas Sanjaya
2025-11-10 23:38 ` Bagas Sanjaya
@ 2025-11-11 1:25 ` Corey Minyard
2025-11-11 4:36 ` Randy Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: Corey Minyard @ 2025-11-11 1:25 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: Linux Kernel Mailing List, Linux Documentation,
openipmi-developer, Jonathan Corbet, Mauro Carvalho Chehab
On Wed, Nov 05, 2025 at 07:54:49PM +0700, Bagas Sanjaya wrote:
> Steps for loading IPMB driver at boot time, written as enumerated
> sublist, is indented instead on the same level as its parent list.
> Indent them as appropriate.
I'd like to get the review of the original author, now on the CC list.
-corey
>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
> ---
> Documentation/driver-api/ipmb.rst | 48 +++++++++++++++----------------
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/driver-api/ipmb.rst b/Documentation/driver-api/ipmb.rst
> index 209c49e051163f..dd99d034272b7e 100644
> --- a/Documentation/driver-api/ipmb.rst
> +++ b/Documentation/driver-api/ipmb.rst
> @@ -48,35 +48,35 @@ CONFIG_IPMB_DEVICE_INTERFACE=y
>
> 1) If you want the driver to be loaded at boot time:
>
> -a) Add this entry to your ACPI table, under the appropriate SMBus::
> + a) Add this entry to your ACPI table, under the appropriate SMBus::
>
> - Device (SMB0) // Example SMBus host controller
> - {
> - Name (_HID, "<Vendor-Specific HID>") // Vendor-Specific HID
> - Name (_UID, 0) // Unique ID of particular host controller
> - :
> - :
> - Device (IPMB)
> - {
> - Name (_HID, "IPMB0001") // IPMB device interface
> - Name (_UID, 0) // Unique device identifier
> - }
> - }
> + Device (SMB0) // Example SMBus host controller
> + {
> + Name (_HID, "<Vendor-Specific HID>") // Vendor-Specific HID
> + Name (_UID, 0) // Unique ID of particular host controller
> + :
> + :
> + Device (IPMB)
> + {
> + Name (_HID, "IPMB0001") // IPMB device interface
> + Name (_UID, 0) // Unique device identifier
> + }
> + }
>
> -b) Example for device tree::
> + b) Example for device tree::
>
> - &i2c2 {
> - status = "okay";
> + &i2c2 {
> + status = "okay";
>
> - ipmb@10 {
> - compatible = "ipmb-dev";
> - reg = <0x10>;
> - i2c-protocol;
> - };
> - };
> + ipmb@10 {
> + compatible = "ipmb-dev";
> + reg = <0x10>;
> + i2c-protocol;
> + };
> + };
>
> -If xmit of data to be done using raw i2c block vs smbus
> -then "i2c-protocol" needs to be defined as above.
> + If xmit of data to be done using raw i2c block vs smbus
> + then "i2c-protocol" needs to be defined as above.
>
> 2) Manually from Linux::
>
>
> base-commit: 27600b51fbc8b9a4eba18c8d88d7edb146605f3f
> --
> An old man doll... just what I always wanted! - Clara
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Documentation: ipmb: Indent boot time loading steps
2025-11-05 12:54 [PATCH] Documentation: ipmb: Indent boot time loading steps Bagas Sanjaya
2025-11-10 23:38 ` Bagas Sanjaya
2025-11-11 1:25 ` Corey Minyard
@ 2025-11-11 4:36 ` Randy Dunlap
2 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2025-11-11 4:36 UTC (permalink / raw)
To: Bagas Sanjaya, Linux Kernel Mailing List, Linux Documentation,
openipmi-developer
Cc: Corey Minyard, Jonathan Corbet
On 11/5/25 4:54 AM, Bagas Sanjaya wrote:
> Steps for loading IPMB driver at boot time, written as enumerated
> sublist, is indented instead on the same level as its parent list.
> Indent them as appropriate.
>
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
LGTM. Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
> ---
> Documentation/driver-api/ipmb.rst | 48 +++++++++++++++----------------
> 1 file changed, 24 insertions(+), 24 deletions(-)
>
> diff --git a/Documentation/driver-api/ipmb.rst b/Documentation/driver-api/ipmb.rst
> index 209c49e051163f..dd99d034272b7e 100644
> --- a/Documentation/driver-api/ipmb.rst
> +++ b/Documentation/driver-api/ipmb.rst
> @@ -48,35 +48,35 @@ CONFIG_IPMB_DEVICE_INTERFACE=y
>
> 1) If you want the driver to be loaded at boot time:
>
> -a) Add this entry to your ACPI table, under the appropriate SMBus::
> + a) Add this entry to your ACPI table, under the appropriate SMBus::
>
> - Device (SMB0) // Example SMBus host controller
> - {
> - Name (_HID, "<Vendor-Specific HID>") // Vendor-Specific HID
> - Name (_UID, 0) // Unique ID of particular host controller
> - :
> - :
> - Device (IPMB)
> - {
> - Name (_HID, "IPMB0001") // IPMB device interface
> - Name (_UID, 0) // Unique device identifier
> - }
> - }
> + Device (SMB0) // Example SMBus host controller
> + {
> + Name (_HID, "<Vendor-Specific HID>") // Vendor-Specific HID
> + Name (_UID, 0) // Unique ID of particular host controller
> + :
> + :
> + Device (IPMB)
> + {
> + Name (_HID, "IPMB0001") // IPMB device interface
> + Name (_UID, 0) // Unique device identifier
> + }
> + }
>
> -b) Example for device tree::
> + b) Example for device tree::
>
> - &i2c2 {
> - status = "okay";
> + &i2c2 {
> + status = "okay";
>
> - ipmb@10 {
> - compatible = "ipmb-dev";
> - reg = <0x10>;
> - i2c-protocol;
> - };
> - };
> + ipmb@10 {
> + compatible = "ipmb-dev";
> + reg = <0x10>;
> + i2c-protocol;
> + };
> + };
>
> -If xmit of data to be done using raw i2c block vs smbus
> -then "i2c-protocol" needs to be defined as above.
> + If xmit of data to be done using raw i2c block vs smbus
> + then "i2c-protocol" needs to be defined as above.
>
> 2) Manually from Linux::
>
>
> base-commit: 27600b51fbc8b9a4eba18c8d88d7edb146605f3f
--
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-11-11 4:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-11-05 12:54 [PATCH] Documentation: ipmb: Indent boot time loading steps Bagas Sanjaya
2025-11-10 23:38 ` Bagas Sanjaya
2025-11-11 1:25 ` Corey Minyard
2025-11-11 4:36 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).