From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4E9331B10B for ; Sat, 25 Jul 2026 20:55:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785012908; cv=none; b=OpHGf5gsqRcud6viNXdTyc5rYqhx334UfGmIqsDDkWIH5ZVeIwPkzB7lESoZzKYUzY9/cPJ++hJll/9imHB5fkyAvse1+6RgtJh4u1KJxzytYuhdCYNoB4O+Ur0cEOzIAw0630vx+AK0azRbTbBhWGM1b42y2rq2Ge+PzzPjjUM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785012908; c=relaxed/simple; bh=Z/e68nc6QKQvwGRK8quiSuLi4r1Hwd7lrj1OFbny9/c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PtleQe5bjsrkLaw48N4KmWVpQdhc74o1X0c/HSS92naQLYnWnqPaLqz7RCUAPiqXcCw3WGRmFlDB1w5T07eHDHGOu99w+po4Fr32TYluUBgGMPvi+TSnkm2i5XEe7h1JIUPGSu8DcQ/qrCDJnrlYC0uNVMwHPPwKc9k0Du5C8/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=UVmaj10c; arc=none smtp.client-ip=209.85.167.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="UVmaj10c" Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-495b98b4f6aso559308b6e.2 for ; Sat, 25 Jul 2026 13:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1785012904; x=1785617704; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YH9JqQUCimPMSpXV6NW6PpXAq5f8VZcE+lJasgXweSE=; b=UVmaj10cJnKoZsrxjsj1Io8LoRnQtj37Svr0g0AdVhrtuBYaMSvJwF5xRJKA42+ktk WW1cZLbAvj0LB3GJEJVRrSF7o7qyWx8lySxxEftEMxPx8vx7tvQIYL/3ads9fTLTjXQs rts/936KCVDvEoNC20z93NbcQQsF0syAxowAr8/2cFxJSiqGJnzowwCyP6S1AGe3HR+c B+y7NwyNuwjbzncal+NLWsgXC3gPzETsQ0Yy+iRATSajo6sY4E78hDGq1R0VyLCbE7it Ad1lBnbHAE/fGm98BwNniFlK+/NaHUskHb6C6IXgIOf1LOtkwgE7Se92Xv4QMMQo6cdJ 0zmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785012904; x=1785617704; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YH9JqQUCimPMSpXV6NW6PpXAq5f8VZcE+lJasgXweSE=; b=e1G7TvASA1NT22zGQeVBtYa7hzvjk9wtknJqSkCgCRc9Ei0JVxkRwY/0FLdcG6cp4f ZVpTkVzwh2xbzj9WdJWQqPhxEvAAZvhUIM4dpnvz5xD9BEKMt2aHsljokJbpEDNda63V wZopWdJu0Pdei1O5G6j4Ia3yVB2w/BBlUzOns7jGuaPQVp451Gzh1TxxDw78G3CAS/q4 I190cyDCeqkj5AKzl5mp5CjeGDu0ymirYLfZ/yChSIrE3QBxlaKJ4t0ndid6vWBH5CzB CXOY8evhTkmIOYoTvzr5hrSAAUNHzf8IfMMS5fE62mSj++srKJTMK7jkwq6exVrHNqxD DJww== X-Forwarded-Encrypted: i=1; AHgh+Rq5kpTPDysNqoCR9BzsxSzJJU6mnjKk2oclu7uP+P5UwrBRyAkozQ0UiN5dM8P3RopqSKYCJtRxcrM=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2k9j6S9zCSHntOIQcHiZYiC5GxlS8Z/wG6JqRIYN5SqTzZoem spfL6ydO3cid+NyCrRBsZ7DSEWl8CrFvYya5WggyQhljtuF5DdPMwoocDDMsKDa1bC4= X-Gm-Gg: AR+sD10gaXxi+eXqIIpj/O9cijrfYHstr+Qwf2h1zrkQSxgkqwkG/V5O0HuFRfhuZiy EkibRlfTIlKkMnmG5CL53qYBvN/9V5AroRSXjoTDegaeikhWMNgkr5FMqxuteZeCMRMPPn6I5y4 vWB/NrFftpXYvDHAV/AIOERrbhEMaxlaXCJfj0a9RN/RZT3y69E5jNrZOZ6iA6O1xJ4N2HTj6BD O8Jlx8OJBFcbsz17+MDGrXL7zWUv/0OVmOhogxTGNVMETAyK61JWesH55HCdkm8nEr3oy7b+n/6 rnI+2EzSAbipsCu8j5+nCabIEExmwH10hqkkMK0g7rvUDhdqmT9Ofeej2d6dIkmPcYUOsTi+KAj rOCILpVDKqt9Rb98QFfaYCtzzp75cgme8/FKK0MlfsqjF0Y6uvse1tcFh9I0YT9OHIr9vsnJoG/ wkV/mku+5/UhtC4ENQzVgmc5TQ47aW6bXmDtC0tTHiCIVRkkaUtJCU X-Received: by 2002:a05:6808:c413:b0:4a3:fb6c:9adf with SMTP id 5614622812f47-4ab69fdc1c0mr3905211b6e.12.1785012904631; Sat, 25 Jul 2026 13:55:04 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:677a:56dd:37eb:cf53? ([2600:8803:e7e4:500:677a:56dd:37eb:cf53]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4ab46f5927bsm5144829b6e.9.2026.07.25.13.55.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Jul 2026 13:55:03 -0700 (PDT) Message-ID: Date: Sat, 25 Jul 2026 15:55:01 -0500 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/7] spi: dt-bindings: Add spi-device-addr peripheral property To: Janani Sunil , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Jonathan Corbet , Shuah Khan , Mark Brown , Marius Cristea , Marcus Folkesson , Kent Gustavsson Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Janani Sunil , linux-spi@vger.kernel.org, Kent Gustavsson References: <20260722-ad5529r-driver-v7-0-7781cd74ad75@analog.com> <20260722-ad5529r-driver-v7-1-7781cd74ad75@analog.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260722-ad5529r-driver-v7-1-7781cd74ad75@analog.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 7/22/26 2:54 AM, Janani Sunil wrote: > Some SPI devices support sharing a single chip select across multiple > physical chips by encoding a device address in the SPI frame itself. > Add the generic spi-device-addr property for describing these hardware > addresses. The property is placed on the SPI peripheral node and may > contain multiple addresses. > > Signed-off-by: Janani Sunil > --- > Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > index 880a9f624566..b59d047cf117 100644 > --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml > @@ -142,6 +142,13 @@ properties: > minItems: 2 > maxItems: 4 > > + spi-device-addr: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + Device addresses used when multiple peripherals share a single chip > + select. The array allows one logical peripheral to comprise multiple > + physical devices, with one address per device. "per physical device" for clarity. > + > st,spi-midi-ns: > deprecated: true > description: | > If there is nothing useful the SPI core code can do with this information, I'm not entirely convinced that this needs to be a common property. And this only allows for one logical device. If we wanted to treat each address as a logical device (all with same CS), we would need #address-cells = <2>; instead where the DT "address" is two values, the CS and the device address. This isn't a nak or request for change - just putting my thoughts out there to make sure we considered it thoroughly.