From: Krishna Kurapati PSSNV <quic_kriskura@quicinc.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Maciej Żenczykowski" <maze@google.com>,
"onathan Corbet" <corbet@lwn.net>,
"Linyu Yuan" <quic_linyyuan@quicinc.com>,
linux-usb@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_ppratap@quicinc.com,
quic_wcheng@quicinc.com, quic_jackp@quicinc.com
Subject: Re: [PATCH 2/2] usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs
Date: Mon, 9 Oct 2023 23:57:44 +0530 [thread overview]
Message-ID: <e361e3c0-069c-4e91-8f3a-d7ab2de8bdd4@quicinc.com> (raw)
In-Reply-To: <2023100910-used-unruly-f750@gregkh>
On 10/9/2023 11:24 PM, Greg Kroah-Hartman wrote:
> On Mon, Oct 09, 2023 at 09:02:32PM +0530, Krishna Kurapati PSSNV wrote:
>>
>>
>> On 10/9/2023 8:38 PM, Greg Kroah-Hartman wrote:
>>> On Mon, Oct 09, 2023 at 07:50:05PM +0530, Krishna Kurapati wrote:
>>>> Currently the NCM driver restricts wMaxSegmentSize that indicates
>>>> the datagram size coming from network layer to 1514.
>>>
>>> I don't see that restriction in the existing driver, where does that
>>> happen?
>>
>> Hi Greg,
>>
>> In the ecm_desc, the following line restricts the value:
>>
>> .wMaxSegmentSize = cpu_to_le16(ETH_FRAME_LEN),
>
> Ok, so is that 1514? I don't know as I don't know what ETH_FRAM_LEN is.
>
Hi Greg,
Yes, that is 1514.
> So how about saying something to the affect of "the max segment size is
> currently limited to the ethernet frame length of the kernel which
> happens to be 1514 at this point in time."
>
Sure. I will rephrase this in v2 with the suggestion provided.
Regards,
Krishna,
next prev parent reply other threads:[~2023-10-09 18:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 14:20 [PATCH 1/2] Documentation: usb: Update NCM configfs parameters Krishna Kurapati
2023-10-09 14:20 ` [PATCH 2/2] usb: gadget: ncm: Add support to update wMaxSegmentSize via configfs Krishna Kurapati
2023-10-09 15:08 ` Greg Kroah-Hartman
2023-10-09 15:32 ` Krishna Kurapati PSSNV
2023-10-09 17:54 ` Greg Kroah-Hartman
2023-10-09 18:27 ` Krishna Kurapati PSSNV [this message]
2023-10-10 0:17 ` Maciej Żenczykowski
2023-10-10 0:20 ` Maciej Żenczykowski
2023-10-10 0:37 ` Maciej Żenczykowski
2023-10-10 4:38 ` Krishna Kurapati PSSNV
2023-10-12 8:48 ` Krishna Kurapati PSSNV
2023-10-12 12:32 ` Maciej Żenczykowski
2023-10-12 15:40 ` Krishna Kurapati PSSNV
2023-10-13 18:39 ` Maciej Żenczykowski
2023-10-13 18:40 ` Maciej Żenczykowski
2023-10-13 19:58 ` Krishna Kurapati PSSNV
2023-10-13 22:35 ` Maciej Żenczykowski
2023-10-14 7:02 ` Krishna Kurapati PSSNV
2023-10-14 8:23 ` Krishna Kurapati PSSNV
2023-10-16 1:19 ` Maciej Żenczykowski
2023-10-16 3:48 ` Krishna Kurapati PSSNV
2023-10-10 4:34 ` Krishna Kurapati PSSNV
2023-10-10 4:27 ` Krishna Kurapati PSSNV
2023-10-10 22:26 ` kernel test robot
2023-10-09 15:05 ` [PATCH 1/2] Documentation: usb: Update NCM configfs parameters Greg Kroah-Hartman
2023-10-09 15:10 ` Krishna Kurapati PSSNV
2023-10-09 15:21 ` Greg Kroah-Hartman
2023-10-09 15:33 ` Krishna Kurapati PSSNV
2023-10-09 15:42 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e361e3c0-069c-4e91-8f3a-d7ab2de8bdd4@quicinc.com \
--to=quic_kriskura@quicinc.com \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maze@google.com \
--cc=quic_jackp@quicinc.com \
--cc=quic_linyyuan@quicinc.com \
--cc=quic_ppratap@quicinc.com \
--cc=quic_wcheng@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox