linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Akira Yokosawa <akiyks@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>,
	linux-doc@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Yury Norov <yury.norov@gmail.com>
Subject: Re: [PATCH V2 1/2] cpumask: Fix kernel-doc formatting errors in cpumask.h
Date: Fri, 7 Mar 2025 19:57:54 +0900	[thread overview]
Message-ID: <e3637b13-1f51-445b-8d9d-bd53a691eca3@gmail.com> (raw)
In-Reply-To: <f4ad81150eaa00b43c161f0d1f811f8ecfe21889.1741332579.git.viresh.kumar@linaro.org>

Hi again, 

Viresh Kumar wrote:
> This fixes various kernel-doc formatting errors in cpumask.h:
> 
> - WARNING: Inline literal start-string without end-string.
> - ERROR: Unexpected indentation.
> - ERROR: Unknown target name: "gfp".
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  include/linux/cpumask.h | 65 +++++++++++++++++++++--------------------
>  1 file changed, 34 insertions(+), 31 deletions(-)
> 

Didn't come up in your diff, but you need additional changes shown below:

diff --git a/include/linux/cpumask.h b/include/linux/cpumask.h
index 656d2208467e..a6c1961cc535 100644
--- a/include/linux/cpumask.h
+++ b/include/linux/cpumask.h
@@ -285,10 +285,10 @@ unsigned int cpumask_next_and(int n, const struct cpumask *src1p,
 }
 
 /**
- * cpumask_next_and_wrap - get the next cpu in *src1p & *src2p, starting from
- *                        @n+1. If nothing found, wrap around and start from
+ * cpumask_next_and_wrap - get the next cpu in *@src1p & *@src2p, starting from
+ *                        @n+ 1. If nothing found, wrap around and start from
  *                        the beginning
- * @n: the cpu prior to the place to search (i.e. search starts from @n+1)
+ * @n: the cpu prior to the place to search (i.e. search starts from @n +1)
  * @src1p: the first cpumask pointer
  * @src2p: the second cpumask pointer
  *
@@ -306,9 +306,9 @@ unsigned int cpumask_next_and_wrap(int n, const struct cpumask *src1p,
 }
 
 /**
- * cpumask_next_wrap - get the next cpu in *src, starting from @n+1. If nothing
+ * cpumask_next_wrap - get the next cpu in *@src, starting from @n +1. If nothing
  *                    found, wrap around and start from the beginning
- * @n: the cpu prior to the place to search (i.e. search starts from @n+1)
+ * @n: the cpu prior to the place to search (i.e. search starts from @n +1)
  * @src: cpumask pointer
  *
  * Return: next set bit, wrapped if needed, or >= nr_cpu_ids if @src is empty.

Feel free to squash into your 1/2.
My R-b tag still stands.

        Thanks, Akira


  parent reply	other threads:[~2025-03-07 11:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07  7:34 [PATCH V2 0/2] docs: core-api: Update kernel-api.rst to include cpumask.h Viresh Kumar
2025-03-07  7:34 ` [PATCH V2 1/2] cpumask: Fix kernel-doc formatting errors in cpumask.h Viresh Kumar
2025-03-07  9:02   ` Akira Yokosawa
2025-03-07 10:57   ` Akira Yokosawa [this message]
2025-03-07 11:28     ` Viresh Kumar
2025-03-07 11:20       ` Akira Yokosawa
2025-03-07 17:05   ` Yury Norov
2025-03-10  6:15     ` Viresh Kumar
2025-03-10  9:03       ` Viresh Kumar
2025-03-10  9:29         ` Akira Yokosawa
2025-03-10  9:11       ` Akira Yokosawa
2025-03-10 14:07     ` Jonathan Corbet
2025-03-10 14:43       ` Mauro Carvalho Chehab
2025-03-17  9:24     ` Viresh Kumar
2025-03-10 14:53   ` Mauro Carvalho Chehab
2025-03-10 15:27     ` Akira Yokosawa
2025-03-10 15:56       ` Mauro Carvalho Chehab
2025-03-17  8:53     ` Viresh Kumar
2025-03-07  7:34 ` [PATCH V2 2/2] docs: core-api: Update kernel-api.rst to include cpumask.h Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3637b13-1f51-445b-8d9d-bd53a691eca3@gmail.com \
    --to=akiyks@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).