From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7874F2BE65B for ; Thu, 31 Jul 2025 13:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753968031; cv=none; b=M1QIHwRAmq+H/Z4mUbIqMQzg9w4pEwOa0wGVXfR14HOQYEyk2PyQXb2fkKjST6vyEdskPhZKxIlkZyZfMzPgTIsgdt/13dXFjt6Rf2xorrFTeU3J6jp3nTg9emdo5P7+5GUxK7H2IFEr9s1u5SC93vevgfF2eMYNx96EPdRJR8k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753968031; c=relaxed/simple; bh=3KLuyMr0bSxLI5U8RI1yZL2Yv96hPijFT8J7biGE2dk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Gf60n+uGy+HmvYZL+vcIVkn1u+MXRrTSypKEB7ILkz4kAZV8rGNMJtSXplzlgZkUn7qMFvE1lU0QeDZ/CKALAf8SEvO1vrdTPXisrB0ex7dROurkm3fLcRfPhJx/3gn79+h2zK0G50VXS/F7wwbCV6BGokRyIfTVfgFTlE370fs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DgREQ4c0; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DgREQ4c0" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1753968027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=H8cVWOuIO40JfoYuCXD6TQrtJBGKCxwzWML3Rk1WtL4=; b=DgREQ4c0xYGTbts5i1jErOhsfflQx8iQK4CSYnFWNfGqp61ZOCgWH2i0b7klTP6xQ5lga7 /peE+QYhS9UoMkRhqMh4RvZPPPIpxbdegaQ0mlN2qUgZXkHrpCj1cTIiae1lrY864/Ggj9 DoznQeeqviwtoJz3YrytmFosV3MhyWc= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-562-HKXZm1PqOrWjIUe6M37BAA-1; Thu, 31 Jul 2025 09:20:26 -0400 X-MC-Unique: HKXZm1PqOrWjIUe6M37BAA-1 X-Mimecast-MFC-AGG-ID: HKXZm1PqOrWjIUe6M37BAA_1753968025 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-451d30992bcso6174065e9.2 for ; Thu, 31 Jul 2025 06:20:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753968025; x=1754572825; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=H8cVWOuIO40JfoYuCXD6TQrtJBGKCxwzWML3Rk1WtL4=; b=PYGOwNahhp15MDXnk6sQE8To87plBAoUcorasA/8joguAGGBxDwtB/h+gkrlSARX87 WOTH1RGKwxZ7rhLe8eVl2eKDuvqTqX2beFx6CAXP6HwX9wE5pJysLnkrqzvzpzM27jRD +kBUWIvH3acX+4LWaITxmc7NAx8plH1Zko85RfDhSln470Ge3egQyzAaVh5tzzhHPVPH 7iK9GaXpFq++/LDan962p0upWji6yJx+qCQbDYVoEUfE0ReEniHjeRnzadU45HNsNGFn cGzoegWtFnoDNZEVIM6zx5pOXAqb/mGNJ9HXJlKvKDao++V98IElval1yJt2aymgqRgC ms4A== X-Forwarded-Encrypted: i=1; AJvYcCV4VuQVTF4VtgJ6QEVbt71j9BIyblPcqOW05XuBGZW+tVZ2aRMlh3gkAXnkAVA344zQGw5jKsY/Q5k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw75yY7QOEF4Y4+lMUTdpv7mBImlHj9k4/D2XuIoJZjjh3DYYyD XQ/wVEseWkyJt5YcI0KPRgBJFbPDAOQyObJYGUVc56SRuQx5qYs9Q/g4pN4hNwyMP3F0VqZa/TO 066R+G0wHNWQJz7jLvmsIlgjdSRMnLrmFP+7V8ZDlEePduWpYh6h3cGYVDjabIA== X-Gm-Gg: ASbGncv3jR25H9qmX/RxGKAlcBIdZi0c37qbwG3b6okGeeV7dWCTpB1JLhpqz67OEJ7 xUrXQJW3Ot1d9IY7BLSp0Cirf0UDukNgRKlyq1SJ0sURqDSEKepvB7giK/HpWORyPhirOWew09H 7uVUlwWAw1gJLYp9ioTWDdGufmL7wbHUaN4ODE4Xs7ryvEVykOR52U4gQAQtVmqLwqX7hwLS9Ak 0x4811QITc+IIFKjngIBYo/z7s3OAEMkQ6PJBqS0ZVEmmdpEy7WtywimcWFgp9TBbhOnOyo1m/0 DK/HLHsMHDiIqPkfrTpqBuy/qrr8jjrSwxzWfdLH5TsG6+797AobpAK3LlQGM3hFsSWTtMUBcVQ 6136LmmAycd/2sEh/KjwgH89SyrOMzAq3Rtsic/90o6G8C07T17ddoNmDq8A692np+5Y= X-Received: by 2002:a05:600c:35d4:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-45892a38f57mr77121245e9.0.1753968024916; Thu, 31 Jul 2025 06:20:24 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFw7izoet6gCRjloh7faX2I/dT1hRt2aBMnfvHniM+pSH974YB03S1kXDORrNyqMh7/oaxdrw== X-Received: by 2002:a05:600c:35d4:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-45892a38f57mr77120805e9.0.1753968024404; Thu, 31 Jul 2025 06:20:24 -0700 (PDT) Received: from ?IPV6:2003:d8:2f44:3700:be07:9a67:67f7:24e6? (p200300d82f443700be079a6767f724e6.dip0.t-ipconnect.de. [2003:d8:2f44:3700:be07:9a67:67f7:24e6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-458a22365c0sm23257955e9.3.2025.07.31.06.20.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Jul 2025 06:20:23 -0700 (PDT) Message-ID: Date: Thu, 31 Jul 2025 15:20:21 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/5] prctl: extend PR_SET_THP_DISABLE to optionally exclude VM_HUGEPAGE To: Usama Arif , Lorenzo Stoakes Cc: Andrew Morton , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, corbet@lwn.net, rppt@kernel.org, surenb@google.com, mhocko@suse.com, hannes@cmpxchg.org, baohua@kernel.org, shakeel.butt@linux.dev, riel@surriel.com, ziy@nvidia.com, laoar.shao@gmail.com, dev.jain@arm.com, baolin.wang@linux.alibaba.com, npache@redhat.com, Liam.Howlett@oracle.com, ryan.roberts@arm.com, vbabka@suse.cz, jannh@google.com, Arnd Bergmann , sj@kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kernel-team@meta.com, Matthew Wilcox References: <20250731122825.2102184-1-usamaarif642@gmail.com> <20250731122825.2102184-2-usamaarif642@gmail.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 31.07.25 15:12, Usama Arif wrote: > > > On 31/07/2025 13:40, Lorenzo Stoakes wrote: >> On Thu, Jul 31, 2025 at 01:27:18PM +0100, Usama Arif wrote: >> [snip] >>> Acked-by: Usama Arif >>> Tested-by: Usama Arif >>> Cc: Jonathan Corbet >>> Cc: Andrew Morton >>> Cc: Lorenzo Stoakes >>> Cc: Zi Yan >>> Cc: Baolin Wang >>> Cc: "Liam R. Howlett" >>> Cc: Nico Pache >>> Cc: Ryan Roberts >>> Cc: Dev Jain >>> Cc: Barry Song >>> Cc: Vlastimil Babka >>> Cc: Mike Rapoport >>> Cc: Suren Baghdasaryan >>> Cc: Michal Hocko >>> Cc: Usama Arif >>> Cc: SeongJae Park >>> Cc: Jann Horn >>> Cc: Liam R. Howlett >>> Cc: Yafang Shao >>> Cc: Matthew Wilcox >> >> You don't need to include these Cc's, Andrew will add them for you. >> >>> Signed-off-by: David Hildenbrand >>> Reviewed-by: Lorenzo Stoakes >> >> Shouldn't this also be signed off by you? 2/5 and 3/5 has S-o-b for both >> David and yourself? >> >> This is inconsistent at the very least. >> > > Signed-off-by: Usama Arif > > The Ccs were added by David, and I didn't want to remove them. They were still part of the first submission without cover letter, so you should drop them from here now that you are sending it as part of a series. > >>> >>> --- >>> >> >> Nothing below the --- will be included in the patch, so we can drop the >> below, it's just noise that people can find easily if needed. >> >>> At first, I thought of "why not simply relax PR_SET_THP_DISABLE", but I >>> think there might be real use cases where we want to disable any THPs -- >>> in particular also around debugging THP-related problems, and >>> "never" not meaning ... "never" anymore ever since we add MADV_COLLAPSE. >>> PR_SET_THP_DISABLE will also block MADV_COLLAPSE, which can be very >>> helpful for debugging purposes. Of course, I thought of having a >>> system-wide config option to modify PR_SET_THP_DISABLE behavior, but >>> I just don't like the semantics. >> >> [snip] >> >>> >>> Signed-off-by: David Hildenbrand >> >> This S-o-b is weird, it's in a comment essentially. Let's drop that too >> please. That just got added automatically while modifying the patch. > > > Everything below --- was added by David I believe to provide further explanation that > doesn't need to be included in the commit message, and I didn't want to remove it > or his 2nd sign-off, as its discarded anyways. Its useful info that can just be > ignored. Best to drop under the "---" I think it was most important for the PoC to give more context. -- Cheers, David / dhildenb