From: Li Nan <linan666@huaweicloud.com>
To: Yu Kuai <yukuai1@huaweicloud.com>,
hch@infradead.org, xni@redhat.com, colyli@kernel.org,
corbet@lwn.net, agk@redhat.com, snitzer@kernel.org,
mpatocka@redhat.com, song@kernel.org, yukuai3@huawei.com,
hare@suse.de
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
dm-devel@lists.linux.dev, linux-raid@vger.kernel.org,
yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com, hailan@yukuai.org.cn
Subject: Re: [PATCH v7 md-6.18 11/11] md/md-llbitmap: introduce new lockless bitmap
Date: Thu, 4 Sep 2025 17:19:45 +0800 [thread overview]
Message-ID: <e4da9027-abb4-76d1-04df-fff9798baae1@huaweicloud.com> (raw)
In-Reply-To: <20250829080426.1441678-12-yukuai1@huaweicloud.com>
在 2025/8/29 16:04, Yu Kuai 写道:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Redundant data is used to enhance data fault tolerance, and the storage
> method for redundant data vary depending on the RAID levels. And it's
> important to maintain the consistency of redundant data.
>
> Bitmap is used to record which data blocks have been synchronized and which
> ones need to be resynchronized or recovered. Each bit in the bitmap
> represents a segment of data in the array. When a bit is set, it indicates
> that the multiple redundant copies of that data segment may not be
> consistent. Data synchronization can be performed based on the bitmap after
> power failure or readding a disk. If there is no bitmap, a full disk
> synchronization is required.
>
> Due to known performance issues with md-bitmap and the unreasonable
> implementations:
>
> - self-managed IO submitting like filemap_write_page();
> - global spin_lock
>
> I have decided not to continue optimizing based on the current bitmap
> implementation, this new bitmap is invented without locking from IO fast
> path and can be used with fast disks.
>
> For designs and details, see the comments in drivers/md-llbitmap.c.
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
LGTM
Reviewed-by: Li Nan <linan122@huawei.com>
--
Thanks,
Nan
prev parent reply other threads:[~2025-09-04 9:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 8:04 [PATCH v7 md-6.18 00/11] md/llbitmap: md/md-llbitmap: introduce a new lockless bitmap Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 01/11] md: add a new parameter 'offset' to md_super_write() Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 02/11] md: factor out a helper raid_is_456() Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 03/11] md/md-bitmap: support discard for bitmap ops Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 04/11] md: add a new mddev field 'bitmap_id' Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 05/11] md/md-bitmap: add a new sysfs api bitmap_type Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 06/11] md/md-bitmap: delay registration of bitmap_ops until creating bitmap Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 07/11] md/md-bitmap: add a new method skip_sync_blocks() in bitmap_operations Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 08/11] md/md-bitmap: add a new method blocks_synced() " Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 09/11] md: add a new recovery_flag MD_RECOVERY_LAZY_RECOVER Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 10/11] md/md-bitmap: make method bitmap_ops->daemon_work optional Yu Kuai
2025-08-29 8:04 ` [PATCH v7 md-6.18 11/11] md/md-llbitmap: introduce new lockless bitmap Yu Kuai
2025-09-04 9:19 ` Li Nan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4da9027-abb4-76d1-04df-fff9798baae1@huaweicloud.com \
--to=linan666@huaweicloud.com \
--cc=agk@redhat.com \
--cc=colyli@kernel.org \
--cc=corbet@lwn.net \
--cc=dm-devel@lists.linux.dev \
--cc=hailan@yukuai.org.cn \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=johnny.chenyi@huawei.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=xni@redhat.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).