From: "Linga, Pavan Kumar" <pavan.kumar.linga@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>, Joshua Hay <joshua.a.hay@intel.com>,
<emil.s.tantilov@intel.com>, <jesse.brandeburg@intel.com>,
<sridhar.samudrala@intel.com>, <shiraz.saleem@intel.com>,
<sindhu.devale@intel.com>, <willemb@google.com>,
<decot@google.com>, <andrew@lunn.ch>, <leon@kernel.org>,
<mst@redhat.com>, <simon.horman@corigine.com>,
<shannon.nelson@amd.com>, <stephen@networkplumber.org>,
<linux-doc@vger.kernel.org>, Alan Brady <alan.brady@intel.com>,
Madhu Chittim <madhu.chittim@intel.com>,
Phani Burra <phani.r.burra@intel.com>,
Krishneil Singh <krishneil.k.singh@intel.com>
Subject: Re: [PATCH net-next 15/15] idpf: configure SRIOV and add other ndo_ops
Date: Thu, 1 Jun 2023 16:40:34 -0700 [thread overview]
Message-ID: <e4f80b89-7804-4832-280e-3bd0c9501a3f@intel.com> (raw)
In-Reply-To: <20230531232336.3dffb14b@kernel.org>
On 5/31/2023 11:23 PM, Jakub Kicinski wrote:
> On Tue, 30 May 2023 16:45:01 -0700 Tony Nguyen wrote:
>> + struct idpf_vport *vport = idpf_netdev_to_vport(netdev);
>> +
>> + if (!vport)
>> + return;
>> +
>> + *stats = vport->netstats;
>
> How is this atomic vs the update path.
I see your point. 'vport->netstats' can go out of sync if the statistics
task updates the 'netstats' concurrently. Will guard the stats update
with a lock. Thanks for the review.
Regards,
Pavan
prev parent reply other threads:[~2023-06-01 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230530234501.2680230-1-anthony.l.nguyen@intel.com>
2023-05-30 23:45 ` [PATCH net-next 15/15] idpf: configure SRIOV and add other ndo_ops Tony Nguyen
2023-06-01 6:23 ` Jakub Kicinski
2023-06-01 23:40 ` Linga, Pavan Kumar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e4f80b89-7804-4832-280e-3bd0c9501a3f@intel.com \
--to=pavan.kumar.linga@intel.com \
--cc=alan.brady@intel.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=decot@google.com \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=joshua.a.hay@intel.com \
--cc=krishneil.k.singh@intel.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=madhu.chittim@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=phani.r.burra@intel.com \
--cc=shannon.nelson@amd.com \
--cc=shiraz.saleem@intel.com \
--cc=simon.horman@corigine.com \
--cc=sindhu.devale@intel.com \
--cc=sridhar.samudrala@intel.com \
--cc=stephen@networkplumber.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).