From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mta1.migadu.com (out-129.mta1.migadu.com [95.215.58.129]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E17543AFAE6 for ; Wed, 2 Sep 2026 19:49:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.129 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788378545; cv=none; b=olTYDQVxOR2iMfWbHWLXbP7GDe+UGY98zIFWpkSXjLl0VUf4hzPxYggct4VEvsutz3itaIZmveOIAtf83Z8DqzAhlAnhq7hry72tnk+1rqgjfD4oeggQPMovUoGgTnbhjcWBQRgmS2gQT/tIDhBgk5lrpHSzV67x9JUswMv2haU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788378545; c=relaxed/simple; bh=q6Ch4vtqSG74hj505wHaVPu00x50jG6mrrZuNCQcrB8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lpT52xJmf1689I4/N67V6FJxZgDaNQoA5OSPJKkbrwpkuDQrqX5NeByxzWpP9zYsyHC/6/Q50HZUbvCb87v6p0WvmpH5MKRdxNn7+ie1aRsa7egT80l0MpEAwg6Q34Qf97daDCRU7V2HIeas+mvMRH7JygpMCM82o4tuWN8/POY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=DXRXaLXt; arc=none smtp.client-ip=95.215.58.129 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="DXRXaLXt" X-Envelope-To: linux-doc@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=q6Ch4vtqSG74hj505wHaVPu00x50jG6mrrZuNCQcrB8=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1788378533; v=1; x=1788983333; b=DXRXaLXtnNf+dJIDkxzKPBWPVoCitMfr0+9PuwEgW88GEbH2K7Ya/2dBSOFioyMPwLP6ISAG YgRy61jcWSJjnwtD4OEmqhro0e4wQk26IShlm3Queeh/5rtSCngxOKLtR8dmSRBJaayzT5680Eo gTxd5EEqbDlggkVwXyCOrNGY= X-Envelope-To: linux-doc@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 9af95a88ea923d85; Wed, 02 Sep 2026 19:48:43 +0000 X-Mizu-Trace-ID: 9af95a88ea923d85 X-Migadu-Flow: FLOW_OUT Message-ID: Date: Wed, 2 Sep 2026 21:48:39 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [v2 for-next 1/3] block: reject unknown status tags in error injection rules To: Christoph Hellwig Cc: Jens Axboe , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Keith Busch , Jonathan Corbet , linux-doc@vger.kernel.org References: <20260830012002.80275-1-haris.iqbal@linux.dev> <20260830012002.80275-2-haris.iqbal@linux.dev> <20260902135800.GA22743@lst.de> Content-Language: en-US From: Haris Iqbal In-Reply-To: <20260902135800.GA22743@lst.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/2/26 15:58, Christoph Hellwig wrote: > On Sun, Aug 30, 2026 at 03:20:00AM +0200, Md Haris Iqbal wrote: >> tag_to_blk_status() returns BLK_STS_OK both for the "OK" tag and for a >> tag it does not recognise, so a caller cannot tell the two apart. >> match_status() leaves *status at BLK_STS_OK for an unknown tag and relies >> on error_inject_add() rejecting BLK_STS_OK. > > There is no *status yet. Ah yes. I'll correct it. > >> That holds only while a rule without a status is meaningless. The delay > > This reads a lot like AI slop. Can you please self-write a short and > descriptive commit message? My bad. I'll correct it. > >> - * Return BLK_STS_OK for mismatches as this function is intended to >> - * parse error status values. >> - */ >> - return BLK_STS_OK; >> + return -EINVAL; > > No need for an int return here, this can easily be done with a bool. True. I'll change it. I'll wait for your comments for the other patches before sending a v3.