From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Jonathan Corbet <corbet@lwn.net>,
Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Cc: Randy Dunlap <rdunlap@infradead.org>,
kernel@collabora.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: document linked lists
Date: Thu, 3 Jul 2025 09:54:02 +0700 [thread overview]
Message-ID: <e5c2ead0-7f8e-44e6-9af7-8addf7b7d016@gmail.com> (raw)
In-Reply-To: <87h5zum1ei.fsf@trenco.lwn.net>
On 7/3/25 09:52, Jonathan Corbet wrote:
> Bagas Sanjaya <bagasdotme@gmail.com> writes:
>
>> On Wed, Jul 02, 2025 at 10:24:47PM +0200, Nicolas Frattaroli wrote:
>>> +In State 2, we've added Grock after the list head::
>>> +
>>> + .--------------------.
>>> + v |
>>> + .--------. .-------. |
>>> + | clowns |---->| Grock |--'
>>> + '--------' '-------'
>>
>> Looks like the corners are a bit imbalanced (single quotes are taller than
>> dots). What about using plus instead? Like:
>>
>> ---- >8 ----
>> diff --git a/Documentation/core-api/list.rst b/Documentation/core-api/list.rst
>> index b0586056abb04d..bf92f44d7b2d06 100644
>> --- a/Documentation/core-api/list.rst
>> +++ b/Documentation/core-api/list.rst
>> @@ -148,11 +148,11 @@ clarity.
>>
>> In State 2, we've added Grock after the list head::
>>
>> - .--------------------.
>> + +--------------------+
>> v |
>
> One might argue that it looks like a nice curve and should stay as-is.
>
> This work is welcome and deserves a serious review, this wasn't it.
>
OK, thanks!
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2025-07-03 2:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-02 20:24 [PATCH v2] docs: document linked lists Nicolas Frattaroli
2025-07-03 1:37 ` Bagas Sanjaya
2025-07-03 2:52 ` Jonathan Corbet
2025-07-03 2:54 ` Bagas Sanjaya [this message]
2025-07-03 3:24 ` Bagas Sanjaya
2025-07-03 4:16 ` Randy Dunlap
2025-07-03 5:48 ` Bagas Sanjaya
2025-07-03 6:06 ` Randy Dunlap
2025-07-03 6:39 ` Bagas Sanjaya
2025-07-03 6:55 ` Randy Dunlap
2025-07-03 14:10 ` Jonathan Corbet
2025-07-04 20:53 ` Randy Dunlap
2025-07-07 9:11 ` David Laight
2025-07-07 12:30 ` Nicolas Frattaroli
2025-07-13 7:08 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5c2ead0-7f8e-44e6-9af7-8addf7b7d016@gmail.com \
--to=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=kernel@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.frattaroli@collabora.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox