From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B50842DBF48 for ; Wed, 2 Jul 2025 15:25:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751469947; cv=none; b=tsdkyPYRu6XhPPbE87wS4RWz39ffCmTYHNC/uj2ow0A6AIWKoiczEPaMaO02RJiEaCGXbmWOycItaUE0nX+exOz8P3AsNnKWe5AcsIId+TJKdtIBTFRvB7IgdEkthpq3u8rC083Y+17iAXr7EshhuVIst2QLLgIRjQWM82ArDDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751469947; c=relaxed/simple; bh=ozAq4H7NKMi99W0DR+dgxSwDGggAfgQwOjbIsAOjbpo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CU769YsfJrBoXOYm3LeoIRQxTN2cUvBa1nqkXDZWDAmJbM2vHhZiXcnWhMEKfUcYWQw5ZqGKOVyNufgL83DyrS61rLkl7miHFL5MLBdJ1tP9MbQVqD0LDsQ4FrLLL9/XyV/apgqa+IHb5VwBpbv5NlYsp8SR4g3L8GqqIm9bGfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bn1K/m0P; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bn1K/m0P" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751469944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=1zZV1K34K5vsU5bBEYqLthbNyfG8BgJV/i5Welf7t/g=; b=Bn1K/m0PU2U3QSPaMiHDZ9IEss70sP4dyQo4AqGCa2DIdZPw/BydGbJ10nCodpn103KH03 L5f6F+VWaJ2ilXVktUADQx9RXOuakOluJM7WppwrFEQnYdTwVstNENYyw+ylX4uDPjvTsx IhcWTw6S1PxNjCZwOVRx+RrtgmOkm4g= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-ZfMyvK0uP22u8EQMncs_gg-1; Wed, 02 Jul 2025 11:25:43 -0400 X-MC-Unique: ZfMyvK0uP22u8EQMncs_gg-1 X-Mimecast-MFC-AGG-ID: ZfMyvK0uP22u8EQMncs_gg_1751469942 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4530c186394so20560325e9.0 for ; Wed, 02 Jul 2025 08:25:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751469942; x=1752074742; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=1zZV1K34K5vsU5bBEYqLthbNyfG8BgJV/i5Welf7t/g=; b=DyxO9UdOJzCg3JuCnzO7gFktmxVfWE20G2yynblr+p+gJ7D1guPuaW8VEbw+cnYS4b Oaoq6wLKRQgC7vSL5+H9cuvq/utk1G3y8/U06dbEkSg0QB5wIKi/fRmPxOYoL9BzNb7+ 0/Y7RRsWcO2TrX3Vd87uYexPUDRTSDD04DfCxq1vUR7mM3CBKTUPPojt19gkCzpzjn5e YxmrXfgv1AUoEDcwvyY+vWrd1e6mU+QuUBs6UboXBum31d+AGL8CIep3qHwscUFGDaKw 0jst1WEjhQF6bxrGwg86DfHwHY4MmR5U7dXvWfdsu/DBFpr1wmWUpI3uyyr8gnTV0g4a UBgw== X-Forwarded-Encrypted: i=1; AJvYcCWw3y5eR6ZFWHeWQ0K391L/ZZAlCj+sbeqNGHz7dpAErYup7u1y2IbPj6eBlJBwCkn3n97/URi0flM=@vger.kernel.org X-Gm-Message-State: AOJu0YwhS/55oFH+wAu6RBIqJXxjc7UsioqSPNAVnmkrZBiEkQgo5wqv Oauof+pCfjMnncEckuBktPb15QbVZwi0zjCNAFNKtZLH/o3l88Nv/Uf4hBVuPdQSDuTgyfh8k1a heHYQgGI6KzeaWlqCsfUM+AaKhGCVaY+VtxHoIt1IPLmeDCcrV8jry2sjdP9hNg== X-Gm-Gg: ASbGncsdSk1u509amSQrp3Yj5iNTfFyg36/qInR7Zw+S+yA8K+d0BLaZi71pYKueJp9 /Fa5q1rcz6jigVcqFEC4AVMwy5XuxvQXAwH8u3ekdcsFN8ftl1sPGkki7EBRv3jjFwKvUeg3NZi R8Gzo6iFJFyCmKqMUWtoJSCO/y6HfOSbJxIaO2AMFIo0gFiXKRkJqxtlKXxyr/eHQSLE1a3c5ng HmBu9GWjZZEac1/9TpoTtGu19mF+QJxkCgd+8kexdHQmyyPmb0SkONoHDuGNM+9OIJnw9TN2K0Z 79HaqMKR4/qYg4C7bs4w12nZ5xqipOWp3+0L2s2uATnQK/1q+lSfxqY= X-Received: by 2002:a05:6000:40cc:b0:3a5:2f23:3780 with SMTP id ffacd0b85a97d-3b1ffcd6a02mr2834557f8f.18.1751469942132; Wed, 02 Jul 2025 08:25:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFsUNCCRvW2G8ERz1v+CzxV36sRx/sOGiOA5hGIRC55Fq8/UJikBoj+bsw3If92RbCTbdxtOA== X-Received: by 2002:a05:6000:40cc:b0:3a5:2f23:3780 with SMTP id ffacd0b85a97d-3b1ffcd6a02mr2834527f8f.18.1751469941626; Wed, 02 Jul 2025 08:25:41 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a892e52ad2sm16118859f8f.48.2025.07.02.08.25.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Jul 2025 08:25:41 -0700 (PDT) Message-ID: Date: Wed, 2 Jul 2025 17:25:38 +0200 Precedence: bulk X-Mailing-List: linux-doc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 20/29] mm: convert "movable" flag in page->mapping to a page flag To: Harry Yoo Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-21-david@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 02.07.25 15:01, Harry Yoo wrote: > On Wed, Jul 02, 2025 at 02:01:33PM +0200, David Hildenbrand wrote: >> On 02.07.25 13:54, Harry Yoo wrote: >>> On Mon, Jun 30, 2025 at 03:00:01PM +0200, David Hildenbrand wrote: >>>> Instead, let's use a page flag. As the page flag can result in >>>> false-positives, glue it to the page types for which we >>>> support/implement movable_ops page migration. >>>> >>>> The flag reused by PageMovableOps() might be sued by other pages, so >>>> warning in case it is set in page_has_movable_ops() might result in >>>> false-positive warnings. >>>> >>>> Reviewed-by: Zi Yan >>>> Signed-off-by: David Hildenbrand >>>> --- >>> >>> LGTM, >>> Reviewed-by: Harry Yoo >>> >>> With a question: is there any reason to change the page flag >>> operations to use atomic bit ops? >> >> As we have the page lock in there, it's complicated. I thought about this >> when writing that code, and was not able to convince myself that it is safe. >> >> But that was when I was prototyping and reshuffling patches, and we would >> still have code that would clear the flag. > >> Given that we only allow setting the flag, it might be okay to use the >> non-atomic variant as long as there can be nobody racing with us when >> modifying flags. Especially trying to lock the folio concurrently is the big >> problem. >> >> In isolate_movable_ops_page(), there is a comment about checking the flag >> before grabbing the page lock, so that should be handled. > > Right. > >> I'll have to check some other cases in balloon/zsmalloc code. > > Okay, it's totally fine to go with atomic version and then > switching back to non atomic ops when we're sure it's safe. > I'll definitely do the following: diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h index 8b23a74963feb..5f2b570735852 100644 --- a/include/linux/page-flags.h +++ b/include/linux/page-flags.h @@ -1145,9 +1145,11 @@ PAGEFLAG(Isolated, isolated, PF_ANY); * the flag might be used in other context for other pages. Always use * page_has_movable_ops() instead. */ -PAGEFLAG(MovableOps, movable_ops, PF_NO_TAIL); +TESTPAGEFLAG(MovableOps, movable_ops, PF_NO_TAIL); +SETPAGEFLAG(MovableOps, movable_ops, PF_NO_TAIL); #else /* !CONFIG_MIGRATION */ -PAGEFLAG_FALSE(MovableOps, movable_ops); +TESTPAGEFLAG_FALSE(MovableOps, movable_ops); +SETPAGEFLAG_NOOP(MovableOps, movable_ops); #endif /* CONFIG_MIGRATION */ /** Because the flag must not get cleared. There is no __SETPAGEFLAG_NOOP yet, unfortunately. -- Cheers, David / dhildenb