From: Mario Limonciello <superm1@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: "Jean Delvare" <jdelvare@suse.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Yazen Ghannam" <yazen.ghannam@amd.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC"
<linux-i2c@vger.kernel.org>,
"open list:AMD PMC DRIVER" <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v5 5/5] x86/CPU/AMD: Print the reason for the last reset
Date: Wed, 30 Apr 2025 14:05:44 -0500 [thread overview]
Message-ID: <e80be47b-5f8d-409c-8c3d-cd1af46944d0@kernel.org> (raw)
In-Reply-To: <20250430190333.GIaBJ0BWuMdZ1KNVQ7@fat_crate.local>
On 4/30/2025 2:03 PM, Borislav Petkov wrote:
> On Tue, Apr 22, 2025 at 06:48:30PM -0500, Mario Limonciello wrote:
>> + /* Iterate on each bit in the 'value' mask: */
>> + while (true) {
>> + bit = find_next_bit(&value, BITS_PER_LONG, bit + 1);
>> +
>> + /* Reached the end of the word, no more bits: */
>> + if (bit >= BITS_PER_LONG) {
>> + if (!nr_reasons)
>> + pr_info("x86/amd: Previous system reset reason [0x%08lx]: Unknown\n", value);
>> + break;
>> + }
>> +
>> + if (!s5_reset_reason_txt[bit])
>> + continue;
>> +
>> + nr_reasons++;
>> + pr_info("x86/amd: Previous system reset reason [0x%08lx]: %s\n",
>> + value, s5_reset_reason_txt[bit]);
>> + }
>
> What happened to that simpler idea:
>
> https://lore.kernel.org/r/20250411125050.GEZ_kQKtYBfEMDQuXU@fat_crate.local
>
This one was more advantageous in that if multiple bits were set for any
reason we could get messages for all of them printed.
next prev parent reply other threads:[~2025-04-30 19:05 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 23:48 [PATCH v5 0/5] AMD Zen debugging documentation Mario Limonciello
2025-04-22 23:48 ` [PATCH v5 1/5] Documentation: Add AMD Zen debugging document Mario Limonciello
2025-04-22 23:48 ` [PATCH v5 2/5] i2c: piix4: Depends on X86 Mario Limonciello
2025-04-25 11:18 ` Andi Shyti
2025-04-26 9:42 ` Ingo Molnar
2025-04-28 18:18 ` Andi Shyti
2025-06-10 9:16 ` Geert Uytterhoeven
2025-06-10 9:24 ` Huacai Chen
2025-06-10 14:12 ` Mario Limonciello
2025-06-10 14:53 ` Hans de Goede
2025-06-10 14:55 ` Hans de Goede
2025-06-10 16:59 ` Geert Uytterhoeven
2025-06-10 18:52 ` Hans de Goede
2025-04-22 23:48 ` [PATCH v5 3/5] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd/fch.h Mario Limonciello
2025-04-25 11:18 ` Andi Shyti
2025-04-22 23:48 ` [PATCH v5 4/5] platform/x86/amd: pmc: use FCH_PM_BASE definition Mario Limonciello
2025-04-29 14:39 ` Ilpo Järvinen
2025-04-22 23:48 ` [PATCH v5 5/5] x86/CPU/AMD: Print the reason for the last reset Mario Limonciello
2025-04-30 19:03 ` Borislav Petkov
2025-04-30 19:05 ` Mario Limonciello [this message]
2025-04-30 19:10 ` Borislav Petkov
2025-04-30 19:17 ` Mario Limonciello
2025-04-30 19:25 ` Borislav Petkov
2025-04-30 19:32 ` Mario Limonciello
2025-04-30 19:38 ` Borislav Petkov
2025-05-01 8:31 ` Borislav Petkov
2025-05-04 6:38 ` Ingo Molnar
2025-04-23 15:02 ` [PATCH v5 0/5] AMD Zen debugging documentation Jonathan Corbet
2025-04-28 16:14 ` Mario Limonciello
2025-04-24 15:58 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e80be47b-5f8d-409c-8c3d-cd1af46944d0@kernel.org \
--to=superm1@kernel.org \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andi.shyti@kernel.org \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).