From: "Koenig, Christian" <Christian.Koenig@amd.com>
To: Sean Paul <sean@poorly.run>
Cc: Jonathan Corbet <corbet@lwn.net>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Dave Airlie <airlied@linux.ie>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Huang, Ray" <Ray.Huang@amd.com>,
Sean Paul <seanpaul@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
"Zhang, Jerry" <Jerry.Zhang@amd.com>
Subject: Re: [PATCH] Documentation: drm: Remove dangling pointer from drm-mm.rst
Date: Thu, 29 Nov 2018 16:26:48 +0000 [thread overview]
Message-ID: <e84d85d3-f3e7-7269-1f46-695807224c52@amd.com> (raw)
In-Reply-To: <CAMavQKLJ-ZD51oYzEzwFMHrRnM0hsLAaAayijphfat9w73rbJQ@mail.gmail.com>
Am 29.11.18 um 17:21 schrieb Sean Paul:
> On Thu, Nov 29, 2018 at 11:14 AM Christian König
> <ckoenig.leichtzumerken@gmail.com> wrote:
>> Am 29.11.18 um 17:11 schrieb Sean Paul:
>>> On Thu, Nov 29, 2018 at 10:58 AM Koenig, Christian
>>> <Christian.Koenig@amd.com> wrote:
>>>> Am 29.11.18 um 16:55 schrieb Sean Paul:
>>>>> From: Sean Paul <seanpaul@chromium.org>
>>>>>
>>>>> Fixes htmldocs build error:
>>>>> Error: Cannot open file ../drivers/gpu/drm/drm_global.c
>>>>>
>>>>> Fixes: 2bb42410b1bd ("drm: Remove drm_global.{c,h} v2")
>>>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>>>> Cc: Christian König <christian.koenig@amd.com>
>>>>> Cc: Junwei Zhang <Jerry.Zhang@amd.com>
>>>>> Cc: Alex Deucher <alexander.deucher@amd.com>
>>>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>>>> Cc: Maxime Ripard <maxime.ripard@bootlin.com>
>>>>> Cc: Sean Paul <sean@poorly.run>
>>>>> Cc: David Airlie <airlied@linux.ie>
>>>>> Cc: Christian Koenig <christian.koenig@amd.com>
>>>>> Cc: Huang Rui <ray.huang@amd.com>
>>>>> Cc: dri-devel@lists.freedesktop.org
>>>>> Signed-off-by: Sean Paul <seanpaul@chromium.org>
>>>> Reviewed-by: Christian König <christian.koenig@amd.com>
>>>>
>>> Thanks for the review. Perhaps the best course of action for this
>>> patch is to have Dave pick it directly and then we can backmerge it
>>> into amdgpu/drm-misc-next from there? I could also spin a topic branch
>>> that we could all merge.
>>>
>>> Thoughts?
>> My preference is that I pick it up and push it to Dave through Alex
>> fixes push.
>>
>> But just because the patch which broke this came the same way as well.
>>
> Yeah, unfortunately it's proliferated, and I'd rather not add hops to
> getting drm-misc-next fixed. Let's just do a topic branch and set a PR
> to Dave from that. We can both merge the topic branch asap and let
> Dave pick it up at his leisure.
Works for me as well,
Christian.
>
> Sean
>
>> Either way works for me,
>> Christian.
>>
>>> Sean
>>>
>>>>> ---
>>>>> Documentation/gpu/drm-mm.rst | 3 ---
>>>>> 1 file changed, 3 deletions(-)
>>>>>
>>>>> diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
>>>>> index d0f3c6b032009..54a696d961a7c 100644
>>>>> --- a/Documentation/gpu/drm-mm.rst
>>>>> +++ b/Documentation/gpu/drm-mm.rst
>>>>> @@ -79,9 +79,6 @@ count for the TTM, which will call your initialization function.
>>>>>
>>>>> See the radeon_ttm.c file for an example of usage.
>>>>>
>>>>> -.. kernel-doc:: drivers/gpu/drm/drm_global.c
>>>>> - :export:
>>>>> -
>>>>>
>>>>> The Graphics Execution Manager (GEM)
>>>>> ====================================
>>> _______________________________________________
>>> dri-devel mailing list
>>> dri-devel@lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-11-29 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 15:55 [PATCH] Documentation: drm: Remove dangling pointer from drm-mm.rst Sean Paul
2018-11-29 15:57 ` Koenig, Christian
2018-11-29 16:11 ` Sean Paul
2018-11-29 16:14 ` Christian König
2018-11-29 16:21 ` Sean Paul
2018-11-29 16:26 ` Koenig, Christian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e84d85d3-f3e7-7269-1f46-695807224c52@amd.com \
--to=christian.koenig@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Jerry.Zhang@amd.com \
--cc=Ray.Huang@amd.com \
--cc=airlied@linux.ie \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-doc@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox