Re: [cocci] [PATCH] HID: fix semantic patch and improve its performance

[Markus Elfring <Markus.Elfring@web.de>]

> Replace "expression" with "identifier" in the declaration of hdev.
> This is necessary because hdev is used as the name of a function
> parameter.
…
> +++ b/scripts/coccinelle/hid/ff_race.cocci
…
> -@r@
> +@r exists@
>  identifier probe_fn;
> -expression hdev, flags;
> +identifier hdev;

May the following SmPL code variant be applied?

 identifier hdev, probe_fn;


> +expression flags;
>  position p1, p2;
>  @@
>  
>  probe_fn(struct hid_device *hdev, ...) {
> -  <...
> +  ... when any
>    hid_hw_start@p1(hdev, flags)
>    ...
> -  \(input_ff_create\|input_ff_create_memless\)@p2(...)
> -  ...>
> +  \(input_ff_create@p2\|input_ff_create_memless@p2\)(...)

How do you think about to use the following SmPL code variation?

(input_ff_create@p2
|input_ff_create_memless@p2
)(...)


> +  ... when any
>  }
>  
>  @script:python depends on report@

Regards,
Markus