Linux Documentation
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: "Darrick J. Wong" <djwong@kernel.org>,
	Bart Van Assche <bvanassche@acm.org>
Cc: linux-doc@vger.kernel.org, corbet@lwn.net,
	linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
	kernel-dev@igalia.com, kernel@gpiccoli.net,
	Jan Kara <jack@suse.cz>
Subject: Re: [PATCH V2] Documentation: Document the kernel flag bdev_allow_write_mounted
Date: Fri, 23 Aug 2024 15:02:13 -0300	[thread overview]
Message-ID: <ebc06acd-f729-dcbf-b8b3-faf0b6cab9d2@igalia.com> (raw)
In-Reply-To: <20240823170559.GZ6082@frogsfrogsfrogs>

On 23/08/2024 14:05, Darrick J. Wong wrote:
> On Fri, Aug 23, 2024 at 09:11:22AM -0700, Bart Van Assche wrote:
>> On 8/23/24 7:26 AM, Guilherme G. Piccoli wrote:
>>> +	bdev_allow_write_mounted=
>>> +			Format: <bool>
>>> +			Control the ability of directly writing to mounted block
>>> +			devices' page cache, i.e., allow / disallow writes that
>>> +			bypasses the FS. This was implemented as a means to
>>> +			prevent fuzzers from crashing the kernel by overwriting
>>> +			the metadata underneath a mounted FS without its awareness.
>>> +			This also prevents destructive formatting of mounted
>>> +			filesystems by naive storage tooling that don't use
>>> +			O_EXCL. Default is Y and can be changed through the
>>> +			Kconfig option CONFIG_BLK_DEV_WRITE_MOUNTED.
>>> +
>>
>> Does this flag also affect direct I/O? If so, does this mean that the
>> reference to the page cache should be left out?
> 
> I think it does affect directio, since the validation is done at open
> time via bdev_may_open, right?
> 

Indeed, good point! It does affect direct I/O, I've just tested in
6.11-rc3 using dd (with and w/o oflags=direct), same result.

I'll resend, dropping the mention to page cache - thanks!

Guilherme

      reply	other threads:[~2024-08-23 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-23 14:26 [PATCH V2] Documentation: Document the kernel flag bdev_allow_write_mounted Guilherme G. Piccoli
2024-08-23 16:11 ` Bart Van Assche
2024-08-23 17:05   ` Darrick J. Wong
2024-08-23 18:02     ` Guilherme G. Piccoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebc06acd-f729-dcbf-b8b3-faf0b6cab9d2@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=bvanassche@acm.org \
    --cc=corbet@lwn.net \
    --cc=djwong@kernel.org \
    --cc=jack@suse.cz \
    --cc=kernel-dev@igalia.com \
    --cc=kernel@gpiccoli.net \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox