linux-doc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: Re: [PATCH v2 0/3] docs: some automarkup improvements
Date: Wed, 4 Jun 2025 18:05:06 -0400	[thread overview]
Message-ID: <ebeb020a-8403-441b-ab02-f017ffcb7b83@notapiano> (raw)
In-Reply-To: <20250604143645.78367-1-corbet@lwn.net>

On Wed, Jun 04, 2025 at 08:36:42AM -0600, Jonathan Corbet wrote:
> A small set of automarkup changes to improve the visual consistency
> of the rendered HTML documents.
> 
> Jonathan Corbet (3):
>   docs: automarkup: Remove some Sphinx 2 holdovers
>   docs: automarkup: Mark up undocumented entities too
>   docs: CSS: make cross-reference links more evident

This is much better. Markup, links and underlines are all looking good now.

The only other thing I noticed is that the links in the sidebar still use the
old style, since they rely on a different CSS selector for some reason:

  div.sphinxsidebar a {
    text-decoration: none;
    border-bottom: 1px dotted #999;
  }

That makes it a bit inconsistent style-wise, so I think it'd be sensible to
update that selector as well to follow suit.

In any case,

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

Thanks,
Nícolas

  parent reply	other threads:[~2025-06-04 22:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-04 14:36 [PATCH v2 0/3] docs: some automarkup improvements Jonathan Corbet
2025-06-04 14:36 ` [PATCH v2 1/3] docs: automarkup: Remove some Sphinx 2 holdovers Jonathan Corbet
2025-06-04 14:56   ` Mauro Carvalho Chehab
2025-06-04 14:36 ` [PATCH v2 2/3] docs: automarkup: Mark up undocumented entities too Jonathan Corbet
2025-06-04 14:57   ` Mauro Carvalho Chehab
2025-06-04 14:36 ` [PATCH v2 3/3] docs: CSS: make cross-reference links more evident Jonathan Corbet
2025-06-04 14:59   ` Mauro Carvalho Chehab
2025-06-04 22:05 ` Nícolas F. R. A. Prado [this message]
2025-06-05  3:00   ` [PATCH v2 0/3] docs: some automarkup improvements Bagas Sanjaya
2025-06-05 16:32   ` Jonathan Corbet
2025-06-06 15:57     ` Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ebeb020a-8403-441b-ab02-f017ffcb7b83@notapiano \
    --to=nfraprado@collabora.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).