From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C1ACC3F2D1 for ; Wed, 4 Mar 2020 21:26:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B94420838 for ; Wed, 4 Mar 2020 21:26:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388388AbgCDV0Y (ORCPT ); Wed, 4 Mar 2020 16:26:24 -0500 Received: from smtprelay0215.hostedemail.com ([216.40.44.215]:45176 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388364AbgCDV0Y (ORCPT ); Wed, 4 Mar 2020 16:26:24 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay01.hostedemail.com (Postfix) with ESMTP id 0BF45100E7B42; Wed, 4 Mar 2020 21:26:23 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: top47_1a6fca43cfd3c X-Filterd-Recvd-Size: 3754 Received: from XPS-9350.home (unknown [47.151.143.254]) (Authenticated sender: joe@perches.com) by omf18.hostedemail.com (Postfix) with ESMTPA; Wed, 4 Mar 2020 21:26:21 +0000 (UTC) Message-ID: Subject: Re: [PATCH] MAINTAINERS: adjust to filesystem doc ReST conversion From: Joe Perches To: Mauro Carvalho Chehab , Jonathan Corbet Cc: Lukas Bulwahn , linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 04 Mar 2020 13:24:48 -0800 In-Reply-To: <20200304212846.0c79c6da@coco.lan> References: <20200304072950.10532-1-lukas.bulwahn@gmail.com> <20200304131035.731a3947@lwn.net> <20200304212846.0c79c6da@coco.lan> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org On Wed, 2020-03-04 at 21:28 +0100, Mauro Carvalho Chehab wrote: > Em Wed, 4 Mar 2020 13:10:35 -0700 > Jonathan Corbet escreveu: > > > On Wed, 4 Mar 2020 08:29:50 +0100 > > Lukas Bulwahn wrote: > > > > > Mauro's patch series > > > ("[PATCH 00/44] Manually convert filesystem FS documents to ReST") > > > converts many Documentation/filesystems/ files to ReST. > > > > > > Since then, ./scripts/get_maintainer.pl --self-test complains with 27 > > > warnings on Documentation/filesystems/ of this kind: > > > > > > warning: no file matches F: Documentation/filesystems/... > > > > > > Adjust MAINTAINERS entries to all files converted from .txt to .rst in the > > > patch series and address the 27 warnings. > > > > > > Link: https://lore.kernel.org/linux-erofs/cover.1581955849.git.mchehab+huawei@kernel.org > > > Signed-off-by: Lukas Bulwahn > > > --- > > > Mauro, please ack. > > > Jonathan, pick pick this patch for doc-next. > > > > Sigh, I need to work a MAINTAINERS check into my workflow... > > > > Thanks for fixing these, but ... what tree did you generate the patch > > against? I doesn't come close to applying to docs-next. > > I'm starting to suspect that maybe the best workflow would be to just > apply the patches at docs-next keeping links broken, and then run > ./scripts/documentation-file-ref-check --fix by the end of a merge > window, addressing such breakages. I'm not sure at all that that script will always do the right thing with MAINTAINERS, but it seems to work OK except for some renames where a .txt file was directly renamed to a .rst file in the same directory where there was a similarly named file in a different directory. Likely the direct rename of a filename extension from .txt to .rst should always be applied by the script. Anyway, for -next as of today: $ git diff --shortstat 64 files changed, 116 insertions(+), 116 deletions(-) > There are usually lots of churn outside the merge window. > > Another alternative would be to split the MAINTAINERS file on a > per-subsystem basis. If I remember well, someone proposed this once at > LKML. I vaguely remember that there were even a patch (or RFC) > adding support for such thing for get_maintainers.pl. Yeah. get_maintainer.pl does work if the MAINTAINERS file is split up a few different ways. There was also a tool to do the MAINTAINERS split. https://lore.kernel.org/patchwork/patch/817857/ I doubt that would matter at all given today's tools and the general mechanisms of maintainers renaming files and not running checkpatch in the first place.