From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on archive.lwn.net X-Spam-Level: X-Spam-Status: No, score=-4.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,T_RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by archive.lwn.net (Postfix) with ESMTP id 907B37E66E for ; Fri, 9 Mar 2018 23:47:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849AbeCIXrD (ORCPT ); Fri, 9 Mar 2018 18:47:03 -0500 Received: from mga11.intel.com ([192.55.52.93]:40911 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbeCIXrC (ORCPT ); Fri, 9 Mar 2018 18:47:02 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2018 15:47:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,448,1515484800"; d="scan'208";a="32702695" Received: from yoojae-mobl1.amr.corp.intel.com (HELO [10.7.153.143]) ([10.7.153.143]) by FMSMGA003.fm.intel.com with ESMTP; 09 Mar 2018 15:47:01 -0800 Subject: Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs To: Milton Miller II , Pavel Machek Cc: linux-hwmon@vger.kernel.org, andrew@lunn.ch, jdelvare@suse.com, arnd@arndb.de, linux-doc@vger.kernel.org, andrew@aj.id.au, gregkh@linuxfoundation.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux@roeck-us.net, linux-arm-kernel@lists.infradead.org References: <20180307221124.GD10438@amd> <20180221161606.32247-1-jae.hyun.yoo@linux.intel.com> <20180221161606.32247-3-jae.hyun.yoo@linux.intel.com> <20180306124002.GA13950@amd> <33bf6563-b220-7ff9-8b04-84e9bd781b3f@linux.intel.com> From: Jae Hyun Yoo Message-ID: Date: Fri, 9 Mar 2018 15:47:01 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org Hi Milton, Thanks for sharing your time to review this patch. Please see my answer inline. Jae On 3/9/2018 3:41 PM, Milton Miller II wrote: > About 03/07/2018 04:12PM in some time zone, Pavel Machek wrote: >> Subject: Re: [PATCH v2 2/8] [PATCH 2/8] Documentations: dt-bindings: >> Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs >> >> Hi! >> >>>> Are these SoCs x86-based? >>> >>> Yes, these are ARM SoCs. Please see Andrew's answer as well. >> >> Understood, thanks. >> >>>>> + Read sampling point selection. The whole period of a bit time >> will be >>>>> + divided into 16 time frames. This value will determine which >> time frame >>>>> + this controller will sample PECI signal for data read back. >> Usually in >>>>> + the middle of a bit time is the best. >>>> >>>> English? "This value will determine when this controller"? >>>> >>> >>> Could I change it like below?: >>> >>> "This value will determine in which time frame this controller >> samples PECI >>> signal for data read back" >> >> I guess... I'm not native speaker, I guess this could be improved >> some >> more. >> > > I agree this wording is still confusing. > > The problem is that the key subject, the time of the sampling, is in the descriptive clause "in which time frame". > > "This value will determine the time frame in which the controller will sample" > > or perhaps phrase it as saving a specific sample from the over-clock, or a phase of the clock. > Yes, that looks more better. I'll change the wording as you suggested. Thanks a lot! Jae >> Best regards, >> Pavel >> >> -- >> (english) http://www.livejournal.com/~pavelmachek >> (cesky, pictures) >> http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html >> > > milton > -- > Speaking for myself not IBM. > -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html