From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: dave@stgolabs.net, dave.jiang@intel.com,
alison.schofield@intel.com, vishal.l.verma@intel.com,
ira.weiny@intel.com, dan.j.williams@intel.com, corbet@lwn.net,
linux-cxl@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, darren.kenny@oracle.com
Subject: Re: [PATCH] Documentation: cxl: fix typos and improve clarity in memory-devices.rst
Date: Mon, 9 Jun 2025 18:29:00 +0530 [thread overview]
Message-ID: <ee045330-c389-4661-b11e-c17d3e01f156@oracle.com> (raw)
In-Reply-To: <20250609115817.00003017@huawei.com>
I really appreciate your review, thanks a lot!
On 09-06-2025 16:28, Jonathan Cameron wrote:
>> These changes improve readability and accuracy of the documentation.
>>
>> Signed-off-by: Alok Tiwari<alok.a.tiwari@oracle.com>
> One additional comment given you are touching this text.
>
> Reviewed-by: Jonathan Cameron<jonathan.cameron@huawei.com>
>> ---
>> Documentation/driver-api/cxl/memory-devices.rst | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/Documentation/driver-api/cxl/memory-devices.rst b/Documentation/driver-api/cxl/memory-devices.rst
>> index d732c42526df..e9e2952a967d 100644
>> --- a/Documentation/driver-api/cxl/memory-devices.rst
>> +++ b/Documentation/driver-api/cxl/memory-devices.rst
>> @@ -29,8 +29,8 @@ Platform firmware enumerates a menu of interleave options at the "CXL root port"
>> (Linux term for the top of the CXL decode topology). From there, PCIe topology
>> dictates which endpoints can participate in which Host Bridge decode regimes.
>> Each PCIe Switch in the path between the root and an endpoint introduces a point
>> -at which the interleave can be split. For example platform firmware may say at a
>> -given range only decodes to 1 one Host Bridge, but that Host Bridge may in turn
>> +at which the interleave can be split. For example, platform firmware may say at a
> Should probably be "platform firmware may say that a given range"
"We addressed these parts based on Gregory Price's comments and
submitted version 2 of the patch."
use phrase -> "platform firmware may say a given range only"
>
>> +given range only decodes to one Host Bridge, but that Host Bridge may in turn
>> interleave cycles across multiple Root Ports. An intervening Switch between a
>> port and an endpoint may interleave cycles across multiple Downstream Switch
>> Ports, etc.
>> @@ -187,7 +187,7 @@ decodes them to "ports", "ports" decode to "endpoints", and "endpoints"
>> represent the decode from SPA (System Physical Address) to DPA (Device Physical
>> Address).
Thanks,
Alok
next prev parent reply other threads:[~2025-06-09 12:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-31 7:51 [PATCH] Documentation: cxl: fix typos and improve clarity in memory-devices.rst Alok Tiwari
2025-05-31 16:57 ` Randy Dunlap
2025-06-01 23:30 ` Gregory Price
2025-06-02 13:32 ` ALOK TIWARI
2025-06-09 10:58 ` Jonathan Cameron
2025-06-09 12:59 ` ALOK TIWARI [this message]
2025-06-09 16:36 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee045330-c389-4661-b11e-c17d3e01f156@oracle.com \
--to=alok.a.tiwari@oracle.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=darren.kenny@oracle.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).